Spec: http://miroslav.suchy.cz/fedora/spacewalk-branding/spacewalk-branding.spec SRC.RPM: http://miroslav.suchy.cz/fedora/spacewalk-branding/spacewalk-branding-1.3.1-1.el6.noarch.rpm Description: Spacewalk specific branding, CSS, and images. Rpmlint output: spacewalk-branding.noarch: W: non-conffile-in-etc /etc/rhn/default/rhn_docs.conf For this see reasoning in: https://bugzilla.redhat.com/show_bug.cgi?id=612581#c20 https://bugzilla.redhat.com/show_bug.cgi?id=612581#c16
Unfortunately the RPM is not SRC.RPM and I cant proceed with the review. Please send a link to the SRC RPM. Thanks.
Ops, sorry. Here it is: http://miroslav.suchy.cz/fedora/spacewalk-branding/spacewalk-branding-1.3.1-1.el6.src.rpm
The formal review follows: The formal review: MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.[1] OK MUST: The package must be named according to the Package Naming Guidelines . OK MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [2] . OK MUST: The package must meet the Packaging Guidelines . OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . OK MUST: The License field in the package spec file must match the actual license. [3] OK GPLv2 MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.[4] OK MUST: The spec file must be written in American English. [5] OK MUST: The spec file for the package MUST be legible. [6] OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. OK MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [7] OK MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK MUST: Packages must NOT bundle copies of system libraries.[11] OK MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [13] OK MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations)[14] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. [15] OK MUST: Each package must consistently use macros. [16] OK MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. [23] OK MUST: All filenames in rpm packages must be valid UTF-8. [24] OK Package APPROVED.
New Package CVS Request ======================= Package Name: spacewalk-branding Short Description: Spacewalk branding data Owners: msuchy Branches: F-14, EL-6 InitialCC:
This ticket is not assigned to anyone. It should be assigned to the reviewer. Please fix and re-raise the fedora-cvs flag.
Git done (by process-git-requests).
spacewalk-branding-1.3.1-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/spacewalk-branding-1.3.1-1.fc14
spacewalk-branding-1.3.1-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.