Bug 661833 (kdevelop-php) - Review Request: kdevelop-php - Php language plugin for KDevelop
Summary: Review Request: kdevelop-php - Php language plugin for KDevelop
Keywords:
Status: CLOSED ERRATA
Alias: kdevelop-php
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jaroslav Reznik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 647161 (view as bug list)
Depends On: kdevelop-pg-qt
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-12-09 18:41 UTC by Rex Dieter
Modified: 2011-12-08 18:19 UTC (History)
4 users (show)

Fixed In Version: kdevelop-php-1.1.1-3.fc13
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-01-18 21:31:53 UTC
Type: ---
Embargoed:
jreznik: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Comment 1 Rex Dieter 2010-12-09 18:50:15 UTC
rpmlint *.rpm x86_64/*.rpm
kdevelop-php.x86_64: E: invalid-soname /usr/lib64/libkdev4phpparser.so libkdev4phpparser.so
kdevelop-php.x86_64: E: invalid-soname /usr/lib64/libkdev4phpcompletion.so libkdev4phpcompletion.so
kdevelop-php.x86_64: E: invalid-soname /usr/lib64/libkdev4phpduchain.so libkdev4phpduchain.so
3 packages and 0 specfiles checked; 3 errors, 0 warnings.

Comment 2 Jaroslav Reznik 2010-12-10 13:09:19 UTC
Name: ok
Summary: ok
Version/Release: ok
Group: ok
License: not ok! most files in the archive are LGPLv2+, some even GPLv3+ (does not look like intention as it's just header, even not properly filled!), try licensecheck -> pls, contact upstream to clarify situation and to fix issues
URL: ok
Sources: md5sum ok (1f364430db7e8146fc2dee61a80417f4  kdevelop-php-1.1.1.tar.bz2, d93efbe0f4fa04070c27fd5a68152f95  kdevelop-php-docs-1.1.1.tar.bz2)
BuildRequires/Requires: ok
Description: ok
Build/make: ok

Looks ok but license and invalid-sonames.

Comment 3 Rex Dieter 2010-12-10 17:26:32 UTC
indeed, 
$ find . -print | grep -v test | xargs licensecheck | grep -v LGPL | sort | uniq
./app_templates/simple_phpapp/%{APPNAME}.php: *No copyright* UNKNOWN
./parser/parsesession.cpp: GPL (v2 or later) 
./parser/parsesession.h: GPL (v2 or later) 
./phpfunctions.php: *No copyright* GENERATED FILE
./phphighlighting.cpp: GPL (v3 or later) 
./phphighlighting.h: GPL (v3 or later) 
./phplanguagesupport.cpp: GPL (v2 or later) 
./phplanguagesupport.h: GPL (v2 or later) 
./phpparsejob.cpp: GPL (v2 or later) 
./phpparsejob.h: GPL (v2 or later) 

looks like we can go with 
License: GPLv2+

the libraries are not illegitimate, imo, rpmlint is just complaining about the lack of (versioned) sonames.

Any other blockers?

Comment 4 Rex Dieter 2010-12-10 17:40:22 UTC
Spec URL: http://rdieter.fedorapeople.org/rpms/kdevelop-php/kdevelop-php.spec
SRPM URL:
http://rdieter.fedorapeople.org/rpms/kdevelop-php/kdevelop-php-1.1.1-2.fc13.src.rpm

%changelog
* Fri Dec 10 2010 Rex Dieter <rdieter> -  1.1.1-2
- License: GPLv2+

Comment 5 Rex Dieter 2010-12-10 18:10:05 UTC
Oops, missed,
./phphighlighting.cpp: GPL (v3 or later) 
./phphighlighting.h: GPL (v3 or later) 

Spec URL: http://rdieter.fedorapeople.org/rpms/kdevelop-php/kdevelop-php.spec
SRPM URL:
http://rdieter.fedorapeople.org/rpms/kdevelop-php/kdevelop-php-1.1.1-3.fc13.src.rpm

%changelog
* Fri Dec 10 2010 Rex Dieter <rdieter> - 1.1.1-3
- License: GPLv3+

Comment 6 Rex Dieter 2010-12-10 18:39:49 UTC
Folks on #kdevelop irc confirmed the intent is to be GPLv2+ , and will work to relicense those files for upcoming releases.

Comment 7 Jaroslav Reznik 2010-12-14 13:22:32 UTC
ETA on this?

Comment 8 Rex Dieter 2010-12-14 16:59:25 UTC
ETA on kdevelop's next release?  no idea.  I figured we could ammend the license tag when/if that happens.

Comment 9 Jaroslav Reznik 2011-01-05 13:51:06 UTC
I'm going to approve this package with current license resolution as GPLv3+ and comment in SPEC file, update it once upstream releases fixed tarballs to GPLv2+. Thanks.

APPROVED

Comment 10 Rex Dieter 2011-01-05 14:23:18 UTC
New Package SCM Request
=======================
Package Name: kdevelop-php
Short Description: Php language plugin for KDevelop
Owners: rdieter than ltinkl thomasj kkofler
Branches: f13 f14
InitialCC: rnovacek tuxbrewr

Comment 11 Jason Tibbitts 2011-01-05 16:07:42 UTC
Git done (by process-git-requests).

Comment 12 Fedora Update System 2011-01-05 20:07:32 UTC
kdevelop-php-1.1.1-3.fc14,kdevelop-pg-qt-0.9.0-3.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/kdevelop-php-1.1.1-3.fc14,kdevelop-pg-qt-0.9.0-3.fc14

Comment 13 Fedora Update System 2011-01-05 20:08:01 UTC
kdevelop-php-1.1.1-3.fc13,kdevelop-pg-qt-0.9.0-3.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/kdevelop-php-1.1.1-3.fc13,kdevelop-pg-qt-0.9.0-3.fc13

Comment 14 Fedora Update System 2011-01-06 19:23:41 UTC
kdevelop-php-1.1.1-3.fc14, kdevelop-pg-qt-0.9.0-3.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update kdevelop-php kdevelop-pg-qt'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/kdevelop-php-1.1.1-3.fc14,kdevelop-pg-qt-0.9.0-3.fc14

Comment 15 Fedora Update System 2011-01-18 21:31:42 UTC
kdevelop-php-1.1.1-3.fc14, kdevelop-pg-qt-0.9.0-3.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2011-01-18 21:38:16 UTC
kdevelop-php-1.1.1-3.fc13, kdevelop-pg-qt-0.9.0-3.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 17 Kevin Kofler 2011-06-02 13:02:50 UTC
*** Bug 647161 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.