Spec URL: http://lmacken.fedorapeople.org/rpms/moksha.spec SRPM URL: http://lmacken.fedorapeople.org/rpms/moksha-0.5.0-1.fc14.src.rpm Description: Moksha is a platform for creating real-time collaborative web applications. It. provides a set of Python and JavaScript API's that make it simple to create. rich applications that can acquire, manipulate, and visualize data from. external services. It is a unified framework build using the best available. open source technologies such as TurboGears2, jQuery, AMQP, and Orbited. More. information can be found on the Moksha Project Page at.
# MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. moksha.src: W: spelling-error %description -l en_US jQuery -> j Query, query, equerry moksha.src:150: E: files-attr-not-set moksha.src:151: E: files-attr-not-set moksha.src:152: E: files-attr-not-set moksha.src: W: invalid-url Source0: moksha-0.5.0.tar.bz2 moksha.spec:150: E: files-attr-not-set moksha.spec:151: E: files-attr-not-set moksha.spec:152: E: files-attr-not-set moksha.spec: W: invalid-url Source0: moksha-0.5.0.tar.bz2 1 packages and 1 specfiles checked; 6 errors, 3 warnings. You should fix the files-addr-not-set ones, just need a %defattr directive after line 148. The source one should be fixed too. It should be a full URI to the file. I recommend specifying the file as %{name}-%{version}.tar.gz if upstream's naming is consistent enough. You omitted the end of the last sentence in the description. Looks like # MUST: The package must be named according to the Package Naming Guidelines . Looks good. # MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [2] . Yep. # MUST: The package must meet the Packaging Guidelines . Yep. # MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . Yep. # MUST: The License field in the package spec file must match the actual license. [3] You have a file called LICENSE and a file called COPYING. Both the same. Won't fault it but seems redundant. # MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.[4] You also copy both files to disk. This must be some new thing I haven't heard about. # MUST: The spec file must be written in American English. [5] Yep. # MUST: The spec file for the package MUST be legible. [6] Fine. # MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. Haven't found the actual URL, and as noted above you didn't put it in Source0. Please enlighten. # MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [7] # MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. [8] Its a noarch. # MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. I built in mock, so I'm assuming this is good. # MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9] N/A # MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [10] N/A # MUST: Packages must NOT bundle copies of system libraries.[11]' Fine # MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. [12] Fine. # MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [13] Looks good. # MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations)[14] Good. # MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. [15] See rpmlint output. # MUST: Each package must consistently use macros. [16] Good. # MUST: The package must contain code, or permissable content. [17] Good. # MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [18] You called it -doc. # MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [18] Looks ok. # MUST: Header files must be in a -devel package. [19] N/A # MUST: Static libraries must be in a -static package. [20] N/A # MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [19] N/A # MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} [21] N/A # MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.[20] N/A # MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. [22] N/A # MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. [23] Fine # MUST: All filenames in rpm packages must be valid UTF-8. Fine
# SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [25] N/A # SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [26] I'll leave that to you. # SHOULD: The reviewer should test that the package builds in mock. [27] Did. # SHOULD: The package should compile and build into binary rpms on all supported architectures. [28] Its noarch. # SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. What's a good way to test this'un? I'll trust you if you want since you say this package has been around a bit. # SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. [29] Is that post section a good example of how to distribute selinux policy? Might want to ask dwalsh about that. # SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [21] Looks ok. # SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb. [30] N/A # SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. [31] Fine. # SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense.[32] This would be nice for moksha and moksha-hub.
With regard to the SELinux stuff in %post, I asked dwalsh about it a while ago, and he said that was fine. I'll run it by him again. I'll file a ticket upstream to write up some man pages. As for testing the package, the entire test suite runs in %check, but I'll figure out and document the easiest way to get things running locally after it is installed. Spec URL: http://lmacken.fedorapeople.org/rpms/moksha.spec SRPM URL: http://lmacken.fedorapeople.org/rpms/moksha-0.5.0-2.fc14.src.rpm * Fri Dec 10 2010 Luke Macken <lmacken> - 0.5.0-2 - Fix our Source URL - Fix files-attr-not-set rpmlint errors - Fix up the description - Remove redundant license
Actually remembered to run the lint tool on the output this time. moksha.noarch: W: spelling-error %description -l en_US jQuery -> j Query, query, equerry Ignore moksha.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/moksha/widgets/blueprint/static/src/print.css moksha.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/moksha/widgets/blueprint/static/src/grid.css moksha.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/moksha/widgets/blueprint/static/src/grid.css moksha.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/moksha/widgets/blueprint/static/plugins/sprites/sprite.css These are being installed with +x. Fix please. moksha.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/moksha/commands/cli.py 0644L /usr/bin/env I think ignore... looks like it found a shebang in it? Should that be there? moksha.noarch: W: hidden-file-or-dir /usr/lib/python2.7/site-packages/moksha/api/widgets/buttons/static/images/orange/.DS_Store NO! This needs fixing moksha.noarch: E: non-standard-dir-perm /var/lib/moksha 0700L Is this necessary? If so carry on. moksha.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/moksha/widgets/blueprint/static/src/reset.css Another css file with +x. moksha.noarch: W: hidden-file-or-dir /usr/lib/python2.7/site-packages/moksha/api/widgets/buttons/static/images/default/.DS_Store Again. No friggin way. moksha.noarch: W: no-manual-page-for-binary moksha-hub moksha.noarch: W: no-manual-page-for-binary moksha Knew about these. moksha.noarch: E: init-script-without-chkconfig-postin /etc/init.d/moksha-hub moksha.noarch: E: init-script-without-chkconfig-preun /etc/init.d/moksha-hub Probably a good idea to fix. moksha.noarch: E: no-chkconfig-line /etc/init.d/moksha-hub Do fix this one. moksha.noarch: W: incoherent-init-script-name moksha-hub ('moksha', 'mokshad') Ignore (God there's some stupid checks in lint these days). moksha.src: W: spelling-error %description -l en_US jQuery -> j Query, query, equerry Ignore moksha-docs.noarch: W: hidden-file-or-dir /usr/share/doc/moksha-docs-0.5.0/html/.buildinfo What is this? moksha-server.noarch: W: spelling-error Summary(en_US) wsgi -> swig, wigs moksha-server.noarch: W: summary-not-capitalized C mod_wsgi Moksha server moksha-server.noarch: W: spelling-error %description -l en_US wsgi -> swig, wigs moksha-server.noarch: W: no-documentation Ugh. Ignore all of these. moksha-server.noarch: E: executable-marked-as-config-file /etc/httpd/conf.d/moksha.conf moksha-server.noarch: E: script-without-shebang /etc/httpd/conf.d/moksha.conf moksha-server.noarch: E: script-without-shebang /usr/share/moksha/production/rabbitmq/rabbitmq-codegen-amqp-codegen.patch moksha-server.noarch: E: script-without-shebang /usr/share/moksha/production/sample-production.ini More extraneous +x bits. moksha-server.noarch: E: non-standard-dir-perm /var/cache/moksha 0700L Again please inform me if this is necessary. moksha-server.noarch: E: script-without-shebang /usr/share/moksha/production/apache/moksha.conf moksha-server.noarch: E: script-without-shebang /usr/share/moksha/production/nginx/moksha.conf moksha-server.noarch: E: script-without-shebang /usr/share/moksha/production/apache/moksha.wsgi moksha-server.noarch: E: script-without-shebang /usr/share/moksha/production/orbited.cfg And more useless +x bits. On another note: yum list | sed 's/\..*//' | grep -e '-docs\?$' | awk -F- '{ print $NF }' | sort | uniq -c Yields: 443 doc 102 docs So renaming the -docs package to -doc would make me personally happy. OCD is delicious. Looks like the rest of the old stuff is fixed though.
Spec URL: http://lmacken.fedorapeople.org/rpms/moksha.spec SRPM URL: http://lmacken.fedorapeople.org/rpms/moksha-0.5.0-3.fc14.src.rpm * Tue Dec 14 2010 Luke Macken <lmacken> - 0.5.0-3 - Handle ghosting /var/run/moksha - Setup a log directory - Get the moksha-hub init script working properly - A variety of specfile cleanups from our package review (#661902)
Among the other things we said we would ignore was this: moksha.noarch: W: log-files-without-logrotate /var/log/moksha Hmm... not run in to this before... what's your thoughts? If it doesn't need log rotating then we can be done.
Spec URL: http://lmacken.fedorapeople.org/rpms/moksha.spec SRPM URL: http://lmacken.fedorapeople.org/rpms/moksha-0.5.0-4.fc14.src.rpm * Wed Dec 15 2010 Luke Macken <lmacken> - 0.5.0-4 - Add a logrotate configuration
And we're good.
New Package SCM Request ======================= Package Name: moksha Short Description: A platform for creating real-time web applications Owners: lmacken johnp Branches: f13 f14 el6 el5
Review tickets should be assigned to the reviewer.
Git done (by process-git-requests).