Bug 666438 - Man page for fence_ilo lists incorrect option for specifying port
Summary: Man page for fence_ilo lists incorrect option for specifying port
Keywords:
Status: CLOSED DUPLICATE of bug 488959
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: cman
Version: 5.7
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: rc
: ---
Assignee: Lon Hohberger
QA Contact: Cluster QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-12-30 18:46 UTC by Adam Drew
Modified: 2018-10-27 11:19 UTC (History)
3 users (show)

Fixed In Version: cman-2.0.115-75.el5
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-03-21 23:28:13 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Patch to add proper port information to fence_ilo's help and man page (1.92 KB, patch)
2011-01-13 16:51 UTC, Adam Drew
no flags Details | Diff

Description Adam Drew 2010-12-30 18:46:49 UTC
Description of problem:
In the fence_ilo man page it says the following with regards to specifying a port number:

"-a IPaddress[:port]
IP  address  or  hostname  of  the  iLO card.  If the SSL server of the card is not running on the default SSL port, 443, then [:port] will also need to be specified."

Neither fence_ilo nor fencing.py know to look for a colon in the -a, parse out the port and assign it to -u. So, instead, you'll end up with a bogus IP and default port of 443. If you strace it you'll end up with something like the following:

[root@node1 /]# strace -fto /tmp/fence_test.out fence_ilo -a 192.168.160.1:22 -l root -p redhat 
Unable to connect/login to fencing device
[root@node1 /]# grep telnet_ssl /tmp/fence_test.out | grep 192.168
11344 13:44:19 execve("/usr/lib/fence/telnet_ssl", ["/usr/lib/fence/telnet_ssl", "192.168.160.1:22", "443"], [/* 24 vars */]) = 0

But if you use --ipport like fencing.py specifies it correctly specifies the port:

[root@node1 /]# strace -fto /tmp/fence_test.out fence_ilo -a 192.168.160.1 --ipport 22 -l root -p redhat 
Unable to connect/login to fencing device
[root@node1 /]# grep telnet_ssl /tmp/fence_test.out | grep 192.168
11380 13:46:16 execve("/usr/lib/fence/telnet_ssl", ["/usr/lib/fence/telnet_ssl", "192.168.160.1", "22"], [/* 24 vars */]) = 0

So it seems like the man page should be updated to reflect this.

Comment 1 Adam Drew 2010-12-30 19:09:08 UTC
This is cman-2.0.115-34.el5_5.4 by the way.

-u works just as well as --ipport

Patch to update fence/man/fence_ilo.8 in the cman source package

@@ -28,11 +28,10 @@ NOTE: fence_ilo deprecates fence_rib.  

 .SH OPTIONS
 .TP
-\fB-a\fP \fIIPaddress\fR
-IP address or hostname of the iLO card. 
-.TP
-\fB-u\fP
-Port that the SSL server of the card is running on. Default is 443.
+\fB-a\fP \fIIPaddress[:port]\fR
+IP address or hostname of the iLO card.  If the SSL server of the card is
+not running on the default SSL port, 443, then [:port] will also need to be
+specified.
 .TP
 \fB-h\fP 
 Print out a help message describing available options, then exit.
@@ -71,9 +70,6 @@ This option is used by fence_node(8) and
 \fIhostname = < hostname | ip >\fR
 IP address or hostname of the iLO card.
 .TP
-\fIipport  = < port >\fR
-Port number that the card's SSL server is listening on.
-.TP
 \fIlogin = < param >\fR
 Login name.
 .TP

Comment 2 Lon Hohberger 2011-01-03 18:56:26 UTC
1) Patch looks backwards compared to the description.

2) Can you just attach the patch instead of pasting inline in a comment?  Bugzilla has a nasty habit of mangling this sort of thing.

Comment 3 Adam Drew 2011-01-13 16:51:49 UTC
Created attachment 473371 [details]
Patch to add proper port information to fence_ilo's help and man page

Comment 4 Adam Drew 2011-01-13 16:53:18 UTC
Sorry, that was my first attempt at a patch. I've learned a lot since then. I uploaded a proper patch file. I also expanded it a little to add the port option to fence_ilo's help.

Hope this is better. Let me know if there's anything else!

Comment 5 Lon Hohberger 2011-03-21 23:28:13 UTC
This is fixed in 2.0.115-72.el5 as a consequence of fixing of bug 488959

*** This bug has been marked as a duplicate of bug 488959 ***


Note You need to log in before you can comment on or make changes to this bug.