That this is my first package and I need a sponsor. Srpm: http://repo.pclinuxos.su/fedora/rpm/zyGrib-3.9.8-1.fc14.src.rpm Spec: http://repo.pclinuxos.su/fedora/rpm/zyGrib.spec Description: ZyGrib is a GRIB file viewer. It enables : Visualisation of meteo data from files in GRIB Format Automatic GRIB data download Automatic Download from IAC (fleet-code) Data Roh or compressed GRIB Data (gzip *.gz; bzip2 *.bz2) can be used Project home: http://www.zygrib.org/ mock build: ok koji build: ok https://koji.fedoraproject.org/koji/taskinfo?taskID=2695155
Just some quick comments: - You are mixing %{buildroot} and $RPM_BUILD_ROOT - From my point of view the maps should go to a subpackages because they are huge. - The maps are distributed under GPL with not version indicated. - README files should be mentioned in %doc
1) Fixed 2) Ok. I cannot upload zyGrib-maps rpm today, because there is very slow Internet speed. I'll upload it in Monday. 3) Fixed 4) Fixed. There isn't README file in sources. I put it separately.
Corrected SRPM and spec: http://repo.pclinuxos.su/fedora/rpm/zyGrib.spec http://repo.pclinuxos.su/fedora/rpm/zyGrib-3.9.8-2.fc14.src.rpm
Please check https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files for the installation of the desktop file.
- fixed - update to new upstream version 3.9.9 mock: ok koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2714454 SRPM: http://repo.pclinuxos.su/fedora/rpm/zyGrib-3.9.9-1.fc14.src.rpm spec: http://repo.pclinuxos.su/fedora/rpm/zyGrib.spec
zyGryb-3.9.9-2 - Replace patch to sed - Remove %clean and BuildRoot mock: ok koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2716450 rpmlint output: zyGrib.src: W: spelling-error Summary(en_US) meteo -> metro, mete, meteor zyGrib.src: W: spelling-error %description -l en_US meteo -> metro, mete, meteor zyGrib.src: W: spelling-error %description -l en_US gzip -> zip, grip, g zip zyGrib.src: W: spelling-error %description -l en_US gz -> g, z, gaz zyGrib.src: W: invalid-url Source0: zyGrib-3.9.9.tgz 1 packages and 0 specfiles checked; 0 errors, 5 warnings.
Unblocking FE-NEEDSPONSOR - I just sponsored Pavel.
I'll review it
moved to fedorapeople SRPM: http://landgraf.fedorapeople.org/packages/requested/zygrib/zyGrib-3.9.9-2.fc14.src.rpm SPEC: http://landgraf.fedorapeople.org/packages/requested/zygrib/zyGrib.spec
Koji scratchbuild for F-15: http://koji.fedoraproject.org/koji/taskinfo?taskID=2896842 Needs love: * Bundled libraries - bzip2, zlib, proj. I'm pretty sure that the main package is linked against system-wide copies, but I prefer bundled ones to be removed at the %prep stage. * Please, replace macros for sed, cp and rm invocation by real names of these utilities. * The package contains bundled font (liberation). I suspect that appropriate "Requires" should be added. Could you, please, investigate this? * The License tag should be GPLv3+.
Fixed all. http://landgraf.fedorapeople.org/packages/requested/zygrib/zyGrib.spec http://landgraf.fedorapeople.org/packages/requested/zygrib/zyGrib-3.9.9-3.fc14.src.rpm -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers
Koji scratch build for F15: http://koji.fedoraproject.org/koji/taskinfo?taskID=2904218
REVIEW: Legend: + = PASSED, - = FAILED, 0 = Not Applicable - rpmlint is not completely silent: work ~/Desktop: rpmlint zyGrib-* zyGrib.src: W: spelling-error Summary(en_US) meteo -> metro, mete, meteor zyGrib.src: W: spelling-error %description -l en_US meteo -> metro, mete, meteor zyGrib.src: W: spelling-error %description -l en_US gzip -> zip, grip, g zip zyGrib.src: W: spelling-error %description -l en_US gz -> g, z, gaz ^^^ this should be omitted zyGrib.src: W: invalid-url Source0: zyGrib-3.9.9.tgz ^^^ This is also OK (no direct link) zyGrib.x86_64: W: spelling-error Summary(en_US) meteo -> metro, mete, meteor zyGrib.x86_64: W: spelling-error %description -l en_US meteo -> metro, mete, meteor zyGrib.x86_64: W: spelling-error %description -l en_US gzip -> zip, grip, g zip zyGrib.x86_64: W: spelling-error %description -l en_US gz -> g, z, gaz ^^^ This should be omitted zyGrib.x86_64: W: incoherent-version-in-changelog -3.9.9-3 ['3.9.9-3.fc15', '3.9.9-3'] ^^^ This should be fixed (caused by mising space between dash and version in %changelog) zyGrib.x86_64: W: no-manual-page-for-binary zyGrib ^^ That's OK too 3 packages and 0 specfiles checked; 0 errors, 11 warnings. work ~/Desktop: + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license (GPLv3 or later). + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package, match the upstream source, as provided in the spec URL. work ~/Desktop: work ~/Desktop: sha256sum zyGrib-3.9.9.tgz* a2016109e09307e73eeabbbe78ac6814043778a3cd67234bf789f57273a48399 zyGrib-3.9.9.tgz a2016109e09307e73eeabbbe78ac6814043778a3cd67234bf789f57273a48399 zyGrib-3.9.9.tgz.orig work ~/Desktop: + The package successfully compiles and builds into binary rpms on at least one primary architecture. See koji link above. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No shared library files in some of the dynamic linker's default paths. + The package does NOT bundle copies of system libraries. 0 The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. 0 The package DOESN'T have a %clean section, so it won't build cleanly on systems with old rpm (EL-4 and EL-5, not sure about EL-6). Beware. + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No header files. 0 No static libraries. 0 No pkgconfig(.pc) files. 0 The package doesn't contain library files without a suffix (e.g. libfoo.so). 0 No devel sub-package. + The package does NOT contain any .la libtool archives. + The package includes a %{name}.desktop file, and this file is properly installed with desktop-file-install in the %install section. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages are valid UTF-8. Ok. I can;t find any other issues, so this package is APPROVED.
New Package CVS Request ======================= Package Name: zyGrib Short Description: Visualization of meteo data from files in GRIB Format Owners: landgraf Branches: F-13 F-14 F-15 InitialCC: -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers
Git done (by process-git-requests).
zyGrib-3.9.9-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/zyGrib-3.9.9-3.fc14
zyGrib-3.9.9-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/zyGrib-3.9.9-3.fc13
zyGrib-3.9.9-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/zyGrib-3.9.9-3.fc15
-- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers
zyGrib-3.9.9-3.fc15 has been pushed to the Fedora 15 stable repository.
zyGrib-3.9.9-3.fc14 has been pushed to the Fedora 14 stable repository.
zyGrib-3.9.9-3.fc13 has been pushed to the Fedora 13 stable repository.