Bug 667221 (phonon-backend-xine) - Review Request: phonon-backend-xine - Xine phonon backend
Summary: Review Request: phonon-backend-xine - Xine phonon backend
Keywords:
Status: CLOSED RAWHIDE
Alias: phonon-backend-xine
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jaroslav Reznik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-01-04 20:30 UTC by Rex Dieter
Modified: 2011-01-05 20:03 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2011-01-05 20:03:58 UTC
Type: ---
Embargoed:
jreznik: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Rex Dieter 2011-01-04 20:30:11 UTC
\Spec URL: http://rdieter.fedorapeople.org/rpms/phonon/phonon-xine.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/phonon/phonon-xine-4.4.4-0.1.20110104.fc13.src.rpm
Description: Xine backend for phonon

Phonon upstream has split the core library from backend development now, so this is the new standalone phonon-xine.

Comment 1 Rex Dieter 2011-01-04 20:34:08 UTC
The requisite phonon-4.4.4 srpm is available @  http://rdieter.fedorapeople.org/rpms/phonon/ .  phonon in dist-git will get updated to this, once the split backend reviews are completed.

Comment 2 Rex Dieter 2011-01-05 14:14:09 UTC
Spec URL: http://rdieter.fedorapeople.org/rpms/phonon/phonon-backend-xine.spec
SRPM URL:
http://rdieter.fedorapeople.org/rpms/phonon/phonon-backend-xine-4.4.4-0.2.20110104.fc13.src.rpm

%changelog
* Wed Jan 05 2011 Rex Dieter <rdieter> -  4.4.4-0.2.20110104
- phonon-backend-xine

Comment 3 Jaroslav Reznik 2011-01-05 14:24:39 UTC
Name: ok
Summary: ok
Release and version: ok, snapshot
Group: ok
License: ok
URL: ok
Source: not ok, document phonon_snaphost.sh usage to obtain snapshot tarballs,
strange permissions, see rpmlint output
BuildRequires: ok
Obsoletes/Provides: ok
Description: ok
Post sections: ok
Consistent usage of macros: ok
Documentation: not ok, please include COPYING.LIB

Phonon backends directiories owned by Phonon package (required): ok

RPMLint
phonon-backend-xine.src: W: spelling-error Summary(en_US) backend -> backed, backbend,
back end
phonon-backend-xine.src: W: spelling-error %description -l en_US backend -> backed,
backbend, back end
phonon-backend-xine.src: W: strange-permission phonon-xine_snapshot.sh 0775L
phonon-backend-xine.src: W: invalid-url Source0: phonon-xine-4.4.4-20110104.tar.bz2

phonon-backend-xine.x86_64: W: no-documentation

Comment 4 Rex Dieter 2011-01-05 14:40:19 UTC
Spec URL: http://rdieter.fedorapeople.org/rpms/phonon/phonon-backend-xine.spec
SRPM URL:
http://rdieter.fedorapeople.org/rpms/phonon/phonon-backend-xine-4.4.4-0.3.20110104.fc13.src.rpm

%changelog
* Wed Jan 05 2011 Rex Dieter <rdieter> -  4.4.4-0.3.20110104
- %%doc COPYING.LIB
- add comment on pnonon-xine_snapshot.sh usage

Comment 5 Jaroslav Reznik 2011-01-05 15:02:18 UTC
Thanks.

APPROVED

Comment 6 Rex Dieter 2011-01-05 15:17:06 UTC
New Package SCM Request
=======================
Package Name: phonon-backend-xine
Short Description: Xine phonon backend
Owners: rdieter than ltinkl jreznik thomasj kkofler
Branches: f13 f14
InitialCC: tuxbrewr

Comment 7 Jason Tibbitts 2011-01-05 16:11:11 UTC
Git done (by process-git-requests).

Comment 8 Rex Dieter 2011-01-05 20:03:58 UTC
Thanks!  imported/built for rawhide now.


Note You need to log in before you can comment on or make changes to this bug.