Bug 668112 - virt-filesystems command fails on guest with corrupt filesystem label
Summary: virt-filesystems command fails on guest with corrupt filesystem label
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libguestfs   
(Show other bugs)
Version: unspecified
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact:
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: 668115
TreeView+ depends on / blocked
 
Reported: 2011-01-07 22:38 UTC by Richard W.M. Jones
Modified: 2011-01-08 10:20 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 668115 (view as bug list)
Environment:
Last Closed: 2011-01-08 10:20:41 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
virt-filesystems -v -x output (38.63 KB, text/plain)
2011-01-07 22:39 UTC, Richard W.M. Jones
no flags Details

Description Richard W.M. Jones 2011-01-07 22:38:01 UTC
Description of problem:

virt-filesystems -d Ubuntu1010x64 --long --all -h
libguestfs: error: vfs_label: /dev/vda2: 

Version-Release number of selected component (if applicable):

libguestfs-1.8.0-1.fc14.x86_64

Comment 1 Richard W.M. Jones 2011-01-07 22:39:16 UTC
Created attachment 472310 [details]
virt-filesystems -v -x output

Full output from the command:

virt-filesystems -d Ubuntu1010x64 --long --all -h -v -x

Comment 2 Richard W.M. Jones 2011-01-07 22:43:41 UTC
/dev/vda2 is an extended partition (containing a logical
partition which is the swap).  Therefore it doesn't make
sense to run guestfs_vfs_label on it.  We should just ignore
the result of vfs_label if it's an error.

Comment 3 Richard W.M. Jones 2011-01-08 10:14:39 UTC
Reproducer:

$ guestfish -N part exit
$ virt-filesystems -a test1.img --all --long -h
libguestfs: error: vfs_label: /dev/vda1: 

When the bug is fixed it produces the following output instead:

$ guestfish -N part exit
$ virt-filesystems -a test1.img --all --long -h
Name       Type        VFS      Label  Size  Parent
/dev/sda1  filesystem  unknown  -      100M  -
/dev/sda1  partition   -        -      100M  /dev/sda
/dev/sda   device      -        -      100M  -


Note You need to log in before you can comment on or make changes to this bug.