668115 – virt-filesystems command fails on guest with corrupt filesystem label

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 668115 - virt-filesystems command fails on guest with corrupt filesystem label

Summary: virt-filesystems command fails on guest with corrupt filesystem label

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Red Hat Enterprise Linux 6
Classification:	Red Hat
Component:	libguestfs
Sub Component:
Version:	6.1
Hardware:	Unspecified
OS:	Unspecified
Priority:	low
Severity:	medium
Target Milestone:	rc
Target Release:	---
Assignee:	Richard W.M. Jones
QA Contact:	Virtualization Bugs
Docs Contact:
URL:
Whiteboard:
Depends On:	668112
Blocks:
TreeView+	depends on / blocked

Reported:	2011-01-07 22:44 UTC by Richard W.M. Jones
Modified:	2015-09-28 02:22 UTC (History)
CC List:	5 users (show)
Fixed In Version:	libguestfs-1.7.17-8.el6
Doc Type:	Bug Fix
Doc Text:	The virt-filesystems command failed when used on a guest which had a missing or corrupt file system label. This command has been updated to handle guest file systems with missing or corrupt file system labels. Note that this bug was reported and corrected during development. It was not seen in production systems in the field.
Clone Of:	668112
Environment:
Last Closed:	2011-05-19 11:45:57 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2011:0586	0	normal	SHIPPED_LIVE	Low: libguestfs security, bug fix, and enhancement update	2011-05-19 11:44:03 UTC

Description Richard W.M. Jones 2011-01-07 22:44:23 UTC

+++ This bug was initially created as a clone of Bug #668112 +++

Description of problem:

virt-filesystems -d Ubuntu1010x64 --long --all -h
libguestfs: error: vfs_label: /dev/vda2: 

Version-Release number of selected component (if applicable):

libguestfs-1.8.0-1.fc14.x86_64

--- Additional comment from rjones on 2011-01-07 17:39:16 EST ---

Created attachment 472310 [details]
virt-filesystems -v -x output

Full output from the command:

virt-filesystems -d Ubuntu1010x64 --long --all -h -v -x

--- Additional comment from rjones on 2011-01-07 17:43:41 EST ---

/dev/vda2 is an extended partition (containing a logical
partition which is the swap).  Therefore it doesn't make
sense to run guestfs_vfs_label on it.  We should just ignore
the result of vfs_label if it's an error.

Comment 1 Richard W.M. Jones 2011-01-08 10:14:45 UTC

Reproducer:

$ guestfish -N part exit
$ virt-filesystems -a test1.img --all --long -h
libguestfs: error: vfs_label: /dev/vda1: 

When the bug is fixed it produces the following output instead:

$ guestfish -N part exit
$ virt-filesystems -a test1.img --all --long -h
Name       Type        VFS      Label  Size  Parent
/dev/sda1  filesystem  unknown  -      100M  -
/dev/sda1  partition   -        -      100M  /dev/sda
/dev/sda   device      -        -      100M  -

Comment 2 Richard W.M. Jones 2011-01-08 10:20:28 UTC

Fix posted upstream:
http://git.annexia.org/?p=libguestfs.git;a=commitdiff;h=97339a0f43d687efac6f7edafdf21e4b8d9b35e8

Comment 4 Lei Wang 2011-02-01 03:00:51 UTC

Following the steps in Comment 1:

Reproduce the issue with libguestfs-1.7.17-4.el6:

# guestfish -N part exit
# virt-filesystems -a test1.img --all --long -h
libguestfs: error: vfs_label: /dev/vda1:

Verfied the issue with libguestfs-1.7.17-10.el6:

# virt-filesystems -a test1.img --all --long -h
Name       Type        VFS      Label  Size  Parent
/dev/sda1  filesystem  unknown  -      100M  -
/dev/sda1  partition   -        -      100M  /dev/sda
/dev/sda   device      -        -      100M  -

According to the result above, move to VERIFIED.

Comment 9 Laura Bailey 2011-04-20 05:04:28 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
The virt-filesystems command failed when used against a guest without a label. This command has been updated to handle guest file systems without labels.

Note that this bug was reported and corrected during development. It was not seen in production systems in the field.

Comment 10 Richard W.M. Jones 2011-04-20 07:49:53 UTC

    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1,3 +1,3 @@
-The virt-filesystems command failed when used against a guest without a label. This command has been updated to handle guest file systems without labels.
+The virt-filesystems command failed when used on a guest which had a missing or corrupt file system label. This command has been updated to handle guest file systems with missing or corrupt file system labels.
 
 Note that this bug was reported and corrected during development. It was not seen in production systems in the field.

Comment 11 Richard W.M. Jones 2011-04-20 07:50:11 UTC

I updated the technical notes field.

Comment 13 errata-xmlrpc 2011-05-19 11:45:57 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0586.html

Comment 14 errata-xmlrpc 2011-05-19 13:10:49 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0586.html

Note You need to log in before you can comment on or make changes to this bug.