Red Hat Bugzilla – Bug 67191
typo in kernel source file
Last modified: 2007-04-18 12:43:24 EDT
From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.9) Gecko/20020513 Description of problem: There's a typo in source file include/linux/sched.h which causes compilations to break Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: 1.Found it by trying to build openafs 2. 3. Additional info: the following is a diff of the affected file after its being fixed and the emacs ~ file, which is the original one. Bascially #if should be a #ifdef /usr/src/linux-2.4/include/linux [adler@newadler linux]$ diff sched.h sched.h~ 454c454 < #ifdef CONFIG_SMP --- > #if CONFIG_SMP
No #if is actually correct too..... CONFIG_SMP is defined to 1 .... I wonder if openafs has a bust makefile that does -DCONFIG_SMP and not the proper thing.
If you look at other places of the code in the same file, you'll find #ifdef CONFIG_SMP statements. So why does the sched.h file have a mix of #if CONFIG_SMP and #ifdef CONFIG_SMP. You would expect it to be consistant through out. ?????
I didn't say it was nice or consistent... it's just not incorrect sure it's nicer to be consistent :)
what's the correct -D statment then in the cc command line?
there is no correct -D statement for this, because it MUST NOT be passed on the command line, it's a config option that is automatically used correctly via include/config.h, which everything that is relevant already includes.
*** Bug 67268 has been marked as a duplicate of this bug. ***