Spec URL: http://pingou.fedorapeople.org/RPMs/R-Rcompression.spec SRPM URL: http://pingou.fedorapeople.org/RPMs/R-Rcompression-0.92.0-1.fc14.src.rpm Description: The package is a basic interface to some of the compression facilities in the zlib and bzip2 libraries for uncompressing (and compressing) data in memory that is not in a file. It handles bz2, gzip and regular compress (.Z) content. It can work on files or with data in memory, e.g. downloaded directly into memory via an HTTP request. It is used when we don't want to write data to a file and then read it back into R. This is common when performing HTTP requests via the RCurl package and dependent packages such as SSOAP.
R-Rcompression all relevant MUST and SHOULD points are listed here. Must: rplint on src.rpm and binary rpms OK (nothing relevant or in violation to packaging guidelines $ rpmlint -iv R-Rcompression-0.92.0-1.fc14.src.rpm R-Rcompression.src: I: checking R-Rcompression.src: W: spelling-error %description -l en_US zlib -> lib, glib, z lib The value of this tag appears to be misspelled. Please double-check. R-Rcompression.src: W: spelling-error %description -l en_US uncompressing -> uncompressed, compressing, uncomprehending The value of this tag appears to be misspelled. Please double-check. R-Rcompression.src: W: spelling-error %description -l en_US gzip -> zip, grip, g zip The value of this tag appears to be misspelled. Please double-check. R-Rcompression.src: I: checking-url http://www.omegahat.org/Rcompression/index.html (timeout 10 seconds) R-Rcompression.src: I: checking-url http://www.omegahat.org/Rcompression/Rcompression_0.92-0.tar.gz (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 3 warnings. $ rpmlint -iv R-Rcompression-0.92.0-1.fc14.x86_64.rpm R-Rcompression.x86_64: I: checking R-Rcompression.x86_64: W: spelling-error %description -l en_US zlib -> lib, glib, z lib The value of this tag appears to be misspelled. Please double-check. R-Rcompression.x86_64: W: spelling-error %description -l en_US uncompressing -> uncompressed, compressing, uncomprehending The value of this tag appears to be misspelled. Please double-check. R-Rcompression.x86_64: W: spelling-error %description -l en_US gzip -> zip, grip, g zip The value of this tag appears to be misspelled. Please double-check. R-Rcompression.x86_64: I: checking-url http://www.omegahat.org/Rcompression/index.html (timeout 10 seconds) R-Rcompression.x86_64: W: unable-to-read-zip /usr/lib64/R/library/Rcompression/sampleData/tests.zip: File bzTar.R is encrypted, password required for extraction 1 packages and 0 specfiles checked; 0 errors, 4 warnings. MUST: package is named accordingly to general and R specific naming guidelines OK MUST: spec file name matches %{name} OK MUST: package meet packaging guidelines OK MUST: package is licensed under a fedora compliant license (BSD) OK Note: Description says BSD, but they have used zlib licensed code, both licenses are fedora-compliant and almost the same (but not interchangeable) but i feel that upstream should fix this issue in relicensing the whole under zlib license. I have confidence that you'll sort that minor issue later. NOTABLOCKER. No license file included, so no need to provide it. MUST: spec is written in legible american english. OK MUST: provided and upstream sources checksums match. OK provided sources: 8166316349e8e032fcedb9b4813a01286bdee711 upstream sources: 8166316349e8e032fcedb9b4813a01286bdee711 MUST: compilation tested on all supported platforms (x86 and x86_64) for F14 under mock. KO Note: missing BR & R to zip, except that, it compiles fine. MUST: don't bundle third party libraries though it borrowed some zlib code. OK MUST: package owns created directories (and only them). OK MUST: files are not listed twice. OK MUST: files permissions are properly set. OK MUST: consistent use of macros. OK MUST: only ships permissible content. OK MUST: doc is properly handled. OK MUST: filenames are valid UTF-8. OK General and R specific guidelines are more or less respected, as soon as you fix the mock build issue, it will be approved (the minor license issue could be fixed later).
one more thing, use your real name in changelog and not a nickname.
Spec: http://pingou.fedorapeople.org/RPMs/R-Rcompression.spec Srpm: http://pingou.fedorapeople.org/RPMs/R-Rcompression-0.92.0-2.fc13.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2836812 I have contacted upstream to ask his opinion regarding relicensing. I prefer to hear back from him before getting this package approved. I will also contact him about this encrypted zip file.
About the zlib licensed code: Some of the C source code in src/ comes from zlib-derived library minizip (you can check this by grep-ping minizip author's name like this find src/ -exec grep -nH Volland {} \; ). I'm not aware of how R handle C library linking but either it's possible to dynamically link to minizip system library (and it's conflicts with our "don't ship bundled system library" rule), or it's not or use an heavily customized version of minizip and then it's a (partial ?) derivative work. The main issue is that zlib and BSD are both non-copyleft licenses which requires to keep the original notice, mentionning original authors and if original sources were modified. It's feasible but differences between zlib/BSD are not worth shipping two notices, you'd better stick to zlib (the maintainer should not worry about compatibility with other third party-libraries). As i said, the licensing issue by itself is not a blocker for inclusion in Fedora but it should be sorted out.
The licensing isn't a blocker but the bundled library is.
The point is that Rcompression main functionnalities lie in a semi-generated wrapper (as explained in tuNotes.xml) around minizip code. I'm not sure that it's possible to get rid of this code without rewrite the whole stuff.
*** This bug has been marked as a duplicate of bug 753185 ***