Bug 674929 - Review Request: sh-elf-binutils - Cross Compiling GNU binutils targeted at sh-elf
Summary: Review Request: sh-elf-binutils - Cross Compiling GNU binutils targeted at sh...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ralf Corsepius
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 674930
TreeView+ depends on / blocked
 
Reported: 2011-02-03 18:49 UTC by John W. Linville
Modified: 2011-02-15 21:25 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-02-07 15:21:03 UTC
Type: ---
Embargoed:
rc040203: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description John W. Linville 2011-02-03 18:49:15 UTC
Spec URL: http://linville.fedorapeople.org/sh-elf-binutils.spec
SRPM URL: http://linville.fedorapeople.org/sh-elf-binutils-2.21-1.fc14.src.rpm
Description:
This is a Cross Compiling version of GNU binutils, which can be used to
assemble and link binaries for the sh-elf platform, instead of for the
native %{_arch} platform.

Comment 1 John W. Linville 2011-02-03 18:54:30 UTC
The sh-elf cross toolchain is required for building the open-source firmware for the carl9170 wireless driver.

Comment 2 Ralf Corsepius 2011-02-04 08:16:03 UTC
* Wrong license: binutils-2.21 are licensed GPLv3+

* rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*rpm
sh-elf-binutils.x86_64: W: cross-directory-hard-link /usr/bin/sh-elf-ranlib /usr/sh-elf/bin/ranlib
sh-elf-binutils.x86_64: W: cross-directory-hard-link /usr/bin/sh-elf-nm /usr/sh-elf/bin/nm
sh-elf-binutils.x86_64: W: cross-directory-hard-link /usr/sh-elf/bin/ld /usr/bin/sh-elf-ld
sh-elf-binutils.x86_64: W: cross-directory-hard-link /usr/sh-elf/bin/objdump /usr/bin/sh-elf-objdump
sh-elf-binutils.x86_64: W: cross-directory-hard-link /usr/sh-elf/bin/strip /usr/bin/sh-elf-strip
sh-elf-binutils.x86_64: W: cross-directory-hard-link /usr/bin/sh-elf-objcopy /usr/sh-elf/bin/objcopy
sh-elf-binutils.x86_64: W: cross-directory-hard-link /usr/sh-elf/bin/as /usr/bin/sh-elf-as
sh-elf-binutils.x86_64: W: cross-directory-hard-link /usr/sh-elf/bin/ar /usr/bin/sh-elf-ar
sh-elf-binutils.x86_64: W: no-manual-page-for-binary sh-elf-ld.bfd
sh-elf-binutils.x86_64: W: non-standard-dir-in-usr sh-elf

Though the hardlinks may introduce problems in cornercases, 
I am OK with all of these. cross-binutils are a scenario, rpmlint doesn't cope with.

* Sources match upstream:
c84c5acc9d266f1a7044b51c85a823f5  binutils-2.21.tar.bz2


Nothing much else to say about it. All common issues with cross-binutils seem to be addressed.

APPROVED provided you change the license-tag

Comment 3 John W. Linville 2011-02-04 13:10:10 UTC
Will do so -- thanks!

Comment 4 John W. Linville 2011-02-04 13:11:56 UTC
New Package SCM Request
=======================
Package Name: sh-elf-binutils
Short Description: Cross Compiling GNU binutils targeted at sh-elf
Owners: linville
Branches: f14
InitialCC: linville

Comment 5 Kevin Fenzi 2011-02-06 22:56:26 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2011-02-07 15:21:38 UTC
sh-elf-binutils-2.21-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/sh-elf-binutils-2.21-1.fc14

Comment 7 Fedora Update System 2011-02-15 21:25:48 UTC
sh-elf-binutils-2.21-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.