Spec URL: http://hguemar.fedorapeople.org/packages/goocanvasmm2.spec SRPM URL: http://hguemar.fedorapeople.org/packages/goocanvasmm2-1.90.3-1.fc15.src.rpm Description: C++ interface to goocanvas (Gtkmm30 flavoured)
mock build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2852654
spec and src.rpm updated to match recent changes in gtkmm packaging, mostly related to documentation: * we co-own /usr/share/devhelp as allowed by guidelines as it's not required for documentation consultation. mock build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2856883
I really think than docs should be in a subpackage (as for others *mm package) : - include = 0.5Mio, doc = 5Mio - should requires others documentation (for links) which are already split I agree than libsig++20-doc must (co-)own %{_datadir}/devhelp/ (which is not owned by any required package). But others package, which requires libsig++20-doc must not own this "already" owned dir. -doc subpackage should also comes with the COPYING file (as it doesn't requires the main package) http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Subpackage_Licensing *devhelp must also be tagged as %doc if pointed files are tagged as %doc
I agree with your suggestions, i update the spec and src.rpm above consequently. mock build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2859676
i fixed *-doc requirements to gtkmm30-doc (which will pull the other stuff), spec and src.rpm above updated.
=== FORMAL REVIEW === -=N/A x=Check !=Problem, ?=Not evaluated === REQUIRED ITEMS === [!] Rpmlint output: goocanvasmm2.spec:30: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 30) goocanvasmm2.spec: I: checking-url http://ftp.gnome.org/pub/GNOME/sources/goocanvasmm2/1.90/goocanvasmm-1.90.3.tar.bz2 (timeout 10 seconds) goocanvasmm2.spec: W: invalid-url Source0: http://ftp.gnome.org/pub/GNOME/sources/goocanvasmm2/1.90/goocanvasmm-1.90.3.tar.bz2 HTTP Error 404: Not Found goocanvasmm2.src: I: checking goocanvasmm2.src: W: spelling-error %description -l en_US goocanvas -> goo canvas, goo-canvas, canvasser goocanvasmm2.src: W: spelling-error %description -l en_US subpackage -> sub package, sub-package, prepackage goocanvasmm2.src: W: spelling-error %description -l en_US gtkmm goocanvasmm2.src: I: checking-url http://www.gtkmm.org/ (timeout 10 seconds) goocanvasmm2.src:30: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 30) goocanvasmm2.src: I: checking-url http://ftp.gnome.org/pub/GNOME/sources/goocanvasmm2/1.90/goocanvasmm-1.90.3.tar.bz2 (timeout 10 seconds) goocanvasmm2.src: W: invalid-url Source0: http://ftp.gnome.org/pub/GNOME/sources/goocanvasmm2/1.90/goocanvasmm-1.90.3.tar.bz2 HTTP Error 404: Not Found goocanvasmm2.x86_64: I: checking goocanvasmm2.x86_64: W: spelling-error %description -l en_US goocanvas -> goo canvas, goo-canvas, canvasser goocanvasmm2.x86_64: W: spelling-error %description -l en_US subpackage -> sub package, sub-package, prepackage goocanvasmm2.x86_64: W: spelling-error %description -l en_US gtkmm goocanvasmm2.x86_64: I: checking-url http://www.gtkmm.org/ (timeout 10 seconds) goocanvasmm2-debuginfo.x86_64: I: checking goocanvasmm2-debuginfo.x86_64: I: checking-url http://www.gtkmm.org/ (timeout 10 seconds) goocanvasmm2-devel.x86_64: I: checking goocanvasmm2-devel.x86_64: I: checking-url http://www.gtkmm.org/ (timeout 10 seconds) goocanvasmm2-devel.x86_64: W: no-documentation goocanvasmm2-doc.noarch: I: checking goocanvasmm2-doc.noarch: W: spelling-error %description -l en_US goocanvas -> goo canvas, goo-canvas, canvasser goocanvasmm2-doc.noarch: W: spelling-error %description -l en_US goocanvasmm -> canvasback, canvasser, canvass goocanvasmm2-doc.noarch: I: checking-url http://www.gtkmm.org/ (timeout 10 seconds) 5 packages and 1 specfiles checked; 0 errors, 13 warnings. [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: LGPLv2+ [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. md5sum : 188a81fbfcd3ecbc7ed85617e3735a8e goocanvasmm-1.90.3.tar.bz2 [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: rawhide, x86_64 [x] Package is not known to require ExcludeArch [!] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [x] ldconfig called in %post and %postun if required. [x] Packages don't bundle copies of system librarie [x] Package is not relocatable. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [x] Header files in -devel subpackage, if present. [-] Static libraries in -static subpackage, if present. [x] Development .so files in -devel subpackage, if present. [x] Fully versioned dependency in subpackages with %{?_isa}, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI [-] All filenames in rpm packages must be valid UTF-8 [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [!] Final requires --- goocanvasmm2 /sbin/ldconfig <snip> --- goocanvasmm2-devel /usr/bin/pkg-config goocanvas2-devel(x86-64) >= 1.90.2 goocanvasmm2(x86-64) = 1.90.3-1.fc16 gtkmm30-devel(x86-64) >= 2.91.3 libgoocanvasmm-2.0.so.6()(64bit) pkgconfig(glibmm-2.4) >= 2.14.2 pkgconfig(goocanvas-2.0) >= 1.90.2 pkgconfig(gtkmm-3.0) >= 2.91.3 --- goocanvasmm2-doc-1.90.3-1.fc16.noarch.rpm gtkmm30-doc [x] Final provides --- goocanvasmm2 libgoocanvasmm-2.0.so.6()(64bit) goocanvasmm2 = 1.90.3-1.fc16 goocanvasmm2(x86-64) = 1.90.3-1.fc16 --- goocanvasmm2-devel pkgconfig(goocanvasmm-2.0) = 1.90.3 goocanvasmm2-devel = 1.90.3-1.fc16 goocanvasmm2-devel(x86-64) = 1.90.3-1.fc16 --- goocanvasmm2-doc goocanvasmm2-doc = 1.90.3-1.fc16 [x] Latest version is packaged. [-] If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [-] The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: Koji http://koji.fedoraproject.org/koji/taskinfo?taskID=2859885 [-] The package should compile and build into binary rpms on all supported architectures. Tested on: i686 and x86_64 (koji) [-] Package functions as described. [x] If scriptlets are used, those scriptlets must be sane. [-] If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. [-] your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense. [x] The placement of pkgconfig(.pc) files is correct. [-] %check is present and the tests pass From build.log doc-install: Using base path ../../../libsigc++-2.0/reference/html/ for tag file libsigc++-2.0.tag doc-install: Using base path ../../../glibmm-2.4/reference/html/ for tag file glibmm-2.4.tag doc-install: Using base path ../../../cairomm-1.0/reference/html/ for tag file cairomm-1.0.tag doc-install: Using base path ../../../pangomm-1.4/reference/html/ for tag file pangomm-1.4.tag MUST - fix URL - add Requires for cairomm-doc and pangomm-doc (doc sub-package) SHOULD - fix mixed-use-of-spaces-and-tabs - fix typo : sub-package - move "BuildRequires: doxygen graphviz" to "doc" sub-package
* source URL fixed * cairomm-doc and pangomm-doc should be pulled by gtkmm30-doc (it will be fixed by the upcoming gtkmm mega-update) * mixed-use-of-spaces-and-tabs ==> fixed * typo fixed * BR doxygen and graphviz have been reparented to doc sub-package. spec and src.rpm have been updated accordingly
(In reply to comment #7) > * cairomm-doc and pangomm-doc should be pulled by gtkmm30-doc (it will be fixed > by the upcoming gtkmm mega-update) Ok, sounds good. All MUST/SHOULD fixed. ******** APPROVED ********
There is no SCM request to process.
Sorry for that. New Package SCM Request ======================= Package Name: goocanvasmm2 Short Description: goocanvas2 C++ bindings Owners: hguemar Branches: f15 InitialCC: hguemar
Git done (by process-git-requests).