Bug 678929 - Review Request: perl-Crypt-Random-Source - Get weak or strong random data from pluggable sources
Summary: Review Request: perl-Crypt-Random-Source - Get weak or strong random data fro...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Iain Arnell
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 678931
TreeView+ depends on / blocked
 
Reported: 2011-02-20 22:02 UTC by Emmanuel Seyman
Modified: 2011-03-10 22:30 UTC (History)
4 users (show)

Fixed In Version: perl-Crypt-Random-Source-0.07-1.fc15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-03-05 02:34:19 UTC
Type: ---
Embargoed:
iarnell: fedora-review+


Attachments (Terms of Use)

Description Emmanuel Seyman 2011-02-20 22:02:59 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Crypt-Random-Source/perl-Crypt-Random-Source.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Crypt-Random-Source/perl-Crypt-Random-Source-0.07-1.fc14.src.rpm
Description:
This module provides implementations for a number of byte oriented sources
of random data.

Comment 1 Sergio Belkin 2011-02-21 14:27:34 UTC
Some comments: 

(Note that I am (still) not member of packaging group)

I see no errors buiding this package, and is compliant with Packaging Perl Guideline

-License:

Terms of the Perl programming language system itself

a) the GNU General Public License as published by the Free
   Software Foundation; either version 1, or (at your option) any
   later version, or
b) the "Artistic License"

- Dir ownership for noarch packages ok
- Dependencies ok as http://deps.cpantesters.org/?module=Crypt::Random::Source;perl=latest and http://fedoraproject.org/wiki/Packaging:Perl#Perl_Requires_and_Provides states.

c) Filtering Requires and Provides 
%{?perl_default_filter}

ok!

d) URL tag ok

e) test suite present:

%check
make test

In short I see no errors and rpmlint only it outputs a harmless warning:

rpmlint -i -v perl-Crypt-Random-Source*
perl-Crypt-Random-Source.noarch: I: checking
perl-Crypt-Random-Source.noarch: W: spelling-error Summary(en_US) pluggable -> plug gable, plug-gable, plugged
The value of this tag appears to be misspelled. Please double-check.

perl-Crypt-Random-Source.noarch: I: checking-url http://search.cpan.org/dist/Crypt-Random-Source/ (timeout 10 seconds)
perl-Crypt-Random-Source.src: I: checking
perl-Crypt-Random-Source.src: W: spelling-error Summary(en_US) pluggable -> plug gable, plug-gable, plugged
The value of this tag appears to be misspelled. Please double-check.

perl-Crypt-Random-Source.src: I: checking-url http://search.cpan.org/dist/Crypt-Random-Source/ (timeout 10 seconds)
perl-Crypt-Random-Source.src: I: checking-url http://www.cpan.org/authors/id/N/NU/NUFFIN/Crypt-Random-Source-0.07.tar.gz (timeout 10 seconds)
perl-Crypt-Random-Source.spec: I: checking-url http://www.cpan.org/authors/id/N/NU/NUFFIN/Crypt-Random-Source-0.07.tar.gz (timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 2 warnings.


Hope that helps

Comment 2 Iain Arnell 2011-02-24 04:35:18 UTC
+ source files match upstream.  
    56251a6c909e21f5ae535b0e2af3897e  Crypt-Random-Source-0.07.tar.gz

+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ license field matches the actual license.
    GPL+ or Artistic

+ license is open source-compatible.
+ license text included.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2862731

+ package installs properly.
+ rpmlint has no complaints:
    perl-Crypt-Random-Source.noarch: W: spelling-error Summary(en_US) pluggable -> plug gable, plug-gable, plugged
    perl-Crypt-Random-Source.src: W: spelling-error Summary(en_US) pluggable -> plug gable, plug-gable, plugged
    2 packages and 0 specfiles checked; 0 errors, 2 warnings.

+ final provides and requires are sane:
    perl(Crypt::Random::Source) = 0.07
    perl(Crypt::Random::Source::Base) = 0.07
    perl(Crypt::Random::Source::Base::File) = 0.07
    perl(Crypt::Random::Source::Base::Handle) = 0.07
    perl(Crypt::Random::Source::Base::Proc) = 0.07
    perl(Crypt::Random::Source::Base::RandomDevice) = 0.07
    perl(Crypt::Random::Source::Factory) = 0.07
    perl(Crypt::Random::Source::Strong) = 0.07
    perl(Crypt::Random::Source::Strong::devrandom) = 0.07
    perl(Crypt::Random::Source::Weak) = 0.07
    perl(Crypt::Random::Source::Weak::devurandom) = 0.07
    perl(Crypt::Random::Source::Weak::rand) = 0.07
    perl-Crypt-Random-Source = 0.07-1.fc16
=
    perl >= 0:5.008
    perl(Any::Moose)  
    perl(bytes)  
    perl(Capture::Tiny)  
    perl(Carp)  
    perl(Crypt::Random::Source::Factory)  
    perl(Errno)  
    perl(File::Spec)  
    perl(IO::File)  
    perl(IO::Handle)  
    perl(:MODULE_COMPAT_5.12.3)  
    perl(Module::Find)  
    perl(namespace::clean)  
    perl(strict)  
    perl(Sub::Exporter)  
    perl(warnings)  

+ %check is present and all tests pass.
    PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
    t/blocking.t ............ ok
    t/dev_random.t .......... ok
    t/factory.t ............. ok
    t/proc.t ................ ok
    t/rand.t ................ ok
    t/release-eol.t ......... skipped: these tests are for release candidate testing
    t/release-pod-syntax.t .. skipped: these tests are for release candidate testing
    t/reread.t .............. ok
    t/sugar.t ............... ok
    All tests successful.
    Files=9, Tests=53,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.42 cusr  0.06 csys =  0.52 CPU)
    Result: PASS

+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.


APPROVED.

Comment 3 Emmanuel Seyman 2011-02-25 09:42:12 UTC
Thanks for the review, Ian.

New Package SCM Request
=======================
Package Name: perl-Crypt-Random-Source
Short Description: Get weak or strong random data from pluggable sources
Owners: eseyman
Branches: f14 f15
InitialCC: perl-sig

Comment 4 Jason Tibbitts 2011-02-25 14:34:04 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2011-02-27 13:36:36 UTC
Package perl-Crypt-Random-Source-0.07-1.fc15:
* should fix your issue,
* was pushed to the Fedora 15 updates-testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing perl-Crypt-Random-Source-0.07-1.fc15'
as soon as you are able to, then reboot.
Please go to the following url:
https://admin.fedoraproject.org/updates/perl-Crypt-Random-Source-0.07-1.fc15
then log in and leave karma (feedback).

Comment 6 Fedora Update System 2011-03-01 06:46:12 UTC
perl-Crypt-Random-Source-0.07-1.fc15 has been pushed to the Fedora 15 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-Crypt-Random-Source'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/perl-Crypt-Random-Source-0.07-1.fc15

Comment 7 Fedora Update System 2011-03-05 02:34:10 UTC
perl-Crypt-Random-Source-0.07-1.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Emmanuel Seyman 2011-03-10 22:26:12 UTC
Package Change Request
======================
Package Name: perl-Crypt-Random-Source
New Branches: f14
Owners: eseyman
InitialCC: perl-sig

Comment 9 Jason Tibbitts 2011-03-10 22:30:23 UTC
This package already has an f14 branch.


Note You need to log in before you can comment on or make changes to this bug.