Bug 678931 - Review Request: perl-Math-Random-Secure - Cryptographically-secure, cross-platform replacement for rand()
Summary: Review Request: perl-Math-Random-Secure - Cryptographically-secure, cross-pla...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Iain Arnell
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 678925 678929
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-02-20 22:17 UTC by Emmanuel Seyman
Modified: 2011-03-10 22:30 UTC (History)
3 users (show)

Fixed In Version: perl-Math-Random-Secure-0.06-2.fc15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-03-10 03:14:38 UTC
Type: ---
Embargoed:
iarnell: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Emmanuel Seyman 2011-02-20 22:17:13 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Math-Random-Secure/perl-Math-Random-Secure.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Math-Random-Secure/perl-Math-Random-Secure-0.06-1.fc14.src.rpm
Description:
This module is intended to provide a cryptographically-secure replacement
for Perl's built-in rand function.

Comment 1 Iain Arnell 2011-02-27 09:52:59 UTC
Fails to build in mock due to missing perl(Test::More).

Comment 2 Emmanuel Seyman 2011-03-02 17:01:19 UTC
(In reply to comment #1)
>
> Fails to build in mock due to missing perl(Test::More).

amongst other things. Fixed.

Spec URL:
http://people.parinux.org/~seyman/fedora/perl-Math-Random-Secure/perl-Math-Random-Secure.spec
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-Math-Random-Secure/perl-Math-Random-Secure-0.06-2.fc14.src.rpm

Comment 3 Iain Arnell 2011-03-04 04:46:28 UTC
+ source files match upstream.  
    7397735ec33ef8fc69303b0a7d741b51  Math-Random-Secure-0.06.tar.gz

+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ license field matches the actual license.
    Artistic 2.0

+ license is open source-compatible.
+ license text included.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ package builds in mock
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2883478

+ package installs properly.
+ rpmlint has no complaints:
    2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ final provides and requires are sane:
    perl(Math::Random::Secure) = 0.06
    perl-Math-Random-Secure = 0.06-2.fc16
    perl(Math::Random::Secure::RNG) = 0.06
=
    perl >= 0:5.008
    perl(Any::Moose)  
    perl(base)  
    perl(constant)  
    perl(Crypt::Random::Source::Factory)  
    perl(Exporter)  
    perl(if)  
    perl(Math::Random::ISAAC)  
    perl(Math::Random::Secure::RNG)  
    perl(:MODULE_COMPAT_5.12.3)  
    perl(strict)  

+ %check is present and all tests pass.
    All tests successful.
    Files=7, Tests=29,  1 wallclock secs ( 0.02 usr  0.01 sys +  0.87 cusr  0.06 csys =  0.96 CPU)
    Result: PASS

+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.

APPROVED. You can remove META.json from %doc.

Comment 4 Emmanuel Seyman 2011-03-04 09:57:22 UTC
(In reply to comment #3)
> 
> APPROVED. You can remove META.json from %doc.

Done. Thanks, Ian.

New Package SCM Request
=======================
Package Name: perl-Math-Random-Secure
Short Description: Cryptographically-secure, cross-platform replacement for rand()
Owners: eseyman
Branches: f15
InitialCC: perl-sig

Comment 5 Jason Tibbitts 2011-03-04 13:12:58 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2011-03-06 09:21:54 UTC
perl-Math-Random-Secure-0.06-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/perl-Math-Random-Secure-0.06-2.fc15

Comment 7 Fedora Update System 2011-03-10 03:14:33 UTC
perl-Math-Random-Secure-0.06-2.fc15 has been pushed to the Fedora 15 stable repository.

Comment 8 Emmanuel Seyman 2011-03-10 22:24:28 UTC
Upstream has requested a F14 branch.

Package Change Request
======================
Package Name: perl-Math-Random-Secure
New Branches: f14
Owners: eseyman
InitialCC: perl-sig

Comment 9 Jason Tibbitts 2011-03-10 22:30:46 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.