Spec URL: http://rezza.hofyland.cz/fedora/packages/qtsoap/qtsoap.spec SRPM URL: http://rezza.hofyland.cz/fedora/packages/qtsoap/qtsoap-1.7-1.fc14.src.rpm Description: The SOAP (Simple Object Access Protocol) library uses the XML standard for describing how to exchange messages. Its primary usage is to invoke web services and get responses from Qt-based applications.
rpmlint qtsoap.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint ../RPMS/x86_64/qtsoap-* 3 packages and 0 specfiles checked; 0 errors, 0 warnings. This package is needed for herqq (hupnp) which currently bundles own copy of qtsoap (it's intention of qtsoap developers). The final dependency is kio-upnp-ms (to be packaged). Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2857314
spec URL: http://rezza.hofyland.cz/fedora/packages/qtsoap/qtsoap.spec SRPM URL: http://rezza.hofyland.cz/fedora/packages/qtsoap/qtsoap-2.7-1.fc14.src.rpm Fixed version.
Not a review, but a brief comment: the library should be installed as 'libqtsoap', not 'libQtSolutions_SOAP', for consistency with the package name. Or vice-versa, calling the package 'qtsolutions-soap'.
I can review this.
licensing: OK scriptlets: OK naming: OK URL provided doesn't work for me, please find something better. Not a blocker. rpmlint: clean, OK builds/installs OK In a perfect world, I'd like to see comment #3 addressed too, wrt keeping library naming more consistent, using something from trever's .spec he showed us earlier today: %build echo 'yes' | \ ./configure -library echo "QTSOAP_LIBNAME = \$\$qtLibraryTarget(qtsoap)" >> common.pri echo "VERSION=%{version}" >> common.pri qmake-qt4 make %{?_smp_mflags} But, I'll leave it up to you on how best to resolve that (with some potential upstream poking). not a blocker. Otherwise, looks good, APPROVED
(In reply to comment #5) > licensing: OK > > scriptlets: OK > > naming: OK > > URL provided doesn't work for me, please find something better. Not a blocker. > > rpmlint: clean, OK > > builds/installs OK > > In a perfect world, I'd like to see comment #3 addressed too, wrt keeping > library naming more consistent, using something from trever's .spec he showed > us earlier today: > %build > echo 'yes' | \ > ./configure -library > > echo "QTSOAP_LIBNAME = \$\$qtLibraryTarget(qtsoap)" >> common.pri > echo "VERSION=%{version}" >> common.pri > > qmake-qt4 > > make %{?_smp_mflags} > > > But, I'll leave it up to you on how best to resolve that (with some potential > upstream poking). not a blocker. > > > > Otherwise, looks good, APPROVED There's no upstream anymore but I'll try to incorporate this change into my fedora qt-soap branch. Thanks for review, good spot guys.
ping?
(In reply to comment #7) > ping? Rex, I'd like to implement suggested enhancements but I was busy... So probably I should just import it in the current state...
New Package SCM Request ======================= Package Name: qtsoap Short Description: The Simple Object Access Protocol Qt-based client side library Owners: jreznik rdieter kkofler than Branches: f14 f15 InitialCC:
Git done (by process-git-requests).
Trever, could you share your SPEC file with me (the one Rex is talking about)?
imported & built for rawhide
Package Change Request ====================== Package Name: qtsoap New Branches: el6 Owners: jreznik Requested by an user.
Package Change Request ====================== Package Name: qtsoap New Branches: el7 Owners: jreznik brouhaha