Bug 680174 - Review Request: herqq - A software library for building UPnP devices and control points
Summary: Review Request: herqq - A software library for building UPnP devices and cont...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: qtsoap
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-02-24 14:42 UTC by Jaroslav Reznik
Modified: 2011-08-17 00:53 UTC (History)
4 users (show)

Fixed In Version: herqq-1.0.0-1.fc15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-08-17 00:53:50 UTC
Type: ---
Embargoed:
rdieter: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Jaroslav Reznik 2011-02-24 14:42:06 UTC
Spec URL: http://rezza.hofyland.cz/fedora/packages/herqq/herqq.spec
SRPM URL: http://rezza.hofyland.cz/fedora/packages/herqq/herqq-0.9.1-1.fc14.src.rpm
Description: 
Herqq UPnP (HUPnP) is a software library for building UPnP 
devices and control points conforming to the UPnP Device 
Architecture version 1.1.

Comment 1 Jaroslav Reznik 2011-02-24 14:50:44 UTC
rpmlint ../RPMS/x86_64/herqq-*
herqq.x86_64: W: file-not-utf8 /usr/share/doc/herqq-0.9.1/ChangeLog
herqq.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/herqq-0.9.1/LICENSE_LGPLv3.txt
herqq-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/herqq-devel-0.9.1/LICENSE_LGPLv3.txt
3 packages and 0 specfiles checked; 0 errors, 3 warnings.

I'll contact upstream to fix this.

[jreznik@dhcp-31-154 SPECS]$ rpmlint ../SRPMS/herqq-0.9.1-1.fc14.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[jreznik@dhcp-31-154 SPECS]$ rpmlint herqq.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

What I'm not completely sure it package name - it's referred as herqq upnp or hupnp. Distributed in herqq.zip with hupnp as a subproject library only with another test application (not installed). HUPnP is mentioned in description.

Comment 2 Rex Dieter 2011-07-06 15:22:51 UTC
I can help review this.

Comment 3 Jaroslav Reznik 2011-07-19 13:09:57 UTC
Spec URL: http://rezza.hofyland.cz/fedora/packages/herqq/herqq.spec
SRPM URL:
http://rezza.hofyland.cz/fedora/packages/herqq/herqq-0.9.1-2.fc14.src.rpm

* Tue Jul 19 2011 Jaroslav Reznik <jreznik> - 0.9.1-2
- qtsoap library
- cleanup SPEC file

For naming issues - some distros ships herqq package, some hupnp, so I will stick with herqq here.

Comment 4 Rex Dieter 2011-07-19 14:08:31 UTC
$ rpmlint *.src.rpm x86_64/*.rpm
herqq.x86_64: W: file-not-utf8 /usr/share/doc/herqq-0.9.1/ChangeLog
herqq.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/herqq-0.9.1/LICENSE_LGPLv3.txt
herqq-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/herqq-devel-0.9.1/LICENSE_LGPLv3.txt
4 packages and 0 specfiles checked; 0 errors, 3 warnings.

mostly harmless


naming: ok

sources: ok
cb0d080da22b649a5916796bbf4d2c28  herqq-0.9.1.zip

scriptlets: ok

license: ok  , but seems all the source code does seem to include the "or (at your option) any later version." option (unless I missed something).

macros: OK, but..

SHOULD: for consistency, I'd recommend using %{_qt4_headerdir} in favor of %{_includedir}

SHOULD: track shlib soname in %files, so not caught by surprise on abi changes using something like this:
%{_qt4_libdir}/libHUpnp.so.0*


APPROVED.

Comment 5 Rex Dieter 2011-07-19 14:09:56 UTC
oh, and

SHOULD: no need to include 
%doc hupnp/LICENSE_LGPLv3.txt
in both main and -devel subpkg (main is enough, imo).

Comment 6 Jaroslav Reznik 2011-07-20 12:45:39 UTC
Thanks Rex, fixed.

Spec URL: http://rezza.hofyland.cz/fedora/packages/herqq/herqq.spec
SRPM URL:
http://rezza.hofyland.cz/fedora/packages/herqq/herqq-0.9.1-3.fc14.src.rpm

* Wed Jul 20 2011 Jaroslav Reznik <jreznik> - 0.9.1-3
- fix license to LGPLv3+
- qt4 header dir for consistency
- shlib soname tracked in %files
- -devel should not duplicate COPYING

Comment 7 Jaroslav Reznik 2011-07-20 12:47:32 UTC
New Package SCM Request
=======================
Package Name: herqq
Short Description: A software library for building UPnP devices and control points
Owners: jreznik
Branches: f14 f15
InitialCC:

Comment 8 Gwyn Ciesla 2011-07-20 13:30:08 UTC
Git done (by process-git-requests).

Comment 9 Fedora Update System 2011-08-06 15:08:30 UTC
herqq-1.0.0-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/herqq-1.0.0-1.fc15

Comment 10 Fedora Update System 2011-08-09 01:30:32 UTC
herqq-1.0.0-1.fc15 has been pushed to the Fedora 15 testing repository.

Comment 11 Fedora Update System 2011-08-17 00:53:44 UTC
herqq-1.0.0-1.fc15 has been pushed to the Fedora 15 stable repository.


Note You need to log in before you can comment on or make changes to this bug.