Spec URL: http://rezza.hofyland.cz/fedora/packages/herqq/herqq.spec SRPM URL: http://rezza.hofyland.cz/fedora/packages/herqq/herqq-0.9.1-1.fc14.src.rpm Description: Herqq UPnP (HUPnP) is a software library for building UPnP devices and control points conforming to the UPnP Device Architecture version 1.1.
rpmlint ../RPMS/x86_64/herqq-* herqq.x86_64: W: file-not-utf8 /usr/share/doc/herqq-0.9.1/ChangeLog herqq.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/herqq-0.9.1/LICENSE_LGPLv3.txt herqq-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/herqq-devel-0.9.1/LICENSE_LGPLv3.txt 3 packages and 0 specfiles checked; 0 errors, 3 warnings. I'll contact upstream to fix this. [jreznik@dhcp-31-154 SPECS]$ rpmlint ../SRPMS/herqq-0.9.1-1.fc14.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [jreznik@dhcp-31-154 SPECS]$ rpmlint herqq.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. What I'm not completely sure it package name - it's referred as herqq upnp or hupnp. Distributed in herqq.zip with hupnp as a subproject library only with another test application (not installed). HUPnP is mentioned in description.
I can help review this.
Spec URL: http://rezza.hofyland.cz/fedora/packages/herqq/herqq.spec SRPM URL: http://rezza.hofyland.cz/fedora/packages/herqq/herqq-0.9.1-2.fc14.src.rpm * Tue Jul 19 2011 Jaroslav Reznik <jreznik> - 0.9.1-2 - qtsoap library - cleanup SPEC file For naming issues - some distros ships herqq package, some hupnp, so I will stick with herqq here.
$ rpmlint *.src.rpm x86_64/*.rpm herqq.x86_64: W: file-not-utf8 /usr/share/doc/herqq-0.9.1/ChangeLog herqq.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/herqq-0.9.1/LICENSE_LGPLv3.txt herqq-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/herqq-devel-0.9.1/LICENSE_LGPLv3.txt 4 packages and 0 specfiles checked; 0 errors, 3 warnings. mostly harmless naming: ok sources: ok cb0d080da22b649a5916796bbf4d2c28 herqq-0.9.1.zip scriptlets: ok license: ok , but seems all the source code does seem to include the "or (at your option) any later version." option (unless I missed something). macros: OK, but.. SHOULD: for consistency, I'd recommend using %{_qt4_headerdir} in favor of %{_includedir} SHOULD: track shlib soname in %files, so not caught by surprise on abi changes using something like this: %{_qt4_libdir}/libHUpnp.so.0* APPROVED.
oh, and SHOULD: no need to include %doc hupnp/LICENSE_LGPLv3.txt in both main and -devel subpkg (main is enough, imo).
Thanks Rex, fixed. Spec URL: http://rezza.hofyland.cz/fedora/packages/herqq/herqq.spec SRPM URL: http://rezza.hofyland.cz/fedora/packages/herqq/herqq-0.9.1-3.fc14.src.rpm * Wed Jul 20 2011 Jaroslav Reznik <jreznik> - 0.9.1-3 - fix license to LGPLv3+ - qt4 header dir for consistency - shlib soname tracked in %files - -devel should not duplicate COPYING
New Package SCM Request ======================= Package Name: herqq Short Description: A software library for building UPnP devices and control points Owners: jreznik Branches: f14 f15 InitialCC:
Git done (by process-git-requests).
herqq-1.0.0-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/herqq-1.0.0-1.fc15
herqq-1.0.0-1.fc15 has been pushed to the Fedora 15 testing repository.
herqq-1.0.0-1.fc15 has been pushed to the Fedora 15 stable repository.