Hide Forgot
Spec URL: http://fedorapeople.org/~nkumar/ibus-indic-table/ibus-indic-table-1.3.0.20110301/ibus-indic-table.spec SRPM URL: http://fedorapeople.org/~nkumar/ibus-indic-table/ibus-indic-table-1.3.0.20110301/ibus-indic-table-1.3.0.20110301-1.fc14.src.rpm Description: The Indic Table engine for IBus platform. Please review this package.
Updated Spec URL: http://fedorapeople.org/~nkumar/ibus-indic-table/ibus-indic-table-1.3.0/ibus-indic-table.spec Updated SRPM URL: http://fedorapeople.org/~nkumar/ibus-indic-table/ibus-indic-table-1.3.0/ibus-indic-table-1.3.0-2.fc14.src.rpm
I see that you have a new tarball updated with no date suffix. koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=2890131 Please add some detailed changelog to understand what got changed from older submission to this new srpm. Re-upload the same srpm with added changelog.
updated the same spec and SRPM koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2893142
Suggestions: 1) split changelog lines to 80 character per line 2) versions are not needed in Requires: and BuildRequires: 3) Include ChangeLog file as %doc but looks like ChangeLog file carries contents from ibus-table ChangeLog file. 4) Good if upstream will add information related to ibus-indic-table project in %doc files and just mention in README that this project is a fork from ibus-table project. 5) I think you don't need file pinyin_table.txt.bz2 installed. 6) I also see template.txt should be modified to have unique uuid. Overall, it will be good if you will release a new tarball and package it as an update.
Updated Spec URL: http://fedorapeople.org/~nkumar/ibus-indic-table/ibus-indic-table-1.3.1/ibus-indic-table.spec Updated SRPM URL: http://fedorapeople.org/~nkumar/ibus-indic-table/ibus-indic-table-1.3.1/ibus-indic-table-1.3.1-1.fc14.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2893770
Suggestions: 1) --disable-static is not needed to %configure 2) preserve the timestamps of installed files. make DESTDIR=${RPM_BUILD_ROOT} NO_INDEX=true \ install pkgconfigdir=%{_datadir}/pkgconfig \ INSTALL="install -p" APPROVED.
after install package i found 1) /usr/share/ibus-indic-table/indic-tables as well 2) /usr/share/ibus-indic-table/tables i think we only need second
(In reply to comment #6) > Suggestions: > 1) --disable-static is not needed to %configure > 2) preserve the timestamps of installed files. > make DESTDIR=${RPM_BUILD_ROOT} NO_INDEX=true \ > install pkgconfigdir=%{_datadir}/pkgconfig \ > INSTALL="install -p" > > APPROVED. Thanks Parag :)
New Package SCM Request ======================= Package Name: ibus-indic-table Short Description: Indic Table engine for IBus platform Owners: nkumar Branches: f14 f15 InitialCC: i18n-team
Git done (by process-git-requests).
Thanks Jason :)