Bug 682380 - assumes all ethernet devices are named ethX
Summary: assumes all ethernet devices are named ethX
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: tuned
Version: 6.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Jan Vcelak
QA Contact: qe-baseos-daemons
URL:
Whiteboard:
Depends On: 682379
Blocks: 682269
TreeView+ depends on / blocked
 
Reported: 2011-03-05 01:51 UTC by Bill Nottingham
Modified: 2014-03-17 03:26 UTC (History)
7 users (show)

Fixed In Version: tuned-0.2.19-3.el6
Doc Type: Bug Fix
Doc Text:
Clone Of: 682379
Environment:
Last Closed: 2011-05-19 13:14:07 UTC
Target Upstream Version:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2011:0581 0 normal SHIPPED_LIVE tuned bug fix and enhancement update 2011-05-18 17:56:52 UTC

Description Bill Nottingham 2011-03-05 01:51:58 UTC
+++ This bug was initially created as a clone of Bug #682379 +++

Description of problem:

Network devices can have arbitrary names, and due to
http://fedoraproject.org/wiki/Features/ConsistentNetworkDeviceNaming, will have
different names in Fedora 15.

tuned-0.2.19/monitorplugins/net.py:
...
                devs = open("/proc/net/dev").readlines()
                for l in devs:
                        l = l.replace(":", " ")
                        v = l.split()
                        d = v[0]
                        if not d.startswith("eth"):
                                continue
...

Version-Release number of selected component (if applicable):

tuned-0.2.19

How reproducible:

By visual inspection.

Comment 3 Jan Vcelak 2011-03-08 16:47:38 UTC
Resolved in git (upstream):
http://git.fedorahosted.org/git/?p=tuned.git;a=commit;h=ae41fe8

Comment 4 Bill Nottingham 2011-03-08 17:07:32 UTC
This just moves the problem somewhat... the admin can still name their devices 'inbound' and 'outbound', or 'Gb0', 'Gb1', 'Gb2'.

Comment 5 Jan Vcelak 2011-03-08 17:17:53 UTC
This was always possible. I don't know how this is related to the new Fedora feature. But OK. We can do it more sophisticated.

Comment 6 Jan Vcelak 2011-03-08 18:12:12 UTC
I hope this is universal enough:

http://git.fedorahosted.org/git/?p=tuned.git;a=commit;h=fd2656d

net: universal ethernet card identifier detection

- get all network devices from /sys/class/net
- exclude all virtual devices
 (symlinks point to /sys/devices/virtual/*)
- exclude all untunable devices
  (ethtool reports no modes, maximal speed is lower than 1000Mbit)

Comment 7 Bill Nottingham 2011-03-08 19:26:00 UTC
Algorithm sounds good.

Comment 11 errata-xmlrpc 2011-05-19 13:14:07 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0581.html


Note You need to log in before you can comment on or make changes to this bug.