Bug 684475 - Review Request: wmblob - Dockapp which shows funny moving `blobs'
Summary: Review Request: wmblob - Dockapp which shows funny moving `blobs'
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Iain Arnell
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-03-12 21:52 UTC by Mario Blättermann
Modified: 2011-05-25 02:29 UTC (History)
5 users (show)

Fixed In Version: wmblob-1.0.3-3.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-05-19 04:59:15 UTC
Type: ---
Embargoed:
iarnell: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Mario Blättermann 2011-03-12 21:52:31 UTC
Spec URL: http://dl.dropbox.com/u/19373040/Fedora/SPECS/wmblob.spec
SRPM URL: http://dl.dropbox.com/u/19373040/Fedora/wmblob-1.0.3-1.fc14.src.rpm
Description: Wmblob is a totally useless program. But unlike other totally useless programs 
(I won't name them here, because they're made by an enormous and rich 
company), it looks good and shows funny moving `blobs'.
(description is originally taken from the source package)

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2907242

Comment 1 Sergio Belkin 2011-03-13 03:13:37 UTC
Hi  Mario,

The are some issue with this packages:

- Character encoding:

rpmlint -i -v /var/lib/mock/fedora-rawhide-i386/root/builddir/build/RPMS/wmblob-1.0.3-1.fc16.i686.rpm
wmblob.i686: I: checking
wmblob.i686: W: spelling-error Summary(en_US) Dockapp -> Dock app, Dock-app, Dockage
The value of this tag appears to be misspelled. Please double-check.

wmblob.i686: I: enchant-dictionary-not-found de
A dictionary for the Enchant spell checking library is not available for the
language given in the info message.  Spell checking will proceed with
rpmlint's built-in implementation for localized tags in this language. For
better spell checking results in this language, install the appropriate
dictionary that Enchant will use for this language, often for example
hunspell-* or aspell-*.

wmblob.i686: W: spelling-error %description -l de programm -> program
The value of this tag appears to be misspelled. Please double-check.

wmblob.i686: I: checking-url http://dockapps.org/file.php/id/155 (timeout 10 seconds)
wmblob.i686: W: file-not-utf8 /usr/share/man/man1/wmblob.1.gz
The character encoding of this file is not UTF-8.  Consider converting it in
the specfile's %prep section for example using iconv(1).

wmblob.i686: W: file-not-utf8 /usr/share/doc/wmblob-1.0.3/ChangeLog
The character encoding of this file is not UTF-8.  Consider converting it in
the specfile's %prep section for example using iconv(1).

wmblob.i686: W: file-not-utf8 /usr/share/doc/wmblob-1.0.3/README
The character encoding of this file is not UTF-8.  Consider converting it in
the specfile's %prep section for example using iconv(1).

1 packages and 0 specfiles checked; 0 errors, 5 warnings.

- File mode bits of tarbel chmod it to 0644 :

rpmlint -i -v wmblob-1.0.3-1.fc14.src.rpm
wmblob.src: I: checking
wmblob.src: W: spelling-error Summary(en_US) Dockapp -> Dock app, Dock-app, Dockage
The value of this tag appears to be misspelled. Please double-check.

wmblob.src: I: enchant-dictionary-not-found de
A dictionary for the Enchant spell checking library is not available for the
language given in the info message.  Spell checking will proceed with
rpmlint's built-in implementation for localized tags in this language. For
better spell checking results in this language, install the appropriate
dictionary that Enchant will use for this language, often for example
hunspell-* or aspell-*.

wmblob.src: W: spelling-error %description -l de programm -> program
The value of this tag appears to be misspelled. Please double-check.

wmblob.src: I: checking-url http://dockapps.org/file.php/id/155 (timeout 10 seconds)
wmblob.src: W: strange-permission wmblob-1.0.3.tar.bz2 0755L
A file that you listed to include in your package has strange permissions.
Usually, a file should have 0644 permissions.

wmblob.src: I: checking-url http://www.dockapps.org/download.php/id/541/wmblob-1.0.3.tar.bz2 (timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

HTH

Comment 2 Mario Blättermann 2011-03-13 11:59:37 UTC
Spec URL: http://dl.dropbox.com/u/19373040/Fedora/SPECS/wmblob.spec
SRPM URL: http://dl.dropbox.com/u/19373040/Fedora/wmblob-1.0.3-2.fc14.src.rpm

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2908300

I've changed the file encoding and tarball permissions as recommended. The enchant outputs from rpmlint are due to a missing German dictionary on your system.

Comment 3 Martin Gieseking 2011-03-13 12:57:47 UTC
Some further notes on the latest spec:

- please use a more neutral and less biased %description, e.g. the one from 
  dockapps.org:
  "wmblob shows some blobs moving around. It does nothing useful, it's just 
  a toy."

- replace the iconv lines with the following loop to ensure a correct conversion
  and to preserve the timestamps:

  for f in ChangeLog README doc/wmblob.1 doc/how_it_works; do
    iconv -f iso-8859-1 -t utf8 $f >$f.tmp && \
    touch -r $f $f.tmp && \
    mv $f.tmp $f
  done

- replace the make statement with this one to apply the %optflags during the 
  build:
  make CFLAGS="%{optflags} `pkg-config --cflags gtk+-2.0`" %{?_smp_mflags}
  
  configure.ac looks pretty messy and could need some maintenance. ;)

Comment 4 Mario Blättermann 2011-03-13 18:32:15 UTC
Spec URL: http://dl.dropbox.com/u/19373040/Fedora/SPECS/wmblob.spec
SRPM URL: http://dl.dropbox.com/u/19373040/Fedora/wmblob-1.0.3-3.fc14.src.rpm

Thanks for your hints.


(In reply to comment #3)
>   configure.ac looks pretty messy and could need some maintenance. ;)

Yes, of course, but upstream is dead. It works as it works. In my mind, it's senseless to patch configure.ac without any chance to get it ever fixed in the sources.

Comment 5 Iain Arnell 2011-05-08 06:06:01 UTC
+ source files match upstream.  
    5821d20d4e4b86f8ff996320ece2424b  wmblob-1.0.3.tar.bz2
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
- license field matches the actual license.
    GPLv2+ (according to README)
+ license is open source-compatible.
+ license text included.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
    https://koji.fedoraproject.org/koji/taskinfo?taskID=3057825
+ package installs properly.
+ rpmlint has no meaningful complaints:
    wmblob.src: W: spelling-error Summary(en_US) Dockapp -> Dock app, Dock-app, Dockage
    wmblob.src: I: enchant-dictionary-not-found de
    wmblob.x86_64: W: spelling-error Summary(en_US) Dockapp -> Dock app, Dock-app, Dockage
    wmblob.x86_64: I: enchant-dictionary-not-found de
    wmblob.x86_64: E: incorrect-fsf-address /usr/share/doc/wmblob-1.0.3/COPYING
    wmblob-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/wmblob-1.0.3/src/getopt.h
+ final provides and requires are sane
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.

You should inform upstream about the incorrect fsf address in COPYING, but no further action necessary.

APPROVED.

Comment 6 Mario Blättermann 2011-05-08 09:52:37 UTC
(In reply to comment #5)

> You should inform upstream about the incorrect fsf address in COPYING, but no
> further action necessary.

Upstream is only available from the dockapp pool at dockapps.org, no real homepage found. Well, I will try to send a mail to the author Jean-Luc-Herren, but I don't think to get a response.

Thanks for your review!

Comment 7 Mario Blättermann 2011-05-08 09:55:27 UTC
New Package SCM Request
=======================
Package Name: wmblob
Short Description: Dockapp which shows funny moving `blobs'
Owners: mariobl
Branches: f14 f15

Comment 8 Jason Tibbitts 2011-05-10 15:28:02 UTC
Git done (by process-git-requests).

Comment 9 Fedora Update System 2011-05-10 19:34:59 UTC
wmblob-1.0.3-3.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/wmblob-1.0.3-3.fc14

Comment 10 Fedora Update System 2011-05-10 19:43:11 UTC
wmblob-1.0.3-3.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/wmblob-1.0.3-3.fc15

Comment 11 Fedora Update System 2011-05-11 05:50:47 UTC
wmblob-1.0.3-3.fc15 has been pushed to the Fedora 15 testing repository.

Comment 12 Fedora Update System 2011-05-19 04:59:10 UTC
wmblob-1.0.3-3.fc15 has been pushed to the Fedora 15 stable repository.

Comment 13 Fedora Update System 2011-05-25 02:29:23 UTC
wmblob-1.0.3-3.fc14 has been pushed to the Fedora 14 stable repository.


Note You need to log in before you can comment on or make changes to this bug.