Bug 692813 - automount does not perform a sanity check of server name in configuration
Summary: automount does not perform a sanity check of server name in configuration
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: autofs
Version: 14
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
Assignee: Ian Kent
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 692814 692816
TreeView+ depends on / blocked
 
Reported: 2011-04-01 09:43 UTC by Siddhesh Poyarekar
Modified: 2015-09-14 00:22 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
: 692814 692816 (view as bug list)
Environment:
Last Closed: 2012-08-16 21:39:17 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Do not consider escaped '(' as a separator and do not crash if '(' does not find its ')' (1.54 KB, patch)
2011-04-01 09:43 UTC, Siddhesh Poyarekar
no flags Details | Diff

Description Siddhesh Poyarekar 2011-04-01 09:43:53 UTC
Created attachment 489333 [details]
Do not consider escaped '(' as a separator and do not crash if '(' does not find its ')'

Description of problem:
automount does not perform a sanity check of server name in configuration. Unmatched brackets in the configuration can cause automount to crash.

Also, with replication using wildcard '&', the same code crashes when the requested mount point contains an escaped bracket '\('.

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:

=======================
For the wildcard:

# echo '/jobman/tmp1 file /etc/auto.jobman.tmp1 -nodev,nosuid,intr,soft,retry=3,private' > /etc/auto.master 

# echo '* -nodev,nosuid,intr,soft,retry=10,proto=tcp &:/tmp1' > /etc/auto.jobman.tmp1

# service autofs restart

# df /jobman/tmp1/bl\(ah

=======================
For the configuration error:

# echo '/jobman/tmp1 file /etc/auto.jobman.tmp1 -nodev,nosuid,intr,soft,retry=3,private' > /etc/auto.master 

# echo '* -nodev,nosuid,intr,soft,retry=10,proto=tcp hostname(2:/tmp1' > /etc/auto.jobman.tmp1

# service autofs restart

# df /jobman/tmp1/foo
=======================

Actual results: Crash

Expected results: No crash

Additional info:

Attached patch that should fix both crashes.

Comment 1 Fedora End Of Life 2012-08-16 21:39:20 UTC
This message is a notice that Fedora 14 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 14. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained.  At this time, all open bugs with a Fedora 'version'
of '14' have been closed as WONTFIX.

(Please note: Our normal process is to give advanced warning of this 
occurring, but we forgot to do that. A thousand apologies.)

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, feel free to reopen 
this bug and simply change the 'version' to a later Fedora version.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we were unable to fix it before Fedora 14 reached end of life. If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora, you are encouraged to click on 
"Clone This Bug" (top right of this page) and open it against that 
version of Fedora.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping


Note You need to log in before you can comment on or make changes to this bug.