Bug 693137 (python-ffc) - Review Request: python-ffc - A compiler for finite element variational forms
Summary: Review Request: python-ffc - A compiler for finite element variational forms
Keywords:
Status: CLOSED WONTFIX
Alias: python-ffc
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: python-ufl
Blocks: FEniCS dolfin
TreeView+ depends on / blocked
 
Reported: 2011-04-02 23:16 UTC by Fabian Affolter
Modified: 2015-08-14 18:34 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-08-14 18:34:22 UTC
Type: ---
Embargoed:
jonathan.underwood: fedora-review?


Attachments (Terms of Use)

Description Fabian Affolter 2011-04-02 23:16:15 UTC
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-ffc.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/python-ffc-0.9.9-1.fc14.src.rpm

Project URL: https://launchpad.net/ffc

Description:
FFC is a compiler for finite element variational forms. From a high
level description of the form, it generates efficient low-level C++
code that can be used to assemble the corresponding discrete operator
(tensor). In particular, a bilinear form may be assembled into a matrix
and a linear form may be assembled into a vector.

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2969232

rpmlint output:
[fab@laptop023 SRPMS]$ rpmlint python-ffc-0.9.9-1.fc14.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[fab@laptop023 noarch]$ rpmlint python-ffc-0.9.9-1.fc14.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 1 Fabian Affolter 2011-09-10 19:49:19 UTC
* Sat Sep 10 2011 Fabian Affolter <fabian> - 0.9.10-1
- Updated to new upstream version 0.9.10

Updated files:
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-ffc.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/python-ffc-0.9.10-1.fc15.src.rpm

Comment 2 Fabian Affolter 2012-03-04 12:56:25 UTC
* Sun Mar 04 2012 Fabian Affolter <mail> - 1.0.0-1
- Updated to new upstream version 1.0.0

Updated files:
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-ffc.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/python-ffc-1.0.0-1.fc16.src.rpm

Comment 3 Jonathan Underwood 2013-01-24 15:20:09 UTC
Hello Fabian, are you still about and wanting this package reviewed? If you are I'll review it. If you're not I'll submit it for review myself.

Comment 4 Fabian Affolter 2013-03-05 16:40:10 UTC
I still would like to see FEniCS in Fedora. 

* Tue Mar 05 2013 Fabian Affolter <mail> - 1.1.0-1
- Updated to new upstream version 1.1.0

Updated files:
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-ffc.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/python-ffc-1.1.0-1.fc18.src.rpm

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5080862

rpmlint output:
[fab@localhost noarch]$ rpmlint python-ffc-1.1.0-1.fc18.noarch.rpm 
python-ffc.noarch: W: spelling-error Summary(en_US) variational -> variation, variegation, motivational
python-ffc.noarch: W: spelling-error %description -l en_US variational -> variation, variegation, motivational
python-ffc.noarch: W: spelling-error %description -l en_US bilinear -> bi linear, bi-linear, linear
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

[fab@localhost noarch]$ rpmlint python-ffc-1.1.0-1.fc18.noarch.rpm 
python-ffc.noarch: W: spelling-error Summary(en_US) multilinear -> multilingual
python-ffc.noarch: W: spelling-error %description -l en_US multilinear -> multilingual
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Comment 5 Jonathan Underwood 2013-03-05 18:42:49 UTC
Package Review
==============

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Header files in -devel subpackage, if present.
  Note: python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/AdaptivePoisson.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/AlgebraOperators.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/Biharmonic.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/CoefficientOperators.h python-
  ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/Components.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/Conditional.h python-ffc :
  /usr/share/doc/python-ffc-1.1.0/test/regression/references/r_auto/Constant.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/Elasticity.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/EnergyNorm.h python-ffc :
  /usr/share/doc/python-ffc-1.1.0/test/regression/references/r_auto/Equation.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/FacetIntegrals.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/FacetRestrictionAD.h python-ffc
  : /usr/share/doc/python-ffc-1.1.0/test/regression/references/r_auto/Heat.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/HyperElasticity.h python-ffc :
  /usr/share/doc/python-ffc-1.1.0/test/regression/references/r_auto/Mass.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/MathFunctions.h python-ffc :
  /usr/share/doc/python-ffc-1.1.0/test/regression/references/r_auto/MetaData.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/Mini.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/MixedMixedElement.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/MixedPoisson.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/NavierStokes.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/NeumannProblem.h python-ffc :
  /usr/share/doc/python-ffc-1.1.0/test/regression/references/r_auto/Normals.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/Optimization.h python-ffc :
  /usr/share/doc/python-ffc-1.1.0/test/regression/references/r_auto/P5tet.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/P5tri.h python-ffc :
  /usr/share/doc/python-ffc-1.1.0/test/regression/references/r_auto/Poisson.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/PoissonDG.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/QuadratureElement.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/ReactionDiffusion.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/RestrictedElement.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/SpatialCoordinates.h python-ffc
  : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/StabilisedStokes.h python-ffc :
  /usr/share/doc/python-ffc-1.1.0/test/regression/references/r_auto/Stokes.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/SubDomain.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/SubDomains.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/TensorWeightedPoisson.h python-
  ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/VectorLaplaceGradCurl.h python-
  ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/VectorPoisson.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/X_Element0.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/X_Element1.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_auto/X_Element2.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/AdaptivePoisson.h python-
  ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/AlgebraOperators.h python-
  ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/Biharmonic.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/CoefficientOperators.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/Components.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/Conditional.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/Constant.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/Elasticity.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/EnergyNorm.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/Equation.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/FacetIntegrals.h python-
  ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/FacetRestrictionAD.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/Heat.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/HyperElasticity.h python-
  ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/Mass.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/MathFunctions.h python-ffc
  : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/MetaData.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/Mini.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/MixedMixedElement.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/MixedPoisson.h python-ffc
  : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/NavierStokes.h python-ffc
  : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/NeumannProblem.h python-
  ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/Normals.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/Optimization.h python-ffc
  : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/P5tet.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/P5tri.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/Poisson.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/PoissonDG.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/QuadratureElement.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/ReactionDiffusion.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/RestrictedElement.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/SpatialCoordinates.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/StabilisedStokes.h python-
  ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/Stokes.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/SubDomain.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/SubDomains.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/TensorWeightedPoisson.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/VectorLaplaceGradCurl.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/VectorPoisson.h python-ffc
  : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/X_Element0.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/X_Element1.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature/X_Element2.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/AdaptivePoisson.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/AlgebraOperators.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/Biharmonic.h python-ffc
  : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/CoefficientOperators.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/Components.h python-ffc
  : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/Conditional.h python-ffc
  : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/Constant.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/Elasticity.h python-ffc
  : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/EnergyNorm.h python-ffc
  : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/Equation.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/FacetIntegrals.h python-
  ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/FacetRestrictionAD.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/Heat.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/HyperElasticity.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/Mass.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/MathFunctions.h python-
  ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/MetaData.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/Mini.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/MixedMixedElement.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/MixedPoisson.h python-
  ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/NavierStokes.h python-
  ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/NeumannProblem.h python-
  ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/Normals.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/Optimization.h python-
  ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/P5tet.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/P5tri.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/Poisson.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/PoissonDG.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/QuadratureElement.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/ReactionDiffusion.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/RestrictedElement.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/SpatialCoordinates.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/StabilisedStokes.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/Stokes.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/SubDomain.h python-ffc :
  /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/SubDomains.h python-ffc
  : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/TensorWeightedPoisson.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/VectorLaplaceGradCurl.h
  python-ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/VectorPoisson.h python-
  ffc : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/X_Element0.h python-ffc
  : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/X_Element1.h python-ffc
  : /usr/share/doc/python-
  ffc-1.1.0/test/regression/references/r_quadrature_O/X_Element2.h python-ffc
  : /usr/share/doc/python-ffc-1.1.0/test/regression/ufctest.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- Large documentation must go in a -doc subpackage.
  Note: Documentation size is 49940480 bytes in 303 files.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
Personally I think this is ok, as it will help with building on older (EL) releases

[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[!]: Development files must be in a -devel package
See above - there's a lot of header files under the doc directory for the test suite

[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "LGPL (v3 or later)", "GPL (v2 or later)", "Unknown or generated". 3
     files have unknown license. Detailed output of licensecheck in
     /home/jgu/693137-python-ffc/licensecheck.txt

The file sandbox/swig/optimise.cpp has no license - it might be worth
clarifying with upstream how this file is licensed. Not a blocker
though, as this file is tiny.

However, there is a larger problem in that the COPYING file is for
GPLv3, whereas the actual files are licensed inconsistently:

sandbox/swig/product_obj.py is LGPL (v3 or later)
/doc/sphinx/scripts/generate_modules.py is GPL (v2 or later)

This needs resolving with upstream - they should be encouraged to
audit their file headers to be consistent with their desired licenses,
or COPYING files for all licenses should be present.

The license field at the moment should be "GPLv3+ and GPLv2+ and LGPLv3+" 

Also, you should include COPYING.LESSER in the package as well as COPYING

[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).

Python:
[x]: Python eggs must not download any dependencies during the build process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[!]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.

See above - licensing situation needs clarifying and relevant license
files added if needed.

[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.

It would be nice if the test suite (which you currently package as
docs) were ran during package build. This is not a blocker though.

[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python-ffc-1.1.0-1.fc18.noarch.rpm
python-ffc.noarch: W: spelling-error Summary(en_US) multilinear -> multilingual

False positive - ignore

python-ffc.noarch: W: spelling-error %description -l en_US multilinear -> multilingual
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

False positive - ignore


Rpmlint (installed packages)
----------------------------
# rpmlint python-ffc
python-ffc.noarch: W: spelling-error Summary(en_US) multilinear -> multilingual
python-ffc.noarch: W: spelling-error %description -l en_US multilinear -> multilingual
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
# echo 'rpmlint-done:'

False positives- ignore

Requires
--------
python-ffc (rpmlib, GLIBC filtered):
    /usr/bin/python
    numpy
    python(abi)
    python-fiat
    python-ufl



Provides
--------
python-ffc:
    python-ffc



MD5-sum check
-------------
http://launchpad.net/ffc/1.1.x/1.1.0/+download/ffc-1.1.0.tar.gz :
  CHECKSUM(SHA256) this package     : dc04cb175a10d8919708533b7fe8d3f5c9eab8d0bdb69d530caca7957f0432ce
  CHECKSUM(SHA256) upstream package : dc04cb175a10d8919708533b7fe8d3f5c9eab8d0bdb69d530caca7957f0432ce


Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29
Buildroot used: fedora-18-x86_64
Command line :/usr/bin/fedora-review -b 693137

Comment 6 Christopher Meng 2013-11-10 04:35:27 UTC
Can you push it?

Comment 7 Christopher Meng 2014-01-06 04:03:26 UTC
Jonathan, are you still interested in taking this review?

Since 1.2.0 is released, I hope you can review it again.

Comment 8 Jonathan Underwood 2014-07-25 09:14:08 UTC
Hi Christopher,

My jobs needs have moved on somewhat so I am no longer in a position of needing the Fenics stack in Fedora, nor using it, so I'm not sure it would be a good move for me to be pushing this - by which I presume you mean taking ownership?. I am more than happy to re-review it though if someone puts together a package for 1.2

Comment 9 Christopher Meng 2014-07-27 13:32:45 UTC
My initial thpought was to bring the whole FENiCS into Fedora Sci.

I will see what I can do in a few days.

And, I need to talk with the submitter first in fact...

Thanks!

Comment 10 Jonathan Underwood 2014-07-29 21:50:46 UTC
I had already started to bring the Fenics stack into Fedora. See the Fenics tracker bug I had created for progress:

https://bugzilla.redhat.com/show_bug.cgi?id=820660

At a certain point I became discouraged due to lack of reviewers, and lack of responsivity to my reviews of components others had submitted. But the work done is still all availble for anyone to pick up, and I'll help as time allows. I found upstream very responsive to issues I raised which came up during packaging.

Comment 11 Christopher Meng 2014-07-31 00:25:37 UTC
Update to 1.4.0, ok?

Comment 12 Fabian Affolter 2014-10-08 08:21:54 UTC
It's still work in progress. The attached files are drafts and are placed here to share the work with interested parties.

Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-ffc.spec
SRPM URL:https://fab.fedorapeople.org/packages/SRPMS/python-ffc-1.4.0-1.fc20.src.rpm

Comment 13 Rex Dieter 2015-04-17 18:38:45 UTC
I'm interested in helping move this along, though it would appear the original submitter of this review request is no longer interested.

Does anyone else want to own it and submit a new/separate review request?

(If not, I probably will soonish)

Comment 14 Jonathan Underwood 2015-04-17 20:15:51 UTC
I'm happy to review it Rex, if you do submit a package.

Comment 15 Jonathan Underwood 2015-07-29 18:30:11 UTC
Removing myself as the assignee of this bug, as it looks like it's not really going anywhere.

Comment 16 Jonathan Underwood 2015-08-14 18:34:22 UTC
Closing this, no activity forever.


Note You need to log in before you can comment on or make changes to this bug.