When you click on "Edit Attributes" (should that be lowercase "a"?), the table of attributes changes to contain text input fields. But changes to some of them simply do not make sense, e.g. TotalSuspensions. And, in case the job has already finished, it does not make sense to edit any of the attributes, does it? And what about running job? cumin-0.1.4712-1.el5 How reproducible: 100% Steps to Reproduce: 1. Grid -> Submissions -> submission -> job -> "Edit Attributes" (on top) Actual results: There are plenty of attributes which seem to be editable. Expected results: Only those attributes which make sense to be edited should be editable. Additional info: On already finished job, when I press final "Edit Attributes" (now in the bottom of the page), I get following list of errors in the yellow notification box: -------------------------- Edit Ad: Failed to set attribute TerminationPending to TRUE Edit Ad: Failed to set attribute OnExitHold to FALSE Edit Ad: Failed to set attribute PeriodicHold to FALSE Edit Ad: Failed to set attribute ExitBySignal to FALSE Edit Ad: Failed to set attribute TransferOut to FALSE Edit Ad: Failed to set attribute OnExitRemove to TRUE Edit Ad: Failed to set attribute NiceUser to FALSE Edit Ad: Failed to set attribute LeaveJobInQueue to FALSE Edit Ad: Failed to set attribute WantRemoteIO to TRUE Edit Ad: Failed to set attribute PeriodicRemove to FALSE Edit Ad: Failed to set attribute WantCheckpoint to FALSE Edit Ad: Failed to set attribute PeriodicRelease to FALSE Edit Ad: Failed to set attribute WantRemoteSyscalls to FALSE Edit Ad: Failed to set attribute TransferErr to FALSE Edit Ad: Failed to set attribute TransferIn to FALSE --------------------------
I'm not entirely sure what all of the values actually translate to on the backend. Given that, I'm soliciting thoughts on which values should be made un-editable. Some things like CurrentTime seem very obvious, but others are perhaps not so black and white. Maybe it would be easier to enumerate the items that it does make sense to edit? It seems like editing the attributes of a job that is already finished doesn't make any sense. Should I just eliminate the "edit" button for jobs that are already finished?
I have made several job attributes non-editable. Please advise if there are additional attributes that should be non-editable. These changes are in as of revision 4723
Technical note added. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. New Contents: Cause: Many job-attribute fields were made editable on the edit page, but do not make sense to edit Consequence: The user is presented with the option to edit nonsensical fields (ie: edit remote machine current time). Fix: Several fields were marked as not editable in the Submission->Job->Edit form. Result: The editable fields in Submission->Job->Edit form should make sense to be editable.
Checked in cumin-0.1.4725-1.el5 Editing attributes of a Running job seems to be fine. Editing attributes of a Completed job is still possible and allows to edit much more fields than of the Running job. The original intention (as I understood it in very old Cumin two years ago) was, I think, that you could clone a job from an already finished one, possibly edit its attributes so the new clone does not end with the same output/error as the one you are cloning from. The same "Edit Ad" errors appear when I press Submit on a finished (i.e. either Completed or Removed) job as I reprinted in the description.
Perhaps I'm lacking a little bit of background and insight on this one. I'm not able to get to a job once it has finished. When a job has finished, I just get the "We can't find the object you requested" page. Can you provide steps that I can follow to get to a page that allows me to edit the job attributes for a completed job? Thanks
The JobServer needs to be set up. See documentation: http://docs.redhat.com/docs/en-US/Red_Hat_Enterprise_MRG/1.3/html/Management_Console_Installation_Guide/chap-Management_Console_Installation_Guide-Using_the_CONSOLE.html#sect-Management_Console_Installation_Guide-Using_the_CONSOLE-Using_the_CONSOLE_with_GRID-Job_Server_Configuration
Condor does not support changing attributes on completed jobs. Edit button for completed jobs should be hidden/grayed-out. Allowing cloning of completed jobs for edit and resubmission is an idea for future development, should be a separate RFE if we tackle it.
Per today's discussion, I have made a tweak to not display the "edit attributes" button for jobs that have been "Completed". This fix is in revision 4728
In cumin-0.1.4746-1.el5, when I submit a simple job*, then put it on hold, change args from "20m" to "15", submit. All Ads seem to be updated correctly (one notification line in yellow box for each), but the Args contain still "20m", even after releasing the job. * script: ---------- getent passwd test || adduser test echo Submitting a job su - test -c "condor_submit $* << EOF Executable = /bin/sleep Universe = vanilla args = 20m queue 1 EOF"
Funnily enough, the other time the value got updated and after releasing the job, it really ended after 15 seconds. I am retesting.
Any update on this?
The update itself seems to work, in some cases, BUT I use /bin/sleep as command: If I supply "25m" as an argument while editing a held job, only number 25 gets through. Another try behaves the same as below: Then, if I first change (via Cumin edit job attrs) args to let's say "8", submit, wait until it gets updated, then try to change it to "9h" (can be any other number ending with "h"), all I see is a never-ending "Loading...". Sorry, sometimes it is hard for me to find any reproducibility in all this if there are many errors at once. Please, try to reproduce yourself, maybe it will make more sense to you. Thanks.
Verified on cumin-0.1.4746-1.el5 There a new bug which came out of above comments and is already out of scope of the original bug: bug 703196