Fixed in 4880. Type information which distinguishes expressions from strings in the results from GetJobAd is now used by cumin. When a job attribute is edited and submitted, double quotes will be added to strings if not already present and double quotes will be removed from expressions. This ensures that strings stay strings and expressions stay expressions when processed by the condor plugin.
Possible addendum to this. There is some type checking done by cumin when an attribute value is changed but it is hard to know what rules are appropriate for what fields. The only information cumin has in this case is "What was the type of the attribute value before it was changed?" This is not necessarily the same as "What type(s) can it be?" Cumin already has a class JobMetaData which indicates which attributes are writable on a jobAd and which aren't; that data could be extended to include an optional list of allowed types for a field. With that data in hand, the job ad edit page could enforce defined restrictions without guesswork.
Technical note added. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. New Contents: Cause When editing attributes on a job using the "Edit Attributes" form, Cumin does not distinguish string values from expression values automatically. Consequence String values must be explicitly double-quoted by the user when editing a value on the form. Otherwise, the value will be interpreted by condor as an expression which may cause errors and prevent the attribute value from being changed. Fix Cumin uses type information available from condor to distinguish between strings and expressions. Result Users no longer need to explicitly quote string values when editing attributes.
Works as expected with cumin-0.1.5037-1.el6.noarch
Technical note updated. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. Diffed Contents: @@ -1,11 +1 @@ -Cause +Previously, string values needed to be explicitly double-quoted by the user when editing a value on the form. When job attributes had been edited via the "Edit Attributes" form, Cumin did not distinguish string values from expression values automatically. Consequently, the value was interpreted by the Condor workload management system as an expression, which sometimes caused errors and prevented the attribute value from being changed. With this update, Cumin uses type information available from Condor to distinguish between strings and expressions and users are no longer required to explicitly quote string values when editing attributes.- When editing attributes on a job using the "Edit Attributes" form, Cumin does not distinguish string values from expression values automatically. - -Consequence - String values must be explicitly double-quoted by the user when editing a value on the form. Otherwise, the value will be interpreted by condor as an expression which may cause errors and prevent the attribute value from being changed. - -Fix - Cumin uses type information available from condor to distinguish between strings and expressions. - -Result - Users no longer need to explicitly quote string values when editing attributes.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHEA-2012-0045.html