Spec URL: http://b.bbbs.net/sawfish/sawfish-pager.spec SRPM URL: http://b.bbbs.net/sawfish/sawfish-pager-0.90.1-1.fc15.src.rpm Description: A sawfish specific configurable pager map of your desktop with a viewport support. It can be configured to follow where you are, or optionally show all workspaces at once. Check README from this package documentation how to activate.
Sorry, BuildRequirements are incomplete. I'll create another SRPM...
Updated files: Spec URL: http://b.bbbs.net/sawfish/sawfish-pager.spec SRPM URL: http://b.bbbs.net/sawfish/sawfish-pager-0.90.1-2.fc15.src.rpm
Building this package for F15 fails: http://koji.fedoraproject.org/koji/taskinfo?taskID=3150739 build.log says: error: File not found by glob: /builddir/build/BUILDROOT/sawfish-pager-0.90.1-2.fc15.x86_64/usr/lib64/sawfish/*/*/sawfishpager Missing file or wrong folder name?
Just tested it on my own machine. The missing file is /builddir/build/BUILDROOT/sawfish-pager-0.90.1-2.fc15.x86_64/usr/lib64/sawfish/*/sawfishpager. Please remove the second asterisk, and it works.
Updated files: Spec URL: http://b.bbbs.net/sawfish/sawfish-pager.spec SRPM URL: http://b.bbbs.net/sawfish/sawfish-pager-0.90.2-1.fc15.src.rpm The problem was that sawfish-pager-0.90.1 was for older sawfish-1.8.0. Fedora already has sawfish-1.8.1 with new paths.
Succesful Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3271928 $ rpmlint -i -v *sawfish-pager.i686: I: checking sawfish-pager.i686: W: spelling-error %description -l en_US viewport -> view port, view-port, viewpoint The value of this tag appears to be misspelled. Please double-check. sawfish-pager.i686: W: spelling-error %description -l en_US workspaces -> work spaces, work-spaces, works paces The value of this tag appears to be misspelled. Please double-check. sawfish-pager.i686: I: checking-url http://sawfish.wikia.com/ (timeout 10 seconds) sawfish-pager.i686: E: incorrect-fsf-address /usr/share/doc/sawfish-pager-0.90.2/COPYING The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. sawfish-pager.src: I: checking sawfish-pager.src: W: spelling-error %description -l en_US viewport -> view port, view-port, viewpoint The value of this tag appears to be misspelled. Please double-check. sawfish-pager.src: W: spelling-error %description -l en_US workspaces -> work spaces, work-spaces, works paces The value of this tag appears to be misspelled. Please double-check. sawfish-pager.src: I: checking-url http://sawfish.wikia.com/ (timeout 10 seconds) sawfish-pager.src: I: checking-url http://download.tuxfamily.org/sawfishpager/sawfish-pager-0.90.2.tar.bz2 (timeout 10 seconds) sawfish-pager.x86_64: I: checking sawfish-pager.x86_64: W: spelling-error %description -l en_US viewport -> view port, view-port, viewpoint The value of this tag appears to be misspelled. Please double-check. sawfish-pager.x86_64: W: spelling-error %description -l en_US workspaces -> work spaces, work-spaces, works paces The value of this tag appears to be misspelled. Please double-check. sawfish-pager.x86_64: I: checking-url http://sawfish.wikia.com/ (timeout 10 seconds) sawfish-pager.x86_64: E: incorrect-fsf-address /usr/share/doc/sawfish-pager-0.90.2/COPYING The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. sawfish-pager-debuginfo.i686: I: checking sawfish-pager-debuginfo.i686: I: checking-url http://sawfish.wikia.com/ (timeout 10 seconds) sawfish-pager-debuginfo.x86_64: I: checking sawfish-pager-debuginfo.x86_64: I: checking-url http://sawfish.wikia.com/ (timeout 10 seconds) sawfish-pager.spec: I: checking-url http://download.tuxfamily.org/sawfishpager/sawfish-pager-0.90.2.tar.bz2 (timeout 10 seconds) 5 packages and 1 specfiles checked; 2 errors, 6 warnings. Please replace COPYING (includes the wrong FSF address) with a new one from the GNU websites: http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt The spelling errors can be ignored. glib2-devel is a recursive dependency of gtk2-devel, you might drop it.
> Please replace COPYING (includes the wrong FSF address) with a new one from the > GNU websites: Spec done. Upstream notified. > glib2-devel is a recursive dependency of gtk2-devel, you might drop it. cairo-devel is too. I dropped both. Updated files: Spec URL: http://b.bbbs.net/sawfish/sawfish-pager.spec SRPM URL: http://b.bbbs.net/sawfish/sawfish-pager-0.90.2-2.fc16.src.rpm
(In reply to comment #7) > > Please replace COPYING (includes the wrong FSF address) with a new one from the > > GNU websites: > > Spec done. Upstream notified. > > > glib2-devel is a recursive dependency of gtk2-devel, you might drop it. > > cairo-devel is too. I dropped both. Just a side note. Rule of thumb for these situations is a) if your app explicitly uses files from both packages (say, your app's sources are including headers from both ones) then you *should* list both as BuildRequires. The idea is that one of these packages could drop dependency on another (which is very unlikely in case of GTK2, so you really can drop these *-devel BuildRequires). b) Otherwise you shouldn't require both packages (to shorted dependency chain as little as possible).
(In reply to comment #7) > > Please replace COPYING (includes the wrong FSF address) with a new one from the > > GNU websites: > > Spec done. Upstream notified. Please, be careful with upstream's provided legal documents. I'd rather prefer not to touch them even in case of CRLF conversion, but since you seems to be in a good relations with upstream authors then it's ok. Otherwise you must avoid editing them in any way.
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3272071 $ rpmlint -i -v * sawfish-pager.i686: I: checking sawfish-pager.i686: W: spelling-error %description -l en_US viewport -> view port, view-port, viewpoint The value of this tag appears to be misspelled. Please double-check. sawfish-pager.i686: W: spelling-error %description -l en_US workspaces -> work spaces, work-spaces, works paces The value of this tag appears to be misspelled. Please double-check. sawfish-pager.i686: I: checking-url http://sawfish.wikia.com/ (timeout 10 seconds) sawfish-pager.x86_64: I: checking sawfish-pager.x86_64: W: spelling-error %description -l en_US viewport -> view port, view-port, viewpoint The value of this tag appears to be misspelled. Please double-check. sawfish-pager.x86_64: W: spelling-error %description -l en_US workspaces -> work spaces, work-spaces, works paces The value of this tag appears to be misspelled. Please double-check. sawfish-pager.x86_64: I: checking-url http://sawfish.wikia.com/ (timeout 10 seconds) sawfish-pager.src: I: checking sawfish-pager.src: W: spelling-error %description -l en_US viewport -> view port, view-port, viewpoint The value of this tag appears to be misspelled. Please double-check. sawfish-pager.src: W: spelling-error %description -l en_US workspaces -> work spaces, work-spaces, works paces The value of this tag appears to be misspelled. Please double-check. sawfish-pager.src: I: checking-url http://sawfish.wikia.com/ (timeout 10 seconds) sawfish-pager.src: I: checking-url http://www.gnu.org/licenses/gpl-2.0.txt (timeout 10 seconds) sawfish-pager.src: I: checking-url http://download.tuxfamily.org/sawfishpager/sawfish-pager-0.90.2.tar.bz2 (timeout 10 seconds) sawfish-pager-debuginfo.i686: I: checking sawfish-pager-debuginfo.i686: I: checking-url http://sawfish.wikia.com/ (timeout 10 seconds) sawfish-pager-debuginfo.x86_64: I: checking sawfish-pager-debuginfo.x86_64: I: checking-url http://sawfish.wikia.com/ (timeout 10 seconds) sawfish-pager.spec: I: checking-url http://www.gnu.org/licenses/gpl-2.0.txt (timeout 10 seconds) sawfish-pager.spec: I: checking-url http://download.tuxfamily.org/sawfishpager/sawfish-pager-0.90.2.tar.bz2 (timeout 10 seconds) 5 packages and 1 specfiles checked; 0 errors, 6 warnings. Spelling errors can be ignored.
(In reply to comment #9) > Please, be careful with upstream's provided legal documents. I'd rather prefer > not to touch them even in case of CRLF conversion, but since you seems to be in > a good relations with upstream authors then it's ok. Otherwise you must avoid > editing them in any way. Means, I have to leave it untouched even to make rpmlint happy with a correct FSF address?
(In reply to comment #11) > (In reply to comment #9) > > Please, be careful with upstream's provided legal documents. I'd rather prefer > > not to touch them even in case of CRLF conversion, but since you seems to be in > > a good relations with upstream authors then it's ok. Otherwise you must avoid > > editing them in any way. > > Means, I have to leave it untouched even to make rpmlint happy with a correct > FSF address? IANAL but I'd rather to leave it as is. Legal documents are very very fragile. I think the proper way to address issues like that, is to notice upstream first, wait for them to fix their license and backport that change into current tarball.
(In reply to comment #12) > I think the proper way to address issues like that, is to notice upstream > first, wait for them to fix their license and backport that change into current > tarball. I'm often packaging software whose upstream developers have gone for a long time (e.g. WindowMaker dockapps). Should I leave the license file untouched anyway?
(In reply to comment #9) > (In reply to comment #7) > > > Please replace COPYING (includes the wrong FSF address) with a new one from the > > > GNU websites: > > > > Spec done. Upstream notified. > > Please, be careful with upstream's provided legal documents. I'd rather prefer > not to touch them even in case of CRLF conversion, I was really wondering about that one. I noticed rpmlint's error when I created the original spec and didn't want to touch it. For example bug #700095 says that I should not touch it. So... I should leave COPYING as is...?
There's no valid guideline for that issue. For my WindowMaker dockapps, I get this error very often, and I can't fix it really, because upstream is dead. As a compromise, I replace the COPYING file with a newer one, and I leave all source files untouched, which include the same incorrect address. I assume that almost no one writes to the FSF to get a printed copy of a license file. That's why I don't recognize that as important, as long as we undoubtedly are able to figure out under which license a software has been released. However, I agree with Marcela Mašláňová (bug #700095). We should at least make this issue a warning rather than an error.
Updated files: Spec URL: http://b.bbbs.net/sawfish/sawfish-pager.spec SRPM URL: http://b.bbbs.net/sawfish/sawfish-pager-0.90.2-3.fc16.src.rpm Changes: - Don't update COPYING, keep old FSF address. Upstream is notified. Anything else? "Viewport" and "workspace" are the terms used by Sawfish...
(In reply to comment #16) > Updated files: > > Spec URL: http://b.bbbs.net/sawfish/sawfish-pager.spec > SRPM URL: http://b.bbbs.net/sawfish/sawfish-pager-0.90.2-3.fc16.src.rpm > > > Changes: > - Don't update COPYING, keep old FSF address. Upstream is notified. > OK. As long as upstream is responsible, it is the best choice. > Anything else? "Viewport" and "workspace" are the terms used by Sawfish... Yes, of course. The expat spellchecker doesn't know about that. If there terms appear in the description which are common to the packaged software, it is OK. Koji scratch build of your new srpm: http://koji.fedoraproject.org/koji/taskinfo?taskID=3273914
$ rpmlint -i -v * sawfish-pager.i686: I: checking sawfish-pager.i686: W: spelling-error %description -l en_US viewport -> view port, view-port, viewpoint The value of this tag appears to be misspelled. Please double-check. sawfish-pager.i686: W: spelling-error %description -l en_US workspaces -> work spaces, work-spaces, works paces The value of this tag appears to be misspelled. Please double-check. sawfish-pager.i686: I: checking-url http://sawfish.wikia.com/ (timeout 10 seconds) sawfish-pager.i686: E: incorrect-fsf-address /usr/share/doc/sawfish-pager-0.90.2/COPYING The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. sawfish-pager.x86_64: I: checking sawfish-pager.x86_64: W: spelling-error %description -l en_US viewport -> view port, view-port, viewpoint The value of this tag appears to be misspelled. Please double-check. sawfish-pager.x86_64: W: spelling-error %description -l en_US workspaces -> work spaces, work-spaces, works paces The value of this tag appears to be misspelled. Please double-check. sawfish-pager.x86_64: I: checking-url http://sawfish.wikia.com/ (timeout 10 seconds) sawfish-pager.x86_64: E: incorrect-fsf-address /usr/share/doc/sawfish-pager-0.90.2/COPYING The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. sawfish-pager.src: I: checking sawfish-pager.src: W: spelling-error %description -l en_US viewport -> view port, view-port, viewpoint The value of this tag appears to be misspelled. Please double-check. sawfish-pager.src: W: spelling-error %description -l en_US workspaces -> work spaces, work-spaces, works paces The value of this tag appears to be misspelled. Please double-check. sawfish-pager.src: I: checking-url http://sawfish.wikia.com/ (timeout 10 seconds) sawfish-pager.src: I: checking-url http://download.tuxfamily.org/sawfishpager/sawfish-pager-0.90.2.tar.bz2 (timeout 10 seconds) sawfish-pager-debuginfo.i686: I: checking sawfish-pager-debuginfo.i686: I: checking-url http://sawfish.wikia.com/ (timeout 10 seconds) sawfish-pager-debuginfo.x86_64: I: checking sawfish-pager-debuginfo.x86_64: I: checking-url http://sawfish.wikia.com/ (timeout 10 seconds) sawfish-pager.spec: I: checking-url http://download.tuxfamily.org/sawfishpager/sawfish-pager-0.90.2.tar.bz2 (timeout 10 seconds) 5 packages and 1 specfiles checked; 2 errors, 6 warnings. OK, no recognizable issues, given the discussions earlier in this review. --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. GPLv2+ [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum * e84286703e550cb7f4da15934f6e207f sawfish-pager-0.90.2.tar.bz2 e84286703e550cb7f4da15934f6e207f sawfish-pager-0.90.2.tar.bz2.packaged [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - Succesful Koji build available. [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [+] MUST: All build dependencies must be listed in BuildRequires. [.] MUST: The spec file MUST handle locales properly. [.] MUST: If a package installs files below %{_datadir}/icons, the icon cache must be updated. [.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [.] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Packages must not provide RPM dependency information when that information is not global in nature, or are otherwise handled. [.] MUST: When filtering automatically generated RPM dependency information, the filtering system implemented by Fedora must be used. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), ... [.] MUST: devel packages must require the base package using a fully versioned dependency. [.] MUST: Packages must NOT contain any .la libtool archives. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file [.] MUST: .desktop files must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream... [+] SHOULD: Timestamps of files should be preserved. [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses mock anyway) [+] SHOULD: The reviewer should test that the package functions as described. Works fine with Sawfish 1.8.1 on F15. [.] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin ... [.] SHOULD: Your package should contain man pages for binaries/scripts. ---------------- PACKAGE APPROVED ----------------
New Package SCM Request ======================= Package Name: sawfish-pager Short Description: Pager for Sawfish window manager Owners: kimheino Branches: f15 f16 InitialCC:
Git done (by process-git-requests).
sawfish-pager-0.90.2-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/sawfish-pager-0.90.2-3.fc15
sawfish-pager-0.90.2-3.fc15 has been pushed to the Fedora 15 testing repository.
sawfish-pager-0.90.2-3.fc15 has been pushed to the Fedora 15 stable repository.