Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Digest-MD5-File/branches/fedora/perl-Digest-MD5-File.spec SRPM URL: http://www.city-fan.org/~paul/extras/perl-Digest-MD5-File/perl-Digest-MD5-File-0.07-1.fc16.src.rpm Description: Get MD5 sums for files of a given path or content of a given URL.
Package: perl-Digest-MD5-File Version: 0.07 Release: 1.fc16 Sources: Digest-MD5-File-0.07.tar.gz Patches: ---------- Package successfully built locally. Package successfully built in mock, fedora-rawhide-x86_64. Package successfully built in mock, fedora-rawhide-i386. Package successfully built in mock, fedora-15-x86_64. Package successfully built in mock, fedora-15-i386. Package successfully built in mock, fedora-14-x86_64. Package successfully built in mock, fedora-14-i386. Package successfully built in koji, dist-rawhide. MUST items: [ OK ] Package does NOT include pre-built binaries or libraries [ OK ] Spec file is legible and written in American english [ OK ] Package successfully builds on at least one supported primary architecture [ -- ] All ExcludeArch tags valid, referencing proper bug reports [ OK ] Package obeys FHS (with _libexecdir and /srv exceptions) [ OK ] No errors reported by rpmlint [ OK ] Changelog present and properly formatted [ OK ] Package does NOT include Packager, Vendor, Copyright or PreReq tags [ OK ] Source tags are working URLs and sources match upstream or justified otherwise [ FAIL ] Requires correct or justified otherwise [ OK ] BuildRequires correct or justified otherwise [ OK ] All file names are in proper UTF-8 encoding [ OK ] All plain text failes are in proper UTF-8 encoding [ -- ] Large documentation files are located in doc subpackage [ OK ] All documentation prefixed with %doc [ OK ] Documentation is NOT executable [ OK ] No files in %doc are needed at run-time [ -- ] Compiler flags honor Fedora defaults or are justified [ -- ] Package generates useful debuginfo packages [ -- ] Header files are placed in devel subpackage [ -- ] Unversioned shared libraries are placed in devel subpackage [ -- ] Pkgconfig files are placed in devel subpackage [ -- ] Full-versioned Requires of the base package in subpackages [ -- ] Package calls ldconfig in post and postun sections for all subpackages, if applicable [ -- ] Static libraries are provided by static subpackage [ OK ] Package contains no static executables unless approved by FESCo [ OK ] Package does NOT bundle any system libraries [ -- ] RPath not used for anything besides internal libraries [ -- ] All config files are marked noreplace or justified otherwise [ OK ] No config files are located under /usr [ -- ] Package contains a SystemV-compatible initscript [ -- ] A GUI application installs a proper desktop file [ -- ] All desktop files are installed by desktop-file-install or justified otherwise [ OK ] Package consistently uses macros [ -- ] makeinstall macro is used only if make install DESTDIR=%{buildroot} does NOT work [ -- ] Macros in Summary and description are expandable at build-time [ -- ] globals used in place of defines [ -- ] Locales handled correctly -- package requires gettext and uses find_lang, if applicable [ -- ] Scriptlets are sane [ OK ] Package is not relocatable unless justified [ OK ] Package contains only acceptable code or content [ OK ] Package owns all the files and directories it creates, installs and/or uses unless those are already owned by another package [ OK ] files sections do NOT contain duplicate files except for licenses [ OK ] Package does NOT cause any conflicts [ OK ] Package does NOT contain kernel modules [ OK ] Package does NOT bundle fonts or other general purpose data [ OK ] Final Requires and Provides are sane SHOULD items: [ OK ] The Summary does NOT end with a period [ FAIL ] Package does NOT include BuildRoot tag, clean section or buildroot removal in install section [ OK ] Package should preserve files timestamps [ OK ] Package does NOT explicitly BuildRequire bash, bzip2, coreutils, cpio, diffutils, fedora-release, findutils, gawk, gcc, gcc-c++, grep, gzip, info, make, patch, redhat-rpm-config, rpm-build, sed, shadow-utils, tar, unzip, util-linux-ng, which or xz [ OK ] Description does NOT consist of lines longer than 80 characters [ OK ] Package uses parallel make [ -- ] In case of a web application, package installs date into /usr/share instead of /var/www [ -- ] All patches have a comment or an upstream bug link [ -- ] Package installs manpages for all executables [ OK ] Package contains check section and all tests pass [ ?? ] Package works as expected NOTES: ------ Package should Require perl(Encode), perl(Exporter) and perl(File::Spec). Those are 'required' in the module but not caught by RPM. Additionally, BuildRoot and its cleaning is no longer needed and should be removed. The same applies to the %defattr macro. Fix the deps. Not approved.
(In reply to comment #1) > NOTES: > ------ > Package should Require perl(Encode), perl(Exporter) and perl(File::Spec). Those > are 'required' in the module but not caught by RPM. Fixed in -2. > Additionally, BuildRoot and its cleaning is no longer needed and should be > removed. The same applies to the %defattr macro. These are needed for EPEL-4/5 compatibility; I intend to build the package for all current target releases. Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Digest-MD5-File/branches/fedora/perl-Digest-MD5-File.spec SRPM URL: http://www.city-fan.org/~paul/extras/perl-Digest-MD5-File/perl-Digest-MD5-File-0.07-2.fc16.src.rpm
(In reply to comment #2) > (In reply to comment #1) > > NOTES: > > ------ > > Package should Require perl(Encode), perl(Exporter) and perl(File::Spec). Those > > are 'required' in the module but not caught by RPM. > > Fixed in -2. Looks okay. > > > Additionally, BuildRoot and its cleaning is no longer needed and should be > > removed. The same applies to the %defattr macro. > > These are needed for EPEL-4/5 compatibility; I intend to build the package for > all current target releases. Fine with me. > > Spec URL: > http://subversion.city-fan.org/repos/cfo-repo/perl-Digest-MD5-File/branches/fedora/perl-Digest-MD5-File.spec > > SRPM URL: > http://www.city-fan.org/~paul/extras/perl-Digest-MD5-File/perl-Digest-MD5-File-0.07-2.fc16.src.rpm Approving.
New Package SCM Request ======================= Package Name: perl-Digest-MD5-File Short Description: Perl extension for getting MD5 sums for files and URLs Owners: pghmcfc Branches: EL-4 EL-5 EL-6 F-13 F-14 F-15 InitialCC: perl-sig Thanks for the review Petr.
Git done (by process-git-requests).
perl-Digest-MD5-File-0.07-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-Digest-MD5-File-0.07-2.fc15
perl-Digest-MD5-File-0.07-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-Digest-MD5-File-0.07-2.fc14
perl-Digest-MD5-File-0.07-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Digest-MD5-File-0.07-2.el6
perl-Digest-MD5-File-0.07-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/perl-Digest-MD5-File-0.07-2.fc13
perl-Digest-MD5-File-0.07-2.fc14 has been pushed to the Fedora 14 stable repository.
perl-Digest-MD5-File-0.07-2.fc13 has been pushed to the Fedora 13 stable repository.
perl-Digest-MD5-File-0.07-2.fc15 has been pushed to the Fedora 15 stable repository.
perl-Digest-MD5-File-0.07-2.el6 has been pushed to the Fedora EPEL 6 stable repository.