Bug 705361 - Review Request: perl-Proc-SyncExec - Spawn processes but report exec() errors
Summary: Review Request: perl-Proc-SyncExec - Spawn processes but report exec() errors
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Marcela Mašláňová
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 711462
TreeView+ depends on / blocked
 
Reported: 2011-05-17 13:17 UTC by Petr Pisar
Modified: 2011-06-21 17:44 UTC (History)
2 users (show)

Fixed In Version: perl-Proc-SyncExec-1.01-1.fc14
Clone Of:
Environment:
Last Closed: 2011-05-30 07:52:44 UTC
Type: ---
Embargoed:
mmaslano: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Pisar 2011-05-17 13:17:13 UTC
Spec URL: http://ppisar.fedorapeople.org/perl-Proc-SyncExec/perl-Proc-SyncExec.spec
SRPM URL: http://ppisar.fedorapeople.org/perl-Proc-SyncExec/perl-Proc-SyncExec-1.01-1.fc14.src.rpm
Description:
This module contains functions for synchronized process spawning with full
error return. If the child's exec() call fails the reason for the failure
is reported back to the parent.

Comment 1 Marcela Mašláňová 2011-05-25 10:41:51 UTC
http://koji.fedoraproject.org/koji/taskinfo?taskID=3091559

Test in koji didn't pass, because it's looking for this package. You should fix paths in test.t.

Comment 2 Petr Pisar 2011-05-25 15:06:29 UTC
The tests fail because koji glibc returns EPERM instead of ENOENT when executing non-existent command (object of the failing tests).

Comment 3 Petr Pisar 2011-05-25 16:19:18 UTC
Package with tests adjusted for Koji build system has been published on the same URL. (Actually, Koji returns EACCES, not an EPERM).

Comment 4 Marcela Mašláňová 2011-05-26 06:54:26 UTC
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
 http://koji.fedoraproject.org/koji/taskinfo?taskID=3093159
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK

resolvedeps-f16 perl-Proc-SyncExec-1.01-1.fc14.src.rpm
Binary dependencies resolvable. Ok.

APPROVED

Comment 5 Petr Pisar 2011-05-26 07:19:52 UTC
New Package SCM Request
=======================
Package Name: perl-Proc-SyncExec 
Short Description: Spawn processes but report exec() errors
Owners: ppisar mmaslano psabata
Branches: 
InitialCC: perl-sig

Comment 6 Jason Tibbitts 2011-05-27 16:34:22 UTC
Git done (by process-git-requests).

Comment 7 Petr Pisar 2011-05-30 07:52:44 UTC
Thank you for the review and the repository.

Comment 8 Petr Pisar 2011-06-07 15:27:37 UTC
Package Change Request
======================
Package Name: perl-Proc-SyncExec
New Branches: f14 f15
Owners: ppisar mmaslano psabata
InitialCC: perl-sig

Comment 9 Gwyn Ciesla 2011-06-07 18:12:47 UTC
Git done (by process-git-requests).

Comment 10 Fedora Update System 2011-06-08 06:42:12 UTC
perl-Proc-SyncExec-1.01-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/perl-Proc-SyncExec-1.01-1.fc15

Comment 11 Fedora Update System 2011-06-08 06:43:38 UTC
perl-Proc-SyncExec-1.01-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/perl-Proc-SyncExec-1.01-1.fc14

Comment 12 Fedora Update System 2011-06-21 17:37:39 UTC
perl-Proc-SyncExec-1.01-1.fc15 has been pushed to the Fedora 15 stable repository.

Comment 13 Fedora Update System 2011-06-21 17:44:35 UTC
perl-Proc-SyncExec-1.01-1.fc14 has been pushed to the Fedora 14 stable repository.


Note You need to log in before you can comment on or make changes to this bug.