Bug 711462 - Review Request: perl-Fedora-Rebuild - Rebuilds Fedora packages from scratch
Summary: Review Request: perl-Fedora-Rebuild - Rebuilds Fedora packages from scratch
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Marcela Mašláňová
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 705361 708371 711472
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-06-07 14:50 UTC by Petr Pisar
Modified: 2011-08-17 01:21 UTC (History)
2 users (show)

Fixed In Version: perl-Fedora-Rebuild-0.8.0-1.fc14
Clone Of:
Environment:
Last Closed: 2011-08-17 01:14:57 UTC
Type: ---
Embargoed:
mmaslano: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Pisar 2011-06-07 14:50:00 UTC
Spec URL: http://ppisar.fedorapeople.org/perl-Fedora-Rebuild/perl-Fedora-Rebuild.spec
SRPM URL: http://ppisar.fedorapeople.org/perl-Fedora-Rebuild/perl-Fedora-Rebuild-0.0.1-1.fc15.src.rpm
Description:
Main goal is to rebuild perl modules packages for Fedora. The rebuild is
driven from bottom to top, i.e. from perl interpreter to modules depending
on intermediate modules. This way, it's possible to upgrade perl
interpreter to incompatible version and to rebuild all modules against the
new interpreter.

Comment 1 Petr Pisar 2011-06-07 15:15:30 UTC
There is bug #711472 in perl-Data-Compare package preventing building this package in Koji.

Comment 2 Petr Pisar 2011-06-07 15:29:59 UTC
perl-RPM-VersionCompare and perl-Proc-SyncExec are only in F16 currently.

Comment 3 Marcela Mašláňová 2011-06-07 15:35:39 UTC
- rpmlint OK
 perl-Fedora-Rebuild.noarch: W: no-manual-page-for-binary getperlsourcenames
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build ?
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK

rpm -q --provides perl-Fedora-Rebuild
perl(Fedora::Rebuild)  
perl(Fedora::Rebuild::Package)  
perl(Fedora::Rebuild::Package::StateLock)  
perl(Fedora::Rebuild::RPM)  
perl(Fedora::Rebuild::Scheduler)  
perl(Fedora::Rebuild::Set::Package)  
perl-Fedora-Rebuild = 0.0.1-1.fc14

rpm -q --requires perl-Fedora-Rebuild
/bin/sh  
/usr/bin/perl  
perl(:MODULE_COMPAT_5.12.3)  
perl(Carp)  
perl(Data::Dumper)  
perl(Fedora::Rebuild)  
perl(Fedora::Rebuild::Package)  
perl(Fedora::Rebuild::Package::StateLock)  
perl(Fedora::Rebuild::RPM)  
perl(Fedora::Rebuild::Scheduler)  
perl(Fedora::Rebuild::Set::Package)  
perl(File::Copy)  
perl(File::Path)  
perl(File::Spec)  
perl(IO::Handle)  
perl(Moose)  
perl(Moose::Util::TypeConstraints)  
perl(MooseX::Types::Moose)  
perl(Proc::SyncExec)  
perl(RPM2)  
perl(RPM::VersionCompare)  
perl(Scalar::Util)  
perl(Thread::Semaphore)  
perl(constant)  
perl(namespace::clean)  
perl(strict)  
perl(threads)  
perl(threads::shared)  
perl(version) >= 0.77
perl(warnings)  
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0

resolvedeps-f16 ../RPMS/noarch/perl-Fedora-Rebuild-0.0.1-1.fc14.noarch.rpm 
Binary dependencies resolvable. Ok.

Only problem -> can't be built in rawhide (problem above).

Comment 4 Petr Pisar 2011-06-08 07:25:51 UTC
I've updated this package to require external tools that are executed from the Perl script (fedpkg etc.) It's available on the same URLs.

Comment 5 Petr Pisar 2011-06-08 07:41:06 UTC
The perl-Data-Compare bug has been fixed in F16 yet.

Comment 6 Marcela Mašláňová 2011-06-08 10:28:04 UTC
Build passed: http://koji.fedoraproject.org/koji/taskinfo?taskID=3118772
APPROVED

Comment 7 Petr Pisar 2011-06-08 13:03:45 UTC
New Package SCM Request
=======================
Package Name: perl-Fedora-Rebuild 
Short Description: Rebuilds Fedora packages from scratch
Owners: ppisar mmaslano psabata
Branches: f14 f15
InitialCC: perl-sig

Comment 8 Gwyn Ciesla 2011-06-08 13:13:40 UTC
Git done (by process-git-requests).

Comment 9 Petr Pisar 2011-06-08 14:39:32 UTC
Thank you for the review and the repository.

F15--14 will follow once dependencies get into buildroot.

Comment 10 Fedora Update System 2011-06-21 07:44:35 UTC
perl-Fedora-Rebuild-0.2.1-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/perl-Fedora-Rebuild-0.2.1-1.fc14

Comment 11 Fedora Update System 2011-06-21 07:44:51 UTC
perl-Fedora-Rebuild-0.2.1-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/perl-Fedora-Rebuild-0.2.1-1.fc15

Comment 12 Fedora Update System 2011-06-21 23:51:42 UTC
perl-Fedora-Rebuild-0.2.1-1.fc14 has been pushed to the Fedora 14 testing repository.

Comment 13 Fedora Update System 2011-07-15 13:15:05 UTC
perl-Fedora-Rebuild-0.5.1-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/perl-Fedora-Rebuild-0.5.1-1.fc15

Comment 14 Fedora Update System 2011-07-15 13:16:08 UTC
perl-Fedora-Rebuild-0.5.1-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/perl-Fedora-Rebuild-0.5.1-1.fc14

Comment 15 Fedora Update System 2011-07-18 15:04:08 UTC
perl-Fedora-Rebuild-0.7.0-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/perl-Fedora-Rebuild-0.7.0-1.fc15

Comment 16 Fedora Update System 2011-07-18 15:04:46 UTC
perl-Fedora-Rebuild-0.7.0-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/perl-Fedora-Rebuild-0.7.0-1.fc14

Comment 17 Fedora Update System 2011-07-20 14:55:24 UTC
perl-Fedora-Rebuild-0.8.0-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/perl-Fedora-Rebuild-0.8.0-1.fc15

Comment 18 Fedora Update System 2011-07-20 14:59:55 UTC
perl-Fedora-Rebuild-0.8.0-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/perl-Fedora-Rebuild-0.8.0-1.fc14

Comment 19 Fedora Update System 2011-08-17 01:14:38 UTC
perl-Fedora-Rebuild-0.8.0-1.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 20 Fedora Update System 2011-08-17 01:21:25 UTC
perl-Fedora-Rebuild-0.8.0-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.