SPEC: http://miroslav.suchy.cz/fedora/java-service-wrapper/java-service-wrapper.spec SRC.RPM: http://miroslav.suchy.cz/fedora/java-service-wrapper/java-service-wrapper-3.2.4-2.20100928hg637f7cc19e33.fc15.src.rpm Description: The Java Service Wrapper enables a Java application to be run as a Unix daemon. It also monitors the health of your application and JVM. Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3088648 rpmlint output: $ rpmlint /home/msuchy/rpmbuild/SRPMS/java-service-wrapper-3.2.4-2.20100928hg637f7cc19e33.fc15.src.rpm /home/msuchy/rpmbuild/RPMS/x86_64/java-service-wrapper-3.2.4-2.20100928hg637f7cc19e33.fc15.x86_64.rpm /home/msuchy/rpmbuild/RPMS/noarch/java-service-wrapper-javadoc-3.2.4-2.20100928hg637f7cc19e33.fc15.noarch.rpm /home/msuchy/rpmbuild/RPMS/x86_64/java-service-wrapper-debuginfo-3.2.4-2.20100928hg637f7cc19e33.fc15.x86_64.rpm java-service-wrapper.src: W: invalid-url Source2: java-service-wrapper-3.2.4-docs.tar.bz2 java-service-wrapper.x86_64: W: no-manual-page-for-binary java-service-wrapper 4 packages and 0 specfiles checked; 0 errors, 2 warnings. First is because Cocoon (which is used for building docs) is not in Fedora. You can create this tar if you build rpm with --with-docs Second is low impact bug, which I have in plan to address after the review (unless reviewer will have different opinion).
> +- add Provides This is not correct, because the package is not compatible with the previous tanukiwrapper package. http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Renaming.2Freplacing_existing_packages > +- removed epoch from BR This is not correct either, because java-javadoc, java, and java-devel-openjdk do have an Epoch set: $ rpm -q --provides java-1.6.0-openjdk java-1.6.0-openjdk-devel java-1.6.0-openjdk-javadoc | grep -E 'java(-javadoc|-devel-openjdk)? =' java = 1:1.6.0 java-devel-openjdk = 1:1.6.0.0 java-javadoc = 1:1.6.0.0-52.1.9.7.fc14 > +- apply patch1 in way, which does not confuse rpmlint This results in modifying files in the build root, which is not okay. The previous way was fine, the rpmlint warning can just be ignored. Note that this has already broken the patch included in the package, comparing my previous package revision with yours (with rpmdev-diff) highlights it: -+ System.load( new File( "@LIBPATH@", file ).toString() ); ++ System.load( new File( "/usr/lib64/java-service-wrapper", file ).toString() ); ...so the /usr/lib64 patch got hardwired in the patch.
(In reply to comment #1) > This results in modifying files in the build root, which is not okay. s/build root/rpm source dir/
> This is not correct, because the package is not compatible with the previous tanukiwrapper package. True. I will remove it. >> +- removed epoch from BR > This is not correct either, because java-javadoc, java, and java-devel-openjdk do have an Epoch set: That is true for openjdk, but not for gjc, which does not have epoch set. With epoch set we effectively enforce use of openjdk. > This results in modifying files in the rpm source dir root, which is not okay. No. It is modified in build root. a) I see nothing wrong on modifying files in buildroot. You can modify what you want there. b) it is build root of binary package, not src.rpm. The build root is removed immediately after building package, so I see no way how it can affect other builds (on different platforms/archs).
(In reply to comment #3) > With epoch set we effectively enforce use of openjdk. In my package that was actually the intention. But I have no problem if you want to support gcj and this stuff works with it. > > This results in modifying files in the rpm source dir root, which is not okay. > No. It is modified in build root. No it isn't, you're using "sed -i -e ... %{PATCH1}" which modifies Patch1 in-place in the source dir (the -i argument). > a) I see nothing wrong on modifying files in buildroot. You can modify what you > want there. That's true. But the file is not modified in the build root, it is modified in the _source dir_, and this is why a modified patch (already sed'd) ended up in your source rpm.
Updated: SRC.RPM: http://miroslav.suchy.cz/fedora/java-service-wrapper/java-service-wrapper-3.2.5-1.fc15.src.rpm SPEC: http://miroslav.suchy.cz/fedora/java-service-wrapper/java-service-wrapper.spec
Looks otherwise fine, but the jnilibpath patch still has /usr/lib64/java-service-wrapper path hardwired (probably due to earlier in-place sed'ing) instead of @LIBPATH@, which quite likely means stuff is broken on non-lib64 archs: $ rpmdev-extract -q java-service-wrapper-3.2.5-1.fc15.src.rpm $ grep usr/lib64 java-service-wrapper-3.2.5-1.fc15.src/java-service-wrapper-3.2.4-jnilibpath.patch + System.load( new File( "/usr/lib64/java-service-wrapper", file ).toString() );
Updated: SRC.RPM: http://miroslav.suchy.cz/fedora/java-service-wrapper/java-service-wrapper-3.2.5-2.fc15.src.rpm SPEC: http://miroslav.suchy.cz/fedora/java-service-wrapper/java-service-wrapper.spec Sorry that it took me so long time.
Looks good now, thanks.
New Package CVS Request ======================= Package Name: java-service-wrapper Short Description: Java service wrapper Owners: msuchy Branches: F-15, EL-5, EL-6 InitialCC:
Git done (by process-git-requests).
Package Change Request ====================== Package Name: java-service-wrapper New Branches: F-16 Owners: msuchy InitialCC: Aghh, F-16 has been already branched! I missed that. So beside F15 and F17, I would need F16.
java-service-wrapper-3.2.5-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/java-service-wrapper-3.2.5-2.fc15
java-service-wrapper-3.2.5-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/java-service-wrapper-3.2.5-2.fc16
java-service-wrapper-3.2.5-3.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/java-service-wrapper-3.2.5-3.el5
java-service-wrapper-3.2.5-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/java-service-wrapper-3.2.5-4.el6
java-service-wrapper-3.2.5-2.fc15 has been pushed to the Fedora 15 stable repository.
java-service-wrapper-3.2.5-5.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/java-service-wrapper-3.2.5-5.el6
java-service-wrapper-3.2.5-5.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/java-service-wrapper-3.2.5-5.el5
java-service-wrapper-3.2.5-2.fc16 has been pushed to the Fedora 16 stable repository.
java-service-wrapper-3.2.5-5.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
java-service-wrapper-3.2.5-5.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.