Spec URL: http://shakthimaan.fedorapeople.org/SPECS/ghc-MonadCatchIO-mtl.spec SRPM URL: http://shakthimaan.fedorapeople.org/SRPMS/ghc-MonadCatchIO-mtl-0.3.0.2-1.fc14.src.rpm Description: Provides a monad-transformer version of the @Control.Exception.catch@ function. For this, it defines the @MonadCatchIO@ class, a subset of @MonadIO@. It defines proper instances for most monad transformers in the 'mtl' library.
$ rpmlint ghc-MonadCatchIO-mtl.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint ghc-MonadCatchIO-mtl-0.3.0.2-1.fc14.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ghc-MonadCatchIO-mtl-0.3.0.2-1.fc14.i686.rpm ghc-MonadCatchIO-mtl.i686: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint ghc-MonadCatchIO-mtl-devel-0.3.0.2-1.fc14.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ghc-MonadCatchIO-mtl-prof-0.3.0.2-1.fc14.i686.rpm ghc-MonadCatchIO-mtl-prof.i686: E: devel-dependency ghc-MonadCatchIO-mtl-devel ghc-MonadCatchIO-mtl-prof.i686: W: no-documentation ghc-MonadCatchIO-mtl-prof.i686: W: devel-file-in-non-devel-package /usr/lib/ghc-6.12.3/MonadCatchIO-mtl-0.3.0.2/libHSMonadCatchIO-mtl-0.3.0.2_p.a 1 packages and 0 specfiles checked; 1 errors, 2 warnings. Successful Koji builds for F-14, F-15 and F-16: http://koji.fedoraproject.org/koji/taskinfo?taskID=3097979 http://koji.fedoraproject.org/koji/taskinfo?taskID=3097982 http://koji.fedoraproject.org/koji/taskinfo?taskID=3097985
*** Bug 630282 has been marked as a duplicate of this bug. ***
Hi Shakthi, Although not mandatory, it will be good to have the BSD license text included in the package. Please email upstream asking for the license file to be included. I will put that in the review. https://fedoraproject.org/wiki/Licensing/BSD#New_BSD_.28no_advertising.2C_3_clause.29
Also, there is no license mentioned in the source file. Its better to ask upstream to include the name of the license at the top of the source file
I have asked upstream to include the BSD3 license as a separate file. Source files (.hs) don't have license mentioned in them.
Upstream has added LICENSE file and released 0.3.0.3. Updated: SPEC: http://shakthimaan.fedorapeople.org/SPECS/ghc-MonadCatchIO-mtl.spec SRPM: http://shakthimaan.fedorapeople.org/SRPMS/ghc-MonadCatchIO-mtl-0.3.0.3-1.fc14.src.rpm $ rpmlint ghc-MonadCatchIO-mtl.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint ghc-MonadCatchIO-mtl-0.3.0.3-1.fc14.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ghc-MonadCatchIO-mtl-0.3.0.3-1.fc14.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ghc-MonadCatchIO-mtl-devel-0.3.0.3-1.fc14.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ghc-MonadCatchIO-mtl-prof-0.3.0.3-1.fc14.i686.rpm ghc-MonadCatchIO-mtl-prof.i686: E: devel-dependency ghc-MonadCatchIO-mtl-devel ghc-MonadCatchIO-mtl-prof.i686: W: no-documentation ghc-MonadCatchIO-mtl-prof.i686: W: devel-file-in-non-devel-package /usr/lib/ghc-6.12.3/MonadCatchIO-mtl-0.3.0.3/libHSMonadCatchIO-mtl-0.3.0.3_p.a 1 packages and 0 specfiles checked; 1 errors, 2 warnings. Successful Koji builds for F-14, F-15, F-16 respectively: http://koji.fedoraproject.org/koji/taskinfo?taskID=3122915 http://koji.fedoraproject.org/koji/taskinfo?taskID=3122905 http://koji.fedoraproject.org/koji/taskinfo?taskID=3122908
Created attachment 504260 [details] Added some deps and upgraded to cabal2spec-0.22.7
[+]MUST: rpmlint must be run on every package. The output should be posted in the review. ghc-MonadCatchIO-mtl-prof.i686: E: devel-dependency ghc-MonadCatchIO-mtl-devel Your package has a dependency on a devel package but it's not a devel package itself. ghc-MonadCatchIO-mtl-prof.i686: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. ghc-MonadCatchIO-mtl-prof.i686: W: devel-file-in-non-devel-package /usr/lib/ghc-7.0.2/MonadCatchIO-mtl-0.3.0.3/libHSMonadCatchIO-mtl-0.3.0.3_p.a A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. 3 packages and 1 specfiles checked; 1 errors, 2 warnings. F16 builds are warning/error free. [+]MUST: The package must be named according to the Package Naming Guidelines. [+]MUST: The spec file name must match the base package %{name}, in the format %{name}.spec [+]MUST: The package must meet the Packaging Guidelines. Naming-Yes Version-release - Matches No prebuilt external bits - OK Spec legibity - OK Package template - OK, attached a patch to update to cabal2spec-0.22.7 Arch support - OK Libexecdir - OK rpmlint - yes changelogs - OK Source url tag - OK, validated. Build Requires list - OK Summary and description - OK API documentation - OK, in devel package [+]MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . Licensed as BSD (3 clause). [+]MUST: The License field in the package spec file must match the actual license. [+]MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. Yes. LICENSE file is included. [+]MUST: The spec file must be written in American English. [+]MUST: The spec file for the package MUST be legible. [+]MUST: The sources used to build the package must match the upstream source,as provided in the spec URL. Reviewers should use md5sum for this task. md5sum MonadCatchIO-mtl-0.3.0.3.tar.gz faf2d7af1f3a2d2bb513316dcefd2606 MonadCatchIO-mtl-0.3.0.3.tar.gz md5sum ghc-MonadCatchIO-mtl-0.3.0.3-1.fc14.src/MonadCatchIO-mtl-0.3.0.3.tar.gz faf2d7af1f3a2d2bb513316dcefd2606 ghc-MonadCatchIO-mtl-0.3.0.3-1.fc14.src/MonadCatchIO-mtl-0.3.0.3.tar.gz [+]MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. Built on x86_64. [+]MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. [+]MUST: All build dependencies must be listed in BuildRequires. [NA]MUST: The spec file MUST handle locales properly using the %find_lang macro [NA]MUST: Packages stores shared library files must call ldconfig in %post and %postun. [+]MUST: Packages must NOT bundle copies of system libraries. checked with rpmquery --list [NA]MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review. [+]MUST: A package must own all directories that it creates. checked with rpmquery --whatprovides [+]MUST: A Fedora package must not list a file more than once in the spec file's %files listings. [+]MUST: Permissions on files must be set properly. Checked with ls -lR [+]MUST: Each package must consistently use macros. [+]MUST: The package must contain code, or permissible content. [+]MUST: Large documentation files must go in a -doc subpackage. [+]MUST: If a package includes something as %doc, it must not affect the runtime of the application. [+]MUST: Header files must be in a -devel package. [NA]MUST: Static libraries must be in a -static package. [NA]MUST: If a package contains library files with a suffix (e.g.libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [+]MUST: devel packages must require the base package using a fully versioned dependency: Requires: {name} = %{version}-%{release} [NA]MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. [NA]MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section [+]MUST: Packages must not own files or directories already owned by other packages. [+]MUST: All filenames in rpm packages must be valid UTF-8. Should items [+]SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Yes LICENSE file is included. [+]SHOULD: The reviewer should test that the package functions as described. Installed the package.Loaded Control.Monad.CatchIO module in ghci. Loads fine. [+]SHOULD: If scriptlets are used, those scriptlets must be sane. cabal2spec-diff is OK. Added patch to upgrade to latest cabal2spec and to explicitly list some dependencies. APPROVED.
Can you please paste here what changes you need in the .spec file? The attachment isn't clear as to what needs to be done. Thanks!
New Package SCM Request ======================= Package Name: ghc-MonadCatchIO-mtl Short Description: Monad-transformer for Control.Exception Owners: shakthimaan Branches: F-14 F-15 F-16 InitialCC: haskell-sig
Created attachment 504262 [details] Added some deps and upgraded to cabal2spec-0.22.7
New Package SCM Request ======================= Package Name: ghc-MonadCatchIO-mtl Short Description: Monad-transformer for Control.Exception Owners: shakthimaan Branches: F-14 F-15 InitialCC: haskell-sig No need to request F-16, since it's rawhide, you get that by default.
Git done (by process-git-requests).
ghc-MonadCatchIO-mtl-0.3.0.3-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/ghc-MonadCatchIO-mtl-0.3.0.3-2.fc15
ghc-MonadCatchIO-mtl-0.3.0.3-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/ghc-MonadCatchIO-mtl-0.3.0.3-2.fc14
ghc-MonadCatchIO-mtl-0.3.0.3-2.fc15 has been pushed to the Fedora 15 testing repository.
ghc-MonadCatchIO-mtl-0.3.0.3-2.fc14 has been pushed to the Fedora 14 stable repository.
ghc-MonadCatchIO-mtl-0.3.0.3-2.fc15 has been pushed to the Fedora 15 stable repository.