Bug 712949 - Review Request: gnome-online-accounts - Provide online accounts information
Summary: Review Request: gnome-online-accounts - Provide online accounts information
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Peter Robinson
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2011-06-13 17:44 UTC by Bastien Nocera
Modified: 2011-06-15 11:27 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2011-06-15 11:27:01 UTC
Type: ---
pbrobinson: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Bastien Nocera 2011-06-13 17:44:40 UTC
Spec URL: http://people.fedoraproject.org/~hadess/gnome-online-accounts/gnome-online-accounts.spec
SRPM URL: http://people.fedoraproject.org/~hadess/gnome-online-accounts/gnome-online-accounts-3.1.0-1.fc15.src.rpm
The gnome-online-accounts-devel package contains libraries and header
files for developing applications that use gnome-online-accounts.

Comment 1 Peter Robinson 2011-06-13 18:12:22 UTC
I'll review this

Comment 2 Peter Robinson 2011-06-13 18:45:26 UTC
These two files need to be in the main package, not in devel.


A few bits that need to be fixed up.

+ rpmlint output

rpmlint gnome-online-accounts-3.1.0-1.fc16.x86_64.rpm gnome-online-accounts-3.1.0-1.fc16.src.rpm gnome-online-accounts-devel-3.1.0-1.fc16.x86_64.rpm gnome-online-accounts.spec 
gnome-online-accounts.x86_64: E: no-ldconfig-symlink /usr/lib64/libgoa-backend-1.0.so.0.0.0
gnome-online-accounts.x86_64: E: no-ldconfig-symlink /usr/lib64/libgoa-1.0.so.0.0.0
gnome-online-accounts.x86_64: E: zero-length /usr/share/doc/gnome-online-accounts-3.1.0/README
gnome-online-accounts-devel.x86_64: W: dangling-relative-symlink /usr/lib64/libgoa-backend-1.0.so.0 libgoa-backend-1.0.so.0.0.0
gnome-online-accounts-devel.x86_64: W: dangling-relative-symlink /usr/lib64/libgoa-1.0.so.0 libgoa-1.0.so.0.0.0
gnome-online-accounts-devel.x86_64: E: incorrect-fsf-address /usr/include/goa-1.0/goabackend/goaeditablelabel.h
3 packages and 1 specfiles checked; 4 errors, 2 warnings.

+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license
+ latest version packaged
- %doc includes license file
  doesn't include COPYING, README can be dropped as its empty
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
  a98926706647d142175a0bcaf0e40fe9  gnome-online-accounts-3.1.0.tar.bz2
+ package successfully builds on at least one architecture
  tested using koji scratch build
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
+ binary RPM with shared library files must call ldconfig in %post and %postun+ does not use Prefix: /usr
n/a package owns all directories it creates
n/a no duplicate files in %files
+ Package perserves timestamps on install
  Permissions on files must be set properly 
- %defattr line
  missing in devel subpackage
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package runtime 
+ header files should be in -devel
n/a static libraries should be in -static
+ packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
+ libfoo.so must go in -devel
+ devel must require the fully versioned base
+ packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ filenames must be valid UTF-8


+ if there is no license file, packager should query upstream to include it
n/a translations of description and summary for non-English languages, if available
+ reviewer should build the package in mock/koji
n/a the package should build into binary RPMs on all supported architectures
n/a review should test the package functions as described
+ scriptlets should be sane
n/a non -devel packages should require fully versioned base
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin
+ Package should have man files

Comment 4 Bastien Nocera 2011-06-14 09:12:31 UTC
-3 contains packages which actually run properly though. Bug fixes are upstream now.

Comment 5 Peter Robinson 2011-06-14 09:20:22 UTC
this is separate from the review but these look like something to be fixed upstream:

rpmlint gnome-on*
gnome-online-accounts.x86_64: E: incorrect-fsf-address /usr/share/doc/gnome-online-accounts-3.1.0/COPYING
gnome-online-accounts-devel.x86_64: E: incorrect-fsf-address /usr/include/goa-1.0/goabackend/goaeditablelabel.h

Comment 6 Peter Robinson 2011-06-14 09:22:22 UTC
Looks fine. APPROVED!

Comment 7 Bastien Nocera 2011-06-14 17:08:29 UTC
New Package SCM Request
Package Name: gnome-online-accounts
Short Description: Provide online accounts information
Owners: hadess davidz

Comment 8 Gwyn Ciesla 2011-06-14 17:25:01 UTC
Git done (by process-git-requests).

Comment 9 Bastien Nocera 2011-06-15 11:27:01 UTC
Done in rawhide.

Note You need to log in before you can comment on or make changes to this bug.