Bug 714937 - Jobs status "Completed" even if it contains "Aborted" recipes
Summary: Jobs status "Completed" even if it contains "Aborted" recipes
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Beaker
Classification: Retired
Component: web UI
Version: 0.6
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: 21.0
Assignee: Dan Callaghan
QA Contact: tools-bugs
URL:
Whiteboard: UX
: 616405 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-06-21 11:25 UTC by Petr Šplíchal
Modified: 2016-08-08 05:00 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-08-26 06:18:05 UTC
Embargoed:


Attachments (Terms of Use)

Description Petr Šplíchal 2011-06-21 11:25:13 UTC
Description of problem:

I guess the overall job status should not be "Completed" if there
are recipes which were aborted or cancelled. Perhaps the "worst"
status from contained recipes should be used here?

Version-Release number of selected component (if applicable):
0.6.13 

Steps to Reproduce:
https://beaker.engineering.redhat.com/jobs/92248

Comment 1 Dan Callaghan 2012-10-31 06:35:16 UTC
This is by design. We show the "most severe" result (Panic > Fail > Warn > Pass) but the "least severe" status. That way, if one recipe is Running but another is still Queued, the overall status will show Queued.

I think if we only had status Finished, it would make sense as ist. The problem is that we have three finished statuses: Cancelled, Aborted, and Completed. Which is kind of expressing a result, as well as a status, but that's what we have...

Comment 2 Dan Callaghan 2012-10-31 07:28:16 UTC
On second thought, I suppose there is no reason we couldn't change the "severity" such that Aborted < Cancelled < Completed ("severity" is surely the wrong word to use here), apart from the fact that it would change the behaviour which might surprise people.

Comment 5 Dan Callaghan 2015-02-24 05:33:20 UTC
I was thinking about this again. I think it is worth changing the status calculations so that Aborted < Cancelled < Completed (where lower status "wins"). In other words, a recipe with some Completed tasks and some Aborted would be Aborted, not Completed as it is now. Similarly, a recipe with some Completed tasks and some Cancelled would be Cancelled, not Completed as it is now. The current behaviour is very counter-intuitive and not really useful for 

This would handily also fix bug 1195558.

This would be a backwards incompatible change but I don't think there is anything we can do about it aside from adding a release note to draw people's attention to it.

Comment 6 Bill Peck 2015-02-24 14:34:37 UTC
+1 I think this would be a good change.

Comment 7 Dan Callaghan 2015-04-24 04:05:49 UTC
http://gerrit.beaker-project.org/4189

Comment 8 Marian Csontos 2015-05-05 06:40:39 UTC
*** Bug 1217472 has been marked as a duplicate of this bug. ***

Comment 11 Dan Callaghan 2015-08-26 06:18:05 UTC
Beaker 21.0 has been released.

Comment 12 Dan Callaghan 2016-08-08 05:00:07 UTC
*** Bug 616405 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.