Bug 714940 - URL Validation required while adding new deployable
Summary: URL Validation required while adding new deployable
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: CloudForms Cloud Engine
Classification: Retired
Component: aeolus-conductor
Version: 0.3.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
Assignee: Jiri Tomasek
QA Contact: wes hayutin
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-06-21 11:40 UTC by Aziza Karol
Modified: 2012-01-26 12:20 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:


Attachments (Terms of Use)

Description Aziza Karol 2011-06-21 11:40:34 UTC
Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.From control panels, select suggested deployable
2.click on New Deployable.
3.In URL section enter invalid values and save.

It saves invalid URL values.


  
Actual results:


Expected results:
Validation required for URL Field.

Additional info:
[root@nec-em19 aeolus-configure]# rpm -qa  | grep aeolus
rubygem-aeolus-cli-0.0.1-1.fc14.20110620142346git1c969a7.noarch
aeolus-conductor-doc-0.3.0-0.fc14.20110620142346git1c969a7.noarch
aeolus-conductor-daemons-0.3.0-0.fc14.20110620142346git1c969a7.noarch
aeolus-conductor-0.3.0-0.fc14.20110620142346git1c969a7.noarch
aeolus-all-0.3.0-0.fc14.20110620142346git1c969a7.noarch
aeolus-configure-2.0.1-0.fc14.20110602110128git5cb9257.noarch

Comment 1 wes hayutin 2011-06-21 13:20:46 UTC
I dont think validation for this url is in scope for this iteration.
Checking w/ athomas, however I think this bug may be closed in an effort to reduce stale bugs.

Comment 2 Angus Thomas 2011-06-21 13:39:59 UTC
Given that the deployable definition XML is hosted externally, it isn't possible for Conductor to ensure the validity of the URLs that are entered, so it should be possible for an administrator to add a URL which doesn't correctly resolve to a valid XML file *at the time that they enter it*.

As a feature, we should add a warning when the URL doesn't resolve to an XML file, but the user should still be allowed to save the URL.

Comment 3 Angus Thomas 2011-06-21 13:42:28 UTC
Added a feature to the product backlog: https://www.aeolusproject.org/redmine/issues/1830 - "When admin is adding new suggested deployables, warn if the URL they enter doesn't resolve to a valid XML file"

Comment 4 Shveta 2011-06-22 10:22:05 UTC
Please also provide an example of URL expected , a new user might not be sure of what is expected in URL .

It can be there in the help section or in brackets in the same page .
A note might also do ...

Comment 5 wes hayutin 2011-06-30 02:53:11 UTC
*** Bug 717792 has been marked as a duplicate of this bug. ***

Comment 6 Jiri Tomasek 2011-07-07 09:20:02 UTC
bug fixed in commit 65ca9f4c32072ea64a33a00a2791447621587e1f

Comment 7 Shveta 2011-07-12 12:12:35 UTC
Verified

    * Deployable added

Warnings

    * Deployable url doesn't resolve valid XML file

Comment 8 wes hayutin 2011-08-01 20:02:03 UTC
release pending...

Comment 9 wes hayutin 2011-08-01 20:02:20 UTC
release pending 3

Comment 10 wes hayutin 2011-08-01 20:02:20 UTC
release pending...

Comment 11 wes hayutin 2011-08-01 20:02:32 UTC
release pending.. 2

Comment 13 wes hayutin 2011-12-08 14:04:30 UTC
closing out old bugs

Comment 14 wes hayutin 2011-12-08 14:16:13 UTC
perm close


Note You need to log in before you can comment on or make changes to this bug.