Hide Forgot
Description of problem: In cases where tunegfs2 should exit instead of working on a device it prints out an error instead 1. No device specified: # tunegfs2 Unable to open device (null) 2. List help options # tunegfs2 -h Usage: tunegfs2 -L <volume label> -U <UUID> -l -o <mount options> <device> Unable to open device (null) 3. Print version number # tunegfs2 -V tunegfs2 (Jun 23 2011 05:03:50) Unable to open device (null) Version-Release number of selected component (if applicable): gfs2-utils-3.0.12.1-5.el6.x86_64 How reproducible: Every time Steps to Reproduce: 1. tunegfs2 2. tunegfs2 -h 3. tunegfs2 -V Actual results: See above Expected results: # tunegfs2 Usage: tunegfs2 -L <volume label> -U <UUID> -l -o <mount options> <device> # tunegfs2 -h Usage: tunegfs2 -L <volume label> -U <UUID> -l -o <mount options> <device> # tunegfs2 -V tunegfs2 (Jun 23 2011 05:03:50) Additional info:
Harmless aside from the message, so not a high priority.
Created attachment 513201 [details] Upstream patch
Created attachment 515112 [details] Patch for RHEL6 This is the upstream patch with the parts specific to bz#719126 discarded.
Patch is now in RHEL6 branch of cluster.git
https://brewweb.devel.redhat.com/buildinfo?buildID=173797
Testing with gfs2-utils-3.0.12.1-7.el6.x86_64.rpm: # tunegfs2 Incorrect number of arguments Usage: tunegfs2 [-hlV] [-L <volume_label>] [-U <UUID>] [-o <mount_options>] <device> # tunegfs2 -h Usage: tunegfs2 [-hlV] [-L <volume_label>] [-U <UUID>] [-o <mount_options>] <device> # tunegfs2 -V tunegfs2 (Jul 26 2011 10:11:28)
Technical note added. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. New Contents: Cause: Some argument validation functions were not returning error values Consequence: tunegfs2 would needlessly print confusing error messages instead of exiting quietly Fix: Error handling was improved in these validation functions Result: tunegfs2 now exits quietly instead of printing the confusing error messages
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2011-1516.html