RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 720979 - do not use next as a variable name in qemu-kvm systemtap tapset
Summary: do not use next as a variable name in qemu-kvm systemtap tapset
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: qemu-kvm
Version: 6.1
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: rc
: ---
Assignee: Gerd Hoffmann
QA Contact: Virtualization Bugs
URL:
Whiteboard:
: 729950 (view as bug list)
Depends On:
Blocks: 798676
TreeView+ depends on / blocked
 
Reported: 2011-07-13 12:15 UTC by Lubos Kocman
Modified: 2013-01-10 00:04 UTC (History)
7 users (show)

Fixed In Version: qemu-kvm-0.12.1.2-2.181.el6
Doc Type: Bug Fix
Doc Text:
Bug wasn't present in any released version.
Clone Of:
: 798676 (view as bug list)
Environment:
Last Closed: 2011-12-06 15:53:28 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
stap script that I've used (1.27 KB, application/octet-stream)
2011-07-13 12:15 UTC, Lubos Kocman 		no flags Details
proposed patch (1.02 KB, patch)
2011-07-13 12:16 UTC, Lubos Kocman 		no flags Details | Diff
proposed patch for tapset (1.02 KB, patch)
2011-07-13 12:20 UTC, Lubos Kocman 		no flags Details | Diff
Show Obsolete (1) View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2011:1531 0 normal SHIPPED_LIVE Moderate: qemu-kvm security, bug fix, and enhancement update 2011-12-06 01:23:30 UTC

Description Lubos Kocman 2011-07-13 12:15:37 UTC 
Created attachment 512650 [details]
stap script that I've used

Description of problem:

I got error following tapset errror with qemu-kvm.stp output while probing some spice-client related functions

Version-Release number of selected component (if applicable):

qemu-kvm-0.12.1.2-2.169.el6.x86_64

How reproducible:


Steps to Reproduce:
1. stap stream.stp
  
Actual results:

bash-4.1$ ls
stream.stp
bash-4.1$ sudo stap stream.stp 
parse error: expected literal string or number
	saw: operator '=' at /usr/share/systemtap/tapset/qemu-kvm.stp:260:8
     source:   next = $arg3;
                    ^
parse error: expected literal string or number
	saw: operator '=' at /usr/share/systemtap/tapset/qemu-kvm.stp:289:8
     source:   next = $arg3;
                    ^
parse error: expected literal string or number
	saw: operator '=' at /usr/share/systemtap/tapset/qemu-kvm.stp:315:8
     source:   next = $arg2;
                    ^
3 parse error(s).
WARNING: tapset '/usr/share/systemtap/tapset/qemu-kvm.stp' has errors, and will be skipped.
Catching stream events. Press Ctrl+c to exit.
^C
SUMMARY (n-called functions)
-------------------------------------------
|  handle_stream_create(): 0 
|  handle_stream_destroy(): 0 
|  handle_stream_update(): 0 
-------------------------------------------


Expected results:

no parse errors in qemu-kvm tapset

Additional info:

see proposed patch that works for me (not sure how it affects scripts that are relying on it) but since next is probably a reserved keyword and it's not usable anyway there shouldn't be any actual impact right?
Comment 1 Lubos Kocman 2011-07-13 12:16:25 UTC 
Created attachment 512651 [details]
proposed patch

diff -crB /usr/share/systemtap/tapset/qemu-kvm.stp  ~/qemu-kvm.stp > ~/proposed_patch
Comment 2 Lubos Kocman 2011-07-13 12:20:05 UTC 
Created attachment 512652 [details]
proposed patch for tapset
Comment 3 Jes Sorensen 2011-07-18 14:35:10 UTC 
Lubos,

Note that you are proposing a patch to an automatically generated file,
so it won't solve the problem.

In addition please use unified diff for patches (diff -u).

The problematic trace points seem to have come from the addition
of the ehci patches, which were Gerd Kraxel's patches, so reassigning
to him.

Jes
Comment 4 Gerd Hoffmann 2011-07-20 15:44:58 UTC 
http://patchwork.ozlabs.org/patch/105747/
Comment 6 Amit Shah 2011-08-12 07:05:47 UTC 
*** Bug 729950 has been marked as a duplicate of this bug. ***
Comment 10 juzhang 2011-08-31 10:05:34 UTC 
Reproduce this issue with qemu-kvm-0.12.1.2-2.180.el6

steps
1.cat memory.stp 
probe qemu.kvm.qemu_malloc
{
   printf("size = %p,  ptr =%u ",size,ptr);
  
}

2.stap memory.stp


Results:
stap memory.stp
parse error: expected literal string or number
	saw: operator '=' at /usr/share/systemtap/tapset/qemu-kvm.stp:260:8
     source:   next = $arg3;
                    ^
parse error: expected literal string or number
	saw: operator '=' at /usr/share/systemtap/tapset/qemu-kvm.stp:289:8
     source:   next = $arg3;
                    ^
parse error: expected literal string or number
	saw: operator '=' at /usr/share/systemtap/tapset/qemu-kvm.stp:315:8
     source:   next = $arg2;
                    ^
3 parse errors.
WARNING: tapset '/usr/share/systemtap/tapset/qemu-kvm.stp' has errors, and will be skipped.
semantic error: probe point mismatch at position 0  (alternatives: __nfs __scheduler __signal __tcpmib __vm _linuxmib _signal _sunrpc _syscall _vfs begin begin(number) end end(number) error error(number) generic ioblock ioblock_trace ioscheduler ioscheduler_trace ipmib irq_handler kernel kprobe kprocess libvirt linuxmib module(string) nd_syscall netdev never nfs nfsd perf process process(number) process(string) procfs procfs(string) python scheduler scsi signal socket softirq stap staprun sunrpc syscall tcp tcpmib timer tty udp vfs vm workqueue): identifier 'qemu' at memory.stp:1:7 while resolving probe point qemu.kvm.qemu_malloc
        source: probe qemu.kvm.qemu_malloc
                      ^
Pass 2: analysis failed.  Try again with another '--vp 01' option.


Verified this issue with qemu-kvm-0.12.1.2-2.184.el6

steps
1. cat memory.stp 
probe qemu.kvm.qemu_malloc
{
   printf("size = %p,  ptr =%u ",size,ptr);
  
}

2.stap memory.stp

3. boot guest

Resutls:
ptr =31110576 size = 0xc050,  ptr =43610576 size = 0xc050,  ptr =43561328 size = 0x10,  ptr =32583648 size = 0xc050,  ptr =43610576 size = 0xc050,  ptr =43561328 size = 0x10,  ptr =30978528 size = 0xc050,  ptr =43610576 size = 0xc050,  ptr =43561328 size = 0x10,  ptr =32313184 size = 0xc050,  ptr =43610576 size = 0xc050,  ptr =43561328 size = 0x10,  ptr =31110576 size = 0xc050,  ptr =43610576 size = 0xc050,  ptr =43561328 size = 0x10,  ptr =32583648 size = 0xc050,  ptr =43610576 size = 0xc050,  ptr =43561328 size = 0x10,  ptr =30978528 size = 0xc050,  ptr =43610576 size = 0xc050,  ptr =43561328 size = 0x10,  ptr =32313184 size = 0xc050,  ptr =43610576 size = 0xc050,  ptr =43561328 size = 0x10,  ptr =31110576 size = 0xc050,  ptr =43610576 size = 0xc050,  ptr =43561328 size = 0x10,  ptr =32583648 size = 0xc050,  ptr =43610576 size = 0xc050

This issue has been fixed.
Comment 12 Gerd Hoffmann 2011-11-18 16:23:15 UTC 
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Bug wasn't present in any released version.
Comment 13 errata-xmlrpc 2011-12-06 15:53:28 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2011-1531.html
Note You need to log in before you can comment on or make changes to this bug.