Bug 723427 - Review Request: jinput - Java Game Controller API
Summary: Review Request: jinput - Java Game Controller API
Keywords:
Status: CLOSED DUPLICATE of bug 790172
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 723125
Blocks: 723779
TreeView+ depends on / blocked
 
Reported: 2011-07-20 06:47 UTC by Guido Grazioli
Modified: 2012-02-14 06:36 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-02-13 20:15:40 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Patch to update the <linux/input.h> interface (15.94 KB, patch)
2011-08-01 20:44 UTC, Jerry James
no flags Details | Diff

Description Guido Grazioli 2011-07-20 06:47:39 UTC
Spec URL: 
http://guidograzioli.fedorapeople.org/packages/jinput/jinput.spec
SRPM URL: 
http://guidograzioli.fedorapeople.org/packages/jinput/jinput-2.0.6-1.20110719svn.fc16.src.rpm
Description: 
jinput is an implementation of an API for game controller discovery and polled
input. It is part of a suite of open-source technologies initiated by the
Game Technology Group at Sun Microsystems with intention of making the
development of high performance games in Java a reality.
The API itself is pure Java and presents a platform-neutral completely
portable model of controller discovery and polling. It can handle arbitrary
controllers and returns both human and machine understandable descriptions of
the inputs available.

Comment 1 Jerry James 2011-07-29 19:32:37 UTC
This package suffers from this bug:

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=633501

I see the same compiler warning and the same undefined symbol when building in Rawhide.

Comment 2 Jerry James 2011-08-01 20:44:23 UTC
Created attachment 516209 [details]
Patch to update the <linux/input.h> interface

FWIW, one fix is to change line 116 of plugins/linux/src/native/net_java_games_input_LinuxEventDevice.c from:

#if EV_VERSION >= 0x010001

to:

#ifdef EVIOCGUSAGE

But I think that fix is insufficient.  Note that plugins/linux/src/java/net/java/games/input/NativeDefinitions.java is out of sync with /usr/include/linux/input.h, and regenerating it (with "ant -f plugins/linux/src/native/build.xml createNativeDefinitions.java") causes Java compilation to fail due to appearances of USAGE_* constants that no longer exist in <linux/input.h>.  I think that NativeDefinitions.java should be regenerated, and all mention of the USAGE stuff should be ripped out, as in the attached patch.

Comment 3 Guido Grazioli 2011-08-01 22:15:51 UTC
Thanks for the info. USAGE constants must have been in the kernel headers for a very short time around kernel 2.6.18, i'm probably going to strip away any reference to them. When I saw the tests run successfully during the build I thought that bug was fixed upstream in trunk.

I dont actually see a point in regenerating NativeDefinitions, as even if that file is regenerated, there's code that's built up on that version of the definitions.

Comment 4 Stanislav Ochotnicky 2011-09-23 14:12:52 UTC
I can do the review of this. Do you want to first cleanup those issues with ifdefs or should I start?

Comment 5 Guido Grazioli 2011-09-24 02:09:53 UTC
Thanks Stanislav, the clean up discussed above is definitely needed; please stand by for an updated package.

Comment 6 Jerry James 2011-11-12 22:58:59 UTC
Guido, can you give us an update on the status of this submission?

Comment 7 Jerry James 2011-12-09 19:50:50 UTC
Ping.

Comment 8 Guido Grazioli 2011-12-10 12:25:15 UTC
Hello Jerry I have very little time atm to dedicate to this package and lwjgl, and wont get any more till mid January. We can consider this review request stalled, if nobody else would like to jump on it before.

Comment 9 Jerry James 2012-02-02 21:37:21 UTC
Well, I waited awhile for you anyway. :-)  I have a package waiting for review that uses jinput, which explains my interest.  If you haven't got time to move this forward, then may I hijack this review?  Here's what I've done:

http://jjames.fedorapeople.org/jinput/jinput.spec
http://jjames.fedorapeople.org/jinput/jinput-2.0.6-1.20110801svn.fc16.src.rpm

If you're okay with that ... what?  Do I have to open a new bug, or can we keep using this one?

Comment 10 Guido Grazioli 2012-02-05 22:23:55 UTC
Hello Jerry, I think you need to open a new review request bug, then close this one as a duplicate; please do it, just dont forget lwjgl as a dependent bug.

Comment 11 Jerry James 2012-02-13 20:15:40 UTC
Okay, I think I got it all.  Poke me if I missed anything.

*** This bug has been marked as a duplicate of bug 790172 ***


Note You need to log in before you can comment on or make changes to this bug.