Bug 790172 - Review Request: jinput - Java Game Controller API
Summary: Review Request: jinput - Java Game Controller API
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Andrew Robinson
QA Contact: Fedora Extras Quality Assurance
: 723427 (view as bug list)
Depends On:
Blocks: 723779
TreeView+ depends on / blocked
Reported: 2012-02-13 20:12 UTC by Jerry James
Modified: 2012-03-17 23:53 UTC (History)
5 users (show)

Fixed In Version: jinput-2.0.6-1.20110801svn.fc16
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2012-03-09 04:52:55 UTC
Type: ---
andjrobins: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Jerry James 2012-02-13 20:12:00 UTC
Spec URL: http://jjames.fedorapeople.org/jinput/jinput.spec
SRPM URL: http://jjames.fedorapeople.org/jinput/jinput-2.0.6-1.20110801svn.fc16.src.rpm
Description: jinput is an implementation of an API for game controller discovery and polled input.  It is part of a suite of open-source technologies initiated by the Game Technology Group at Sun Microsystems with intention of making the development of high performance games in Java a reality.  The API itself is pure Java and presents a platform-neutral completely portable model of controller discovery and polling.  It can handle arbitrary controllers and returns both human and machine understandable descriptions of the inputs available.

Comment 1 Jerry James 2012-02-13 20:15:40 UTC
*** Bug 723427 has been marked as a duplicate of this bug. ***

Comment 2 Andrew Robinson 2012-02-28 14:57:35 UTC
I'll take a look at this.

Comment 3 Andrew Robinson 2012-02-29 21:04:54 UTC
Package Review

- = N/A
x = Check
! = Problem
? = Not evaluated

[X]  Rpmlint output: 
jinput.src: W: invalid-url Source0: jinput-2.0.6.tar.xz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

1 packages and 0 specfiles checked; 0 errors, 1 warnings.
[X]  Package is named according to the Package Naming Guidelines[1].
[X]  Spec file name must match the base package name, in the format %{name}.spec.
[X]  Package meets the Packaging Guidelines[2].
[X]  Package successfully compiles and builds into binary rpms.
[X]  Buildroot definition is not present
[X]  Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4].
[X]  License field in the package spec file matches the actual license.
License type: BSD
[-]  If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.
[X]  All independent sub-packages have license of their own
[X]  Spec file is legible and written in American English.
[X]  Sources used to build the package matches the upstream source, as provided in the spec URL.
MD5SUM this package    : da6176a38e76e0b0cbc974f469e7a77e
MD5SUM upstream package: 4e24040fc709094db9f512d0ed400236
But recursive diff of untarred source shows no results.
[?]  All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5].
[X]  Package must own all directories that it creates or must require other packages for directories it uses.
[X]  Package does not contain duplicates in %files.
[X]  File sections do not contain %defattr(-,root,root,-) unless changed with good reason
[X]  Permissions on files are set properly.
[X]  Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore)
[X]  Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing)
[X]  Package contains code, or permissable content.
[-]  Fully versioned dependency in subpackages, if present.
[-]  Package contains a properly installed %{name}.desktop file if it is a GUI application.
[X]  Package does not own files or directories owned by other packages.
[X]  Javadoc documentation files are generated and included in -javadoc subpackage
[X]  Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[X]  Packages have proper BuildRequires/Requires on jpackage-utils
[X]  Javadoc subpackages have Require: jpackage-utils
[-]  Package uses %global not %define
[X]  If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...)
[X]  If source tarball includes bundled jar/class files these need to be removed prior to building
[X]  All filenames in rpm packages must be valid UTF-8.
[X]  Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[-]  If package contains pom.xml files install it (including depmaps) even when building with ant
[X]  pom files has correct add_maven_depmap

=== Maven ===
[X]  Use %{_mavenpomdir} macro for placing pom files instead of %{_datadir}/maven2/poms
[-]  If package uses "-Dmaven.test.skip=true" explain why it was needed in a comment
[-]  If package uses custom depmap "-Dmaven.local.depmap.file=*" explain why it's needed in a comment
[X]  Package DOES NOT use %update_maven_depmap in %post/%postun
[X]  Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-utils for %update_maven_depmap macro

=== Other suggestions ===
[X]  If possible use upstream build method (maven/ant/javac)
[X]  Avoid having BuildRequires on exact NVR unless necessary
[X]  Package has BuildArch: noarch (if possible)
[X]  Latest version is packaged.
[X]  Reviewer should test that the package builds in mock.
Tested on: x86_64, ix86

*** APPROVED ***

[1] https://fedoraproject.org/wiki/Packaging:NamingGuidelines
[2] https://fedoraproject.org/wiki/Packaging:Guidelines
[3] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines
[4] https://fedoraproject.org/wiki/Licensing:Main
[5] https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 
[6] https://fedoraproject.org/wiki/Packaging:Java#Filenames

Comment 4 Jerry James 2012-03-01 21:48:18 UTC
Thank you for the review, Andrew.

New Package SCM Request
Package Name: jinput
Short Description: Java Game Controller API
Owners: jjames
Branches: f16 f17

Comment 5 Gwyn Ciesla 2012-03-02 02:20:30 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2012-03-02 16:20:32 UTC
jinput-2.0.6-1.20110801svn.fc17 has been submitted as an update for Fedora 17.

Comment 7 Fedora Update System 2012-03-02 16:20:42 UTC
jinput-2.0.6-1.20110801svn.fc16 has been submitted as an update for Fedora 16.

Comment 8 Fedora Update System 2012-03-05 20:58:48 UTC
jinput-2.0.6-1.20110801svn.fc17 has been pushed to the Fedora 17 testing repository.

Comment 9 Fedora Update System 2012-03-09 04:52:55 UTC
jinput-2.0.6-1.20110801svn.fc17 has been pushed to the Fedora 17 stable repository.

Comment 10 Fedora Update System 2012-03-17 23:53:34 UTC
jinput-2.0.6-1.20110801svn.fc16 has been pushed to the Fedora 16 stable repository.

Note You need to log in before you can comment on or make changes to this bug.