Bug 726440

Description of problem:
A side affect of commit https://bugzilla.redhat.com/show_bug.cgi?id=722248#c1 is that on a bare metal host machine, the fact for virt.host_type is getting set to "Unknown" when the the value of "" returned from virt-what is actually a good value implying that this is NOT a virtual guest.  (see man virt-what)

On a bare metal machine prior to commit https://bugzilla.redhat.com/show_bug.cgi?id=722248#c1 ...


# subscription-manager facts --list | egrep "virt\."
virt.host_type: 
virt.is_guest: False

^^^ These results were correct


On a bare metal machine after commit https://bugzilla.redhat.com/show_bug.cgi?id=722248#c1 ...

# subscription-manager facts --list | egrep "virt\."
virt.host_type: Unknown
virt.is_guest: False

^^^ These results are wrong


I beleive the best fix for this bug is to make the following code change to hwprobe.py:


277     def getVirtInfo(self):
278         virt_dict = {}
279 
280         try:
281             host_type = self._get_output('virt-what')
282             virt_dict['virt.host_type'] = host_type
283             # If this is blank, then not a guest
284             virt_dict['virt.is_guest'] = bool(host_type)
285 #jsefler suggests these 2 lines as a fix for this bug
286             if host_type == "":
287                 virt_dict['virt.host_type'] = "Not Applicable"
288         # TODO:  Should this only catch OSErrors?
289         except:
290             # Otherwise there was an error running virt-what - who knows
291             virt_dict['virt.is_guest'] = 'Unknown'
292 
293         self.allhw.update(virt_dict)
294         return virt_dict


On a bare metal machine after jsefler's suggested fix ...

# subscription-manager facts --list | egrep "virt\."
virt.host_type: Not Applicable
virt.is_guest: False



NOTE: this fix is also translated to the subscription-manager-gui facts

Version-Release number of selected component (if applicable):
[root@jsefler-onprem-62server sbin]# rpm -q subscription-manager
subscription-manager-0.96.4-1.git.66.43ed963.el6.x86_64