Note: This bug is displayed in read-only format because
the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Description of problem:
That's doc issue, snapshot-create-as should be followed by --diskspec to introduce the arguments, rather than follow <diskspec> directly.
Version-Release number of selected component (if applicable):
libvirt-0.9.4-11.el6.x86_64
How reproducible:
always
Steps to Reproduce:
# virsh help snapshot-create-as
NAME
snapshot-create-as - Create a snapshot from a set of args
SYNOPSIS
snapshot-create-as <domain> [<name>] [<description>] [--print-xml] [--no-metadata] [--halt] [--disk-only] [<diskspec>]...
DESCRIPTION
Create a snapshot (disk and RAM) from arguments
OPTIONS
[--domain] <string> domain name, id or uuid
[--name] <string> name of snapshot
[--description] <string> description of snapshot
--print-xml print XML document rather than create
--no-metadata take snapshot but create no metadata
--halt halt domain after snapshot is created
--disk-only capture disk state but not vm state
<diskspec> disk attributes: disk[,snapshot=type][,driver=type][,file=name]
Actual results:
SYNOPSIS
snapshot-create-as <domain> [<name>] [<description>] [--print-xml] [--no-metadata] [--halt] [--disk-only] [<diskspec>]...
OPTIONS
<diskspec> disk attributes: disk[,snapshot=type][,driver=type][,file=name]
Expected results:
SYNOPSIS
snapshot-create-as <domain> [<name>] [<description>] [--print-xml] [--no-metadata] [--halt] [--disk-only] [--diskspec]...
OPTIONS
--diskspec <string> disk attributes: disk[,snapshot=type][,driver=type][,file=name]
Additional info:
(In reply to comment #0)
> Description of problem:
> That's doc issue, snapshot-create-as should be followed by --diskspec to
> introduce the arguments, rather than follow <diskspec> directly.
Not quite true. The '--diskspec' option is mandatory if you do not have all three of domain, name, and description already provided, but if all three are present, then you can skip the option name for diskspec as well.
$ tools/virsh -c test:///default snapshot-create-as --print-xml test name desc vda
<domainsnapshot>
<name>name</name>
<description>desc</description>
<disks>
<disk name='vda'/>
</disks>
</domainsnapshot>
>
> OPTIONS
> [--domain] <string> domain name, id or uuid
> [--name] <string> name of snapshot
> [--description] <string> description of snapshot
> --print-xml print XML document rather than create
> --no-metadata take snapshot but create no metadata
> --halt halt domain after snapshot is created
> --disk-only capture disk state but not vm state
> <diskspec> disk attributes:
However, I agree that this is a bit confusing, and might look better as [--diskspec] <diskspec> in the 'virsh help' output, and as '[[/--diskspec/] *diskspec*]...' (with // for italic and ** for bold) in the 'man virsh' section.
I'll reply more to your proposed upstream patch with my counter proposals:
https://www.redhat.com/archives/libvir-list/2011-September/msg00543.html
tested with
libvirt-0.9.4-12.el6.x86_64
Steps:
# virsh help snapshot-create-as
SYNOPSIS
snapshot-create-as <domain> [<name>] [<description>] [--print-xml]
[--no-metadata] [--halt] [--disk-only] [--diskspec]...
OPTIONS
--diskspec <string> disk attributes:
disk[,snapshot=type][,driver=type][,file=name]
Get expected result, so set bug status to VERIFIED
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.
http://rhn.redhat.com/errata/RHBA-2011-1513.html
Description of problem: That's doc issue, snapshot-create-as should be followed by --diskspec to introduce the arguments, rather than follow <diskspec> directly. Version-Release number of selected component (if applicable): libvirt-0.9.4-11.el6.x86_64 How reproducible: always Steps to Reproduce: # virsh help snapshot-create-as NAME snapshot-create-as - Create a snapshot from a set of args SYNOPSIS snapshot-create-as <domain> [<name>] [<description>] [--print-xml] [--no-metadata] [--halt] [--disk-only] [<diskspec>]... DESCRIPTION Create a snapshot (disk and RAM) from arguments OPTIONS [--domain] <string> domain name, id or uuid [--name] <string> name of snapshot [--description] <string> description of snapshot --print-xml print XML document rather than create --no-metadata take snapshot but create no metadata --halt halt domain after snapshot is created --disk-only capture disk state but not vm state <diskspec> disk attributes: disk[,snapshot=type][,driver=type][,file=name] Actual results: SYNOPSIS snapshot-create-as <domain> [<name>] [<description>] [--print-xml] [--no-metadata] [--halt] [--disk-only] [<diskspec>]... OPTIONS <diskspec> disk attributes: disk[,snapshot=type][,driver=type][,file=name] Expected results: SYNOPSIS snapshot-create-as <domain> [<name>] [<description>] [--print-xml] [--no-metadata] [--halt] [--disk-only] [--diskspec]... OPTIONS --diskspec <string> disk attributes: disk[,snapshot=type][,driver=type][,file=name] Additional info: