Spec URL: http://mtasaka.fedorapeople.org/Review_request/mcomix/mcomix.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/mcomix/mcomix-0.94-1.fc.src.rpm Description: MComix is a user-friendly, customizable image viewer. It is specifically designed to handle comic books, but also serves as a generic viewer. It reads images in ZIP, RAR, 7Zip or tar archives as well as plain image files. It is written in Python and uses GTK+ through the PyGTK bindings. scratch build: f17: http://koji.fedoraproject.org/koji/taskinfo?taskID=3417265 f16: http://koji.fedoraproject.org/koji/taskinfo?taskID=3417266 f15: http://koji.fedoraproject.org/koji/taskinfo?taskID=3417268
In progress.
rpmlint: mcomix.src: W: spelling-error Summary(en_US) customizable -> customization The value of this tag appears to be misspelled. Please double-check. mcomix.src: W: spelling-error %description -l en_US customizable -> customization The value of this tag appears to be misspelled. Please double-check. Ignore. mcomix.src: W: strange-permission mcomix-0.94.tar.bz2 0600L A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. mcomix.src: W: strange-permission mcomix.spec 0600L A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. mcomix.src: W: strange-permission mcomix-0.92-fedora-rpmbuild-gtk.patch 0600L A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. Fix. mcomix.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/mcomix/mcomixstarter.py 0644L /usr/bin/env This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. Patch out the shebang. mcomix.noarch: W: non-conffile-in-etc /etc/gconf/schemas/mcomix.schemas A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file. I believe this can be ignored. mcomix.noarch: W: dangerous-command-in-%pre rm mcomix.noarch: W: dangerous-command-in-%post rm This as well. - package meets naming guidelines - package meets packaging guidelines - license ( GPLv2 ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file So. . . just the shebang and SRPM file permissions.
Thank you for comments. http://mtasaka.fedorapeople.org/Review_request/mcomix/mcomix-0.94-2.fc.src.rpm http://mtasaka.fedorapeople.org/Review_request/mcomix/mcomix.spec * Thu Oct 27 2011 Mamoru Tasaka <mtasaka> - 0.94-2 - Fix rpmlint issue
Excellent, APPROVED.
Thank you! New Package SCM Request ======================= Package Name: mcomix Short Description: User-friendly, customizable image viewer for comic books Owners: mtasaka Branches: f16 f15 InitialCC:
Git done (by process-git-requests).
Rebuilt successfully for F17/16/15, push requests submitted for F16/15. Thank you for the review and SCM procedure. Closing.