Spec URL: http://labs.linuxnetz.de/bugzilla/clucene09.spec SRPM URL: http://labs.linuxnetz.de/bugzilla/clucene09-0.9.21b-1.src.rpm Description: CLucene is a C++ port of Lucene. It is a high-performance, full- featured text search engine written in C++. CLucene is faster than lucene as it is written in C++. This package contains an old and deprecated version of clucene. You need it only if the software you are using has not been updated to work with the newer version and the newer API. This package is meant as a compatibility package for Fedora 16+ and RHEL 7+, because the up-to-date clucene-2.3.3.4-1 breaks API and ABI compatibility. Not all software depending on CLucene API has been adapted to work with the new changed APIs. The package is simply the last 0.9.21b package from Koji and was renamed to be installed in parallel with current clucene versions.
Starting review.
Good: - rpmlint checks return: Lots of bogus spelling errors and: clucene09-core.x86_64: W: file-not-utf8 /usr/share/doc/clucene09-core-0.9.21b/README The character encoding of this file is not UTF-8. Consider converting it in the specfile's %prep section for example using iconv(1). clucene09-core.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/clucene09-core-0.9.21b/LGPL.license This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. clucene09-core.x86_64: E: incorrect-fsf-address /usr/share/doc/clucene09-core-0.9.21b/LGPL.license The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. Fix these. clucene09-core-devel.x86_64: W: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. Either correct this or comment on the rational for this placement in the spec. clucene09-core-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. Fix this if you can. - package meets naming guidelines - package meets packaging guidelines - license ( LGPLv2+ or ASL 2.0 ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r Mock build in progress to test BRs.
Mock build was good, BRs are OK, so it's just the encoding, text, file placement, and docs issues.
(In reply to comment #2) > clucene09-core.x86_64: W: file-not-utf8 > /usr/share/doc/clucene09-core-0.9.21b/README > The character encoding of this file is not UTF-8. Consider converting it in > the specfile's %prep section for example using iconv(1). > > clucene09-core.x86_64: W: wrong-file-end-of-line-encoding > /usr/share/doc/clucene09-core-0.9.21b/LGPL.license > This file has wrong end-of-line encoding, usually caused by creation or > modification on a non-Unix system. It could prevent it from being displayed > correctly in some circumstances. Sorry. I will correct those. > clucene09-core.x86_64: E: incorrect-fsf-address > /usr/share/doc/clucene09-core-0.9.21b/LGPL.license > The Free Software Foundation address in this file seems to be outdated or > misspelled. Ask upstream to update the address, or if this is a license file, > possibly the entire file with a new copy available from the FSF. As mentioned in comment #1, this is an older version of the package just for compatibility reasons. Newer upstream versions should have a proper address. AFAIK this is not a blocker. > clucene09-core-devel.x86_64: W: only-non-binary-in-usr-lib > There are only non binary files in /usr/lib so they should be in /usr/share. > > Either correct this or comment on the rational for this placement in the spec. Will be "clucene-config.h is arch/platform specific and must be installed in %{_libdir}" enough clarification? See also bug #381481 for some more details, please. > clucene09-core-devel.x86_64: W: no-documentation > The package contains no documentation (README, doc, etc). You have to include > documentation files. IIRC this is no must and there is nothing really useful I could include. Would you like an updated package/spec file because of point 1 and 3?
(In reply to comment #4) > (In reply to comment #2) > > clucene09-core.x86_64: W: file-not-utf8 > > /usr/share/doc/clucene09-core-0.9.21b/README > > The character encoding of this file is not UTF-8. Consider converting it in > > the specfile's %prep section for example using iconv(1). > > > > clucene09-core.x86_64: W: wrong-file-end-of-line-encoding > > /usr/share/doc/clucene09-core-0.9.21b/LGPL.license > > This file has wrong end-of-line encoding, usually caused by creation or > > modification on a non-Unix system. It could prevent it from being displayed > > correctly in some circumstances. > > Sorry. I will correct those. > > > clucene09-core.x86_64: E: incorrect-fsf-address > > /usr/share/doc/clucene09-core-0.9.21b/LGPL.license > > The Free Software Foundation address in this file seems to be outdated or > > misspelled. Ask upstream to update the address, or if this is a license file, > > possibly the entire file with a new copy available from the FSF. > > As mentioned in comment #1, this is an older version of the package just for > compatibility reasons. Newer upstream versions should have a proper address. > AFAIK this is not a blocker. > Agreed. > > clucene09-core-devel.x86_64: W: only-non-binary-in-usr-lib > > There are only non binary files in /usr/lib so they should be in /usr/share. > > > > Either correct this or comment on the rational for this placement in the spec. > > Will be "clucene-config.h is arch/platform specific and must be installed in > %{_libdir}" enough clarification? See also bug #381481 for some more details, > please. > Looks reasonable, include that comment and reference that BZ. > > clucene09-core-devel.x86_64: W: no-documentation > > The package contains no documentation (README, doc, etc). You have to include > > documentation files. > > IIRC this is no must and there is nothing really useful I could include. > That being the case, that's fine. > > Would you like an updated package/spec file because of point 1 and 3? Yes, please.
(In reply to comment #5) > (In reply to comment #4) > > Would you like an updated package/spec file because of point 1 and 3? > > Yes, please. Spec URL: http://labs.linuxnetz.de/bugzilla/clucene09.spec SRPM URL: http://labs.linuxnetz.de/bugzilla/clucene09-0.9.21b-2.src.rpm
Excellent. APPROVED.
Thank you very much for the review! New Package SCM Request ======================= Package Name: clucene09 Short Description: A C++ port of Lucene Owners: robert Branches: f16 InitialCC:
Git done (by process-git-requests).
clucene09-0.9.21b-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/clucene09-0.9.21b-2.fc16
clucene09-0.9.21b-2.fc16 has been pushed to the Fedora 16 testing repository.
clucene09-0.9.21b-2.fc16 has been pushed to the Fedora 16 stable repository.