Spec URL: http://jforbes.fedorapeople.org/rpmdrop/sgabios.spec SRPM URL: http://jforbes.fedorapeople.org/rpmdrop/sgabios-0.1-0.20110621SVN.fc15.src.rpm Description: I would appreciate any help with package review here, sgabios is primarily to be used by kvm. SGABIOS is designed to be inserted into a BIOS as an option rom to provide over a serial port the display and input capabilities normally handled by a VGA adapter and a keyboard, and additionally provide hooks for logging displayed characters for later collection after an operating system boots.
I'll review it
Any update on this?
(In reply to comment #2) > Any update on this? Hello, Justin. Sorry for the hiatus. Here are my preliminary suggestions: * Please provide a way to recreate tarball. I advise you to add something like this: # svn export http://sgabios.googlecode.com/svn/trunk sgabios-0 # tar -cjvf sgabios-0.tar.bz2 sgabios-0 * Versioning is slightly wrong - release should be 0. * You added ExclusiveArch directive but this application (BIOS firmware) is intended to be used on every architecture which is supported by Qemu so this is wrong. I changed it a bit and dropped splitting to main and *-bin subpackages. Here is my variant: * http://peter.fedorapeople.org/sgabios/sgabios.spec * http://peter.fedorapeople.org/sgabios/sgabios-0-0.1.20110621SVN.fc16.src.rpm Koji scratchbuild for Rawhide: * http://koji.fedoraproject.org/koji/taskinfo?taskID=3529886
Thanks for the catch on the tarball recreation steps. I started to put them in and seem to have left out that line. Versioning has been updated. The bin separation is mainly to support secondary arches, which will need this bios, but cannot build it, this is similar to what we are doing with seabios, which must be built on x86/x86_64 but needs to be installed on ppc/390/etc if they are using qemu. It is an ugly hack, but it is required. With this in place, compose will take the base empty package built on those arches, and pull in the noarch dep from an existing x86 build. Updated spec: http://jforbes.fedorapeople.org/rpmdrop/sgabios.spec Updated srpm: http://jforbes.fedorapeople.org/rpmdrop/sgabios-0-0.20110621SVN.fc16.src.rpm Koji scratchbuild for f16: http://koji.fedoraproject.org/koji/taskinfo?taskID=3530311
Wanted to ping before the scratch build goes away. Any news?
(In reply to comment #5) > Wanted to ping before the scratch build goes away. Any news? Sorry for the delay - I really plan to return to this ticket earlier but recent Russian events (in which I took active part and will continue participating) prevented me from finishing this review as well as ruined some other my plans. I'm perfectly fine with the current approach (main and *-bin sub-packages) but I don't fully get why not simply build the entire package on x86 arch and mark as noarch (w/o splitting into sub-packages at all). I didn't dig into details about how packages built and pushed to the repos but I think it does the same but doesn't introduce intermediate *-bin sub-package. Anyway I won't mark this as a blocker so this package is APPROVED.
New Package SCM Request ======================= Package Name: sgabuis Short Description: Open-source serial graphics BIOS option rom Owners: jforbes Branches: f16 InitialCC: fedora-virt-maint
Pacakge name does not match summary, and fedora-virt-maint isn't a valid FAS account.
New Package SCM Request ======================= Package Name: sgabios Short Description: Open-source serial graphics BIOS option rom Owners: jforbes Branches: f16 InitialCC:
Git done (by process-git-requests).
Still no updates in Bodhi. Is it intentional?