Bug 752838 - Review Request: perl-TAP-Formatter-JUnit - Harness output delegate for JUnit output
Summary: Review Request: perl-TAP-Formatter-JUnit - Harness output delegate for JUnit ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 752836
Blocks:
TreeView+ depends on / blocked
 
Reported: 2011-11-10 14:51 UTC by Daniel Berrangé
Modified: 2011-11-25 23:22 UTC (History)
3 users (show)

Fixed In Version: perl-TAP-Formatter-JUnit-0.08-2.fc15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-11-16 13:11:07 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Daniel Berrangé 2011-11-10 14:51:38 UTC
Spec URL: http://berrange.fedorapeople.org/review/perl-TAP-Formatter-JUnit/perl-TAP-Formatter-JUnit.spec
SRPM URL:http://berrange.fedorapeople.org/review/perl-TAP-Formatter-JUnit/perl-TAP-Formatter-JUnit-0.08-1.fc15.src.rpm
Description: This module provides JUnit output formatting for TAP::Harness (a replacement for Test::Harness.


NB: this review first requires acceptance of bug 752836  for perl-Class-Field

Comment 1 Parag AN(पराग) 2011-11-16 06:02:54 UTC
Review:-

+ koji build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3518023
+ rpmlint on package gave
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
+ source match with upstream as (sha1sum)
3ba936489fff2f9c305f5d907595fb7e6d024c7a  ../SOURCES/TAP-Formatter-JUnit-0.08.tar.gz
3ba936489fff2f9c305f5d907595fb7e6d024c7a  TAP-Formatter-JUnit-0.08.tar.gz

+ make test gave
All tests successful.
Files=8, Tests=68, 28 wallclock secs ( 0.05 usr  0.01 sys +  3.93 cusr  0.70 csys =  4.69 CPU)
+ Package: perl-TAP-Formatter-JUnit-0.08-1.fc17.noarch
Provides: perl(TAP::Formatter::JUnit) = 0.08 perl(TAP::Formatter::JUnit::Session)
Requires: /usr/bin/perl perl(Class::Field) perl(File::Path) perl(File::Slurp) perl(Getopt::Long) perl(IO::File) perl(Pod::Usage) perl(Storable) perl(TAP::Formatter::Console) perl(TAP::Formatter::Console::Session) perl(TAP::Formatter::JUnit) perl(TAP::Formatter::JUnit::Session) perl(TAP::Parser) perl(TAP::Parser::Aggregator) perl(XML::Generator) perl(base) perl(strict) perl(warnings)

+ Follows packaging guidelines

Suggestions:
1) For the active fedora releases you can remove following from spec
 a) buildroot
 b) cleaning of buildroot in %install
 c) %clean section
 d) %defattr(-,root,root,-)

APPROVED.

Comment 2 Daniel Berrangé 2011-11-16 10:43:14 UTC
New Package SCM Request
=======================
Package Name: perl-TAP-Formatter-JUnit
Short Description: Harness output delegate for JUnit output
Owners: berrange
Branches: f15 f16
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2011-11-16 12:09:53 UTC
Git done (by process-git-requests).

Comment 4 Daniel Berrangé 2011-11-16 13:11:07 UTC
built into rawhide

Comment 5 Fedora Update System 2011-11-16 14:15:11 UTC
perl-TAP-Formatter-JUnit-0.08-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/perl-TAP-Formatter-JUnit-0.08-2.fc15

Comment 6 Fedora Update System 2011-11-16 14:15:57 UTC
perl-TAP-Formatter-JUnit-0.08-2.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/perl-TAP-Formatter-JUnit-0.08-2.fc16

Comment 7 Fedora Update System 2011-11-25 23:21:46 UTC
perl-TAP-Formatter-JUnit-0.08-2.fc16 has been pushed to the Fedora 16 stable repository.

Comment 8 Fedora Update System 2011-11-25 23:22:40 UTC
perl-TAP-Formatter-JUnit-0.08-2.fc15 has been pushed to the Fedora 15 stable repository.


Note You need to log in before you can comment on or make changes to this bug.