Spec URL: http://www.cs.sfu.ca/~aha49/personal/fedora/gnome-shell-extension-netspeed.spec SRPM URL: http://www.cs.sfu.ca/~aha49/personal/fedora/gnome-shell-extension-netspeed-0-0.1.src.rpm Description: This is a simple gnome-shell extension to display speed of internet and speed of each device (upload + download) separately as well
Review:- + koji build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3514555 + rpmlint on package gave gnome-shell-extension-netspeed.noarch: W: no-version-in-last-changelog gnome-shell-extension-netspeed.noarch: W: invalid-url URL Note gnome-shell-extension-netspeed.noarch: W: no-documentation gnome-shell-extension-netspeed.noarch: W: empty-%postun gnome-shell-extension-netspeed.src: W: no-version-in-last-changelog gnome-shell-extension-netspeed.src: W: invalid-url URL Note gnome-shell-extension-netspeed.src:2: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 1) gnome-shell-extension-netspeed.src: W: invalid-url Source0: netspeed.com.tar.gz 2 packages and 0 specfiles checked; 0 errors, 8 warnings. suggestions: 1) you don't need now following in current active Fedora releases. %defattr (-,root,root,-) and in %install rm -rf %{buildroot} 2) add the version-release information in changelog like * Sun Nov 13 2011 Amir Hedayaty <hedayaty AT gmail DOT com>- 0-0.1 - Initial package for Fedora 3) you can remove warning mixed-use-of-spaces-and-tabs by using command sed -e 's|\t| |g' gnome-shell-extension-netspeed.spec 3) I see you have wrong spec file added in srpm. you added gnome-shell-extension-no11y.spec whereas it should be gnome-shell-extension-noa11y.spec 4) you don't need %postun in spec file. remove that. 5) Host your tarball on some server and use that download url in URL of spec. submit a new SPEC and SRPM by fixing above issues. Add some document files in upstream tarball that tells how to install this extension as well as license information and its text in a separate file.
Thanks for feedback here are the new urls: Spec URL: http://www.cs.sfu.ca/~aha49/personal/fedora/gnome-shell-extension-netspeed.spec SRPM URL: http://www.cs.sfu.ca/~aha49/personal/fedora/gnome-shell-extension-netspeed-3.2.0-1.src.rpm This extension was something which was missing from gnome 3.0, I wrote this a while ago, now it is in a better shape I guess now I share share it with other users. I am looking for getting feedback/patches from fedora users.
You looks to be not yet sponsored in Fedora project. Is this your first package submission to Fedora? Also, you need following in SPEC file Source0: http://www.cs.sfu.ca/~aha49/personal/fedora/%{name}-%{version}.tar.gz I think you can remove URL tag as you don't have specific project page for this package. Whenever you change a spec file and submits a new spec and srpm, you need to add changelog and bump the release number. If you are a new member to Fedora project then you need to go through http://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Get_Sponsored
(In reply to comment #3) > You looks to be not yet sponsored in Fedora project. Is this your first package > submission to Fedora? Yes this is my first official package for fedora (maybe I should have said these two) > > Also, you need following in SPEC file > > Source0: > http://www.cs.sfu.ca/~aha49/personal/fedora/%{name}-%{version}.tar.gz Well, that's a more reasonable name for archive > I think you can remove URL tag as you don't have specific project page for this > package. > > > Whenever you change a spec file and submits a new spec and srpm, you need to > add changelog and bump the release number. > > If you are a new member to Fedora project then you need to go through > http://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Get_Sponsored I have been around for a few years, I am looking to get involved more with Fedora project. So far I just contribute on QA tests for graphics drivers and some releases a little more. I could not setup fedora-packager, I guess currently there are some issues with fedora infrastructures, for a few days even yum is broken! I will update the packages and spec files in 10 minutes. I do not think updating urls is required.
To get sponsored you need to show your packaging skills. Post some unofficial reviews to other new packages awaiting for their reviews.(http://fedoraproject.org/wiki/How_to_get__into_the_packager_group#Reviewing_packages) Go through http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
I can sponsor you once you will do some unofficial reviews. When you will do other package reviews then post that review link here to let me know.
Hi, I have reviewed these 3 packages, I hope it was a contribution to fedora rather than giving in-appropriate feedback to people, esp. one of them is Matthias Clasen which is the maintainer of gtk+ https://bugzilla.redhat.com/show_bug.cgi?id=753027 https://bugzilla.redhat.com/show_bug.cgi?id=755141 https://bugzilla.redhat.com/show_bug.cgi?id=744066 I would be happy to get feed-back on my reviews.
Nice to see you have some reviews. It will be good if you will do a full review of another 3-4 packages. You can get the review templates that some people have added to wiki at http://fedoraproject.org/wiki/Category:Package_Maintainers/Review_Template And don't change any flags at all.
Hi Amir, Is there any updates by you on reviewing other's packages?
Sorry, I am under heavy pressure to prepare a report. Hopefully I will be able to get back and continue reviewing some more packages/
any updates?
Again sorry, this is embarrassing. I have also submitted this extension to gnome, they have requested a few corrections which I am also applying them.
ping you around? Hope you have done some review in meantime.
Around a week ago I received an email that I have been sponsored! Meanwhile, I have uploaded this to gnome site, got some feedback and added minor changes! I will attach the latest version
I guess it is much better to be on github https://github.com/downloads/hedayaty/NetSpeed/gnome-shell-extension-netspeed.spec https://github.com/downloads/hedayaty/NetSpeed/gnome-shell-extension-netspeed-3.2.9-1.noarch.rpm
That's nice that you have been already sponsored.
can you post srpm link?
Opps! instead of srpm I have uploaded srpm! Here is the srpm file: https://github.com/downloads/hedayaty/NetSpeed/gnome-shell-extension-netspeed-3.2.9-1.src.rpm
Review: + koji scratch build for f17 -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3908555 + rpmlint on rpms gave gnome-shell-extension-netspeed.noarch: W: no-documentation gnome-shell-extension-netspeed.src: W: invalid-url Source0: gnome-shell-extension-netspeed-3.2.9.tar.gz 2 packages and 0 specfiles checked; 0 errors, 2 warnings. + package follows guidelines. Suggestions: 1)you should provide steps in spec above source0: tag on how to create a tarball. 2) Any reason for not using disttag? See http://fedoraproject.org/wiki/Packaging:DistTag how to add dist-tag. 3) Package is installed successfully but unable to get extension working. Look like you need to modify metadata.json to include new gnome-shell versions. I tested on f17 and this is not working. After adding "3.3.90" as gnome-shell version it start working.
Sorry about that! I have updated the srpm and spec file(same link), they should be working now. The current target is FC16 and gnome 3.2 . I have not tested this on gnome 3.4 yet, hopefully with a few days I can do it.
Package must work on current development version. Please make sure your extensions will work in F17 and F18.
I tried the extension on FC17 unfortunately it did not work! I think before release of FC17 I can make the changes to make it work. The problem is that there is no documentation about migrating or writing extension for gnome 3.4(or 3.3) right now! I am thinking of writing to people and asking for help.
OK, the issue was solved somehow gnome-extension-tool did not enable the extensions! Here is the new version for gnome 3.4 and FC17 https://github.com/downloads/hedayaty/NetSpeed/gnome-shell-extension-netspeed-3.4.10-1.src.rpm https://github.com/downloads/hedayaty/NetSpeed/gnome-shell-extension-netspeed.spec
Any update?
koji build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3996995 Fix the rpmlint warning gnome-shell-extension-netspeed.noarch: W: incoherent-version-in-changelog 3.4.10 ['3.4.10-1', '3.4.10-1'] The latest entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. unable to verify sources as wget https://github.com/downloads/hedayaty/NetSpeed/gnome-shell-extension-netspeed-3.4.10.tar.gz ==> ERROR 404: Not Found.
OK, uploaded the files! Warning goes away without changing any line.
you need to change 3.4.10 to 3.4.10-1 to fix rpmlint warning. one last thing, maybe I had overlooked but where can I see the license to verify? I see no separate license text file available in tarball, no license headers included in .js
Copyright line added, some minor improvements as well. Hope, everything will be find. https://github.com/downloads/hedayaty/NetSpeed/gnome-shell-extension-netspeed-3.4.11-1.src.rpm https://github.com/downloads/hedayaty/NetSpeed/gnome-shell-extension-netspeed.spec https://github.com/downloads/hedayaty/NetSpeed/gnome-shell-extension-netspeed-3.4.11.tar.gz
rpmlint still shows gnome-shell-extension-netspeed.noarch: W: incoherent-version-in-changelog 3.4.11 ['3.4.11-1', '3.4.11-1'] Why do you think release number is not important in Changelog? Please read http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
Anyway, I will not wait for this to get fixed. APPROVED.
any update here?
So the next step is sending the SCM Request? New Package SCM Request ======================= Package Name: gnome-shell-extension-netspeed Short Description: Add an Internet speed indicator to status area. Owners: Amir Hedayaty Branches: f16 f17 InitialCC: amir
Amir is not a valid FAS account.
It is a valid ID, and my user id is 6003
any updates here?
If I will not hear any updates in next one week, will close this as NOTABUG
I still do not get it! I have a fas account named amir and I am a member of Fedora Packager GIT Commit Group.
ah! I am surprised to hear that. Have you reported this issue to FAS trac? if not then report it to https://fedorahosted.org/fas/newticket Jon, Please look again for comment#32 request, I can see "amir" FAS ID valid and active.
I do not see any issue!
Amir, Will you be please more informative like what is the problem for you that prevents package building? What I see is that still package repo is not created for this package. So, once its done you can build package on koji and close this review.
The problem is that in the SCM request you have Owners: Amir Hedayaty, and it needs to be Owners: amir. Use the FAS account name, not the full name or email address.
Amir, Please submit a fresh new package SCM request here.