Bug 755464 - starts the service in %post (packaging policy violation)
Summary: starts the service in %post (packaging policy violation)
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: zfs-fuse
Version: 16
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 769018 (view as bug list)
Depends On:
Blocks: 758689
TreeView+ depends on / blocked
 
Reported: 2011-11-21 08:44 UTC by Michal Schmidt
Modified: 2012-03-08 21:27 UTC (History)
10 users (show)

Fixed In Version: zfs-fuse-0.7.0-2.fc15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-03-06 20:45:17 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Michal Schmidt 2011-11-21 08:44:47 UTC
Description of problem:

In a recent F16 update, libguestfs pulled in zfs-fuse as a dependency, so I noticed the following problem.

zfs-fuse's %post scriptlet does this:

if [ $1 = 1 ] ; then
    echo "Initial install.  Starting service"
    /sbin/chkconfig --add zfs-fuse
    /sbin/service zfs-fuse start >/dev/null 2>&1 || :
fi

Starting of services is not allowed by the packaging guidelines:
http://fedoraproject.org/wiki/Packaging:SysVInitScript#Why_don.27t_we....

      start the service after installation? 

  Installations can be in changeroots, in an installer context,
  or in other situations where you don't want the services started. 

In addition, it is unusual for Fedora packages' scriptlets to echo informational messages. Please prefer standard forms of scriptlets as
described in the guidelines.

Version-Release number of selected component (if applicable):
zfs-fuse-0.6.9-8.20100709git.fc15.x86_64

Comment 1 Scott Dowdle 2011-11-30 05:16:45 UTC
Just wanted to add that the fact that zfs-fuse starts the service as part of the package install... it breaks my Fedora 16 remix building with livecd-creator.  Watching the packages install during the remix build I see:

Installing: zfs-fuse                     ################### [1008/2002] 
Initial install.  Starting service

I have to manually kill zfs-fuse after it gets started in the livecd-creator chroot or the remix fails.

Please fix. Thanks.

Comment 2 Scott Dowdle 2011-11-30 05:27:32 UTC
Looking at the changelog for zfs-fuse it is obvious that the packager was aware of this issue in the past and fixed it but it got back in somehow.  From the changelog:

* Sat Dec 26 2009 Uwe Kubosch <uwe> - 0.6.0-5
- Removed chckconfig on and service start commands from install script
  See https://fedoraproject.org/wiki/Packaging:SysVInitScript#Why_don.27t_we

Comment 3 Scott Dowdle 2011-11-30 16:23:07 UTC
I got an email from Uwe Kubosch (the package maintainer for zfs-fuse) and was told that he (or she?) wasn't using zfs-fuse anymore... and was looking for someone to take over package maintenance... and had one candidate so far.

Comment 4 Jon Stanley 2012-01-16 18:01:44 UTC
Does anyone have status on this? It's been over 45 days since the last update and I just ran into this myself.

Is someone else interested in maintaining the package?

Comment 5 Gwyn Ciesla 2012-02-27 20:37:45 UTC
I'm working on this and the FTBFS, if you can get Uwe to orphan it I'll take it.

Comment 6 Uwe Kubosch 2012-02-27 20:46:25 UTC
I'm game.  I'll have to look up how to orphan a package.  Feel free to point me in the right direction.

Comment 7 Gwyn Ciesla 2012-02-27 20:49:50 UTC
*** Bug 769018 has been marked as a duplicate of this bug. ***

Comment 8 Gwyn Ciesla 2012-02-27 20:51:11 UTC
https://admin.fedoraproject.org/pkgdb/acls/name/zfs-fuse

Log in with your FAS account, click orphan on each branch.  Then let me know, and I'll take ownership.

Comment 9 Uwe Kubosch 2012-02-27 20:54:27 UTC
Done.  Go ahead!  Happy packaging!

Comment 10 Fedora Admin XMLRPC Client 2012-02-27 20:57:00 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 11 Gwyn Ciesla 2012-02-27 20:57:41 UTC
Taken, thanks!

Comment 12 Fedora Update System 2012-02-28 15:08:07 UTC
zfs-fuse-0.7.0-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/zfs-fuse-0.7.0-1.fc16

Comment 13 Fedora Update System 2012-02-28 15:08:34 UTC
zfs-fuse-0.7.0-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/zfs-fuse-0.7.0-1.fc15

Comment 14 Fedora Update System 2012-02-28 15:09:02 UTC
zfs-fuse-0.7.0-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/zfs-fuse-0.7.0-1.fc17

Comment 15 Fedora Update System 2012-02-28 16:54:51 UTC
zfs-fuse-0.7.0-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/zfs-fuse-0.7.0-2.fc17

Comment 16 Fedora Update System 2012-02-28 16:55:20 UTC
zfs-fuse-0.7.0-2.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/zfs-fuse-0.7.0-2.fc16

Comment 17 Fedora Update System 2012-02-28 16:55:50 UTC
zfs-fuse-0.7.0-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/zfs-fuse-0.7.0-2.fc15

Comment 18 Fedora Update System 2012-02-28 20:42:03 UTC
Package zfs-fuse-0.7.0-2.fc17:
* should fix your issue,
* was pushed to the Fedora 17 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing zfs-fuse-0.7.0-2.fc17'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-2633/zfs-fuse-0.7.0-2.fc17
then log in and leave karma (feedback).

Comment 19 Fedora Update System 2012-03-06 20:45:17 UTC
zfs-fuse-0.7.0-2.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 20 Fedora Update System 2012-03-08 21:23:59 UTC
zfs-fuse-0.7.0-2.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 21 Fedora Update System 2012-03-08 21:27:26 UTC
zfs-fuse-0.7.0-2.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.