Spec URL: http://hubbitus.info/rpm/Fedora15/sk1libs/sk1libs.spec SRPM URL: http://hubbitus.info/rpm/Fedora15/sk1libs/sk1libs-0.9.1-1.fc15.src.rpm Description: sk1libs is a universal vector graphics library for Python. P.S. Spec file formatted by tabs with 5 space width ( http://fedoraproject.org/wiki/PavelAlexeev/tabsize ). Please, do not start review if it is a problem for you.
* Doesn't build on my machine: "src/pycms/_pycms.c:21:18: fatal error: lcms.h: No such file or directory" * The tarball seems to bundle a couple of other Python modules. They should be removed in the prep section. * You can drop "-n sk1libs-%{version}", as it's the default. * Defattr is no longer necessary * Defining python_sitearch is not necessary for Fedora anymore. If you're going for EPEL 5, it is necessary, but only for EPEL: http://fedoraproject.org/wiki/Packaging:Python#Macros Drop the clean section and the rm in the install section in that case. Otherwise define buildroot: http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag
Volker, thank you. I have address all mentioned issues except bundled libs. For that upstream bug filed: http://code.google.com/p/sk1/issues/detail?id=30
Please always use a new release number when you publish your file. That makes it a lot easier to compare and thus review.
Ah, OK, I thought you had replaced the spec file.
Yes, I always try bump release. Now I just think it have not worth upload it because other changes is not so important as bundled libs.
Volker, are you doing this review?
No, Michel, please feel free!
Thanks. Taking the review.
Michael, thank you for willing revкумц that - it very appreciated, but nor there bundled libs stop issue. I have submitted it to upstream, but have no any response yet.
Michel, thank you for willing review that - it very appreciated, but now there bundled libs stop issue. I have submitted it to upstream, but have no any response yet. P.S. Sorry for the previous buggy message.
I had to strip a bundled library from a Python package before, so let me see if this can be quickly fixed. BTW, upstream's project site is horribly messy -- the 0.9.1 final download is not listed on the download page, but they already have a 0.9.2pre -- and the download link works! Really odd
Created attachment 559500 [details] spec with some unbundling Attached spec has libpdf replaced by a stub that loads the system reportlab module. I tried doing the same to imaging, but it's a bit tricky as that is used during the build process.
Created attachment 559501 [details] libpdf stub module the stub file for src/libpdf/__init__.py
Created attachment 559502 [details] patch for removing the now-missing libpdf dirs libpdf itself is still present, but all the subdirectories (that are in reportlab) are now missing. Stop setup.py from trying to install them
Pavel, if you could upstream those, perhaps they'd be able to either stop bundling, or at least tell us how to remove the remaining bundled libraries. Ping me when there's any progress :)
Thank you very much. I've add comment to bug and will try contact upstream by mail.
I have got answer from author by private mail. Key ideas from it: 1. pycms is wrapper and not bundled lib! 2. PIL replaced by reportlab is bad idea - it is patched. Patches suggested to upstream but not accepted long time. May be sk1libs will work with reportlab, but lose some functionality. They unsure thought. 3. Branch 1.x freeze happened. Now all work done in Uniconvertor 2.0 which should came on LGM2012 (start of may) and will not require external libs like sk1lib. So, I make decision what it have no worth to continue work under it. Thank you, Michel, for help.