Bug 762455 (GLUSTER-723) - enhancements to quick read
Summary: enhancements to quick read
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: GLUSTER-723
Product: GlusterFS
Classification: Community
Component: quick-read
Version: mainline
Hardware: All
OS: Linux
high
medium
Target Milestone: ---
Assignee: Raghavendra G
QA Contact:
URL:
Whiteboard:
: GLUSTER-727 GLUSTER-954 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-03-15 09:03 UTC by Raghavendra G
Modified: 2015-12-01 16:45 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:


Attachments (Terms of Use)

Description Raghavendra G 2010-03-15 09:03:16 UTC
* quick read has to respect O_DIRECT flag passed through open and the file has to be read from the back for fds opened with the flag set.

* An upper limit specifying maximum memory quick-read can use for caching has to be implemented.

Comment 1 Ian Rogers 2010-03-15 11:57:47 UTC
The filter io-cache seems more advanced than quick-read. Rather than adding memory pruning to quick-read how about adding an option quickread-smailler-than to io-cache? It's values would be 0 (default) for the current behaviour, or a multiple of io-cache's internal page size (automatically rounded) to specify quickread?

I know this breaks the "stacked small filters" philosophy of gluster, but it would be much more efficient in cpu and memory and probably simpler to implement.

Ian

Comment 2 Raghavendra G 2010-03-30 02:09:40 UTC
*** Bug 727 has been marked as a duplicate of this bug. ***

Comment 3 Anand Avati 2010-04-08 07:08:34 UTC
PATCH: http://patches.gluster.com/patch/3087 in master (performance/quick-read: read directly from backend for fds opened with O_DIRECT flag.)

Comment 4 Anand Avati 2010-04-08 07:08:53 UTC
PATCH: http://patches.gluster.com/patch/3111 in release-2.0 (performance/quick-read: read directly from backend for fds opened with O_DIRECT flag.)

Comment 5 Anand Avati 2010-04-08 07:08:57 UTC
PATCH: http://patches.gluster.com/patch/3088 in release-3.0 (performance/quick-read: read directly from backend for fds opened with O_DIRECT flag.)

Comment 6 Krishna Srinivas 2010-04-22 13:22:50 UTC
quick-read memory hog is critical issue as lot of customers are coming back with memory hog issue. Needs to be fixed ASAP. When is this scheduled to be fixed?

Comment 7 Amar Tumballi 2010-05-04 08:24:55 UTC
Patch is sent to review, and once committed, we will make a release.

Comment 8 Krishna Srinivas 2010-05-12 17:44:26 UTC
(In reply to comment #7)
> Patch is sent to review, and once committed, we will make a release.

Hey guys, what is the status of the patch that limits the QR mem usage?

Comment 9 Anand Avati 2010-05-26 04:13:46 UTC
PATCH: http://patches.gluster.com/patch/3279 in master (performance/quick-read: implement an upper size limit for the cache.)

Comment 10 Anand Avati 2010-05-26 04:13:51 UTC
PATCH: http://patches.gluster.com/patch/3312 in release-3.0 (performance/quick-read: implement an upper size limit for the cache.)

Comment 11 Anand Avati 2010-06-03 06:15:08 UTC
PATCH: http://patches.gluster.com/patch/3362 in master (performance/quick-read: set default cache-size value to 128MB.)

Comment 12 Anand Avati 2010-06-03 06:15:16 UTC
PATCH: http://patches.gluster.com/patch/3361 in release-3.0 (performance/quick-read: set default cache-size value to 128MB.)

Comment 13 Anand Avati 2010-06-07 15:58:56 UTC
PATCH: http://patches.gluster.com/patch/3391 in master (quick-read: fix size parameter to GF_CALLOC of priv to fix mem corruption)

Comment 14 Csaba Henk 2010-06-10 07:05:26 UTC
*** Bug 954 has been marked as a duplicate of this bug. ***

Comment 15 Lakshmipathi G 2010-06-14 06:19:27 UTC
Following quick-read features are tested/verified-
LRU behaviour  
Concurrent r/w access on a file from same client and different clients.  
Check cache info. hits/misses  
With very high cache , read() should succeed even when server is disconnected. 
Write once and sure cache is freed. 
kernel compile
quick read default total cache size 128mb


Note You need to log in before you can comment on or make changes to this bug.