This plugin is an LV2 port of the popular kn0ck0ut VST plugin. For those of you who aren't familiar with the LV2 audio framework, all your questions can be answered here: http://lv2plug.in/trac/ In the meantime rpmlint show's only errors on the source, due to this being only available via github. SRPM: http://bsjones.fedorapeople.org/lv2-kn0ck0ut-1.1-0.1.gitd03e8db0.fc16.src.rpm SPEC: http://bsjones.fedorapeople.org/lv2-kn0ck0ut.spec fedora16:~/rpmbuild/SOURCES $ rpmlint ../SRPMS/lv2-kn0ck0ut-1.1-0.1.gitd03e8db0.fc16.src.rpm ../RPMS/x86_64/lv2-kn0ck0ut*1.1* lv2-kn0ck0ut.src: W: invalid-url Source0: lv2-kn0ck0ut-1.1-gitd03e8db0.tar.bz2
I'll review this one.
Failed to build in Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=3624781
Updated for new lv2core (see bug #771997) SRPM: http://bsjones.fedorapeople.org/lv2-kn0ck0ut-1.1-0.2.gitd03e8db0.fc16.src.rpm SPEC: http://bsjones.fedorapeople.org/lv2-kn0ck0ut.spec
Koji build for Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=3624984 Unfortunately I found one unexpected legal issue. It is written in readme.txt that "Kn0ck0ut is freeware and beta. No warranty, no support. The plugin may be redistributed but only for free, and only with this readme file." We do allow distributing Fedora for profit so this will violate our policies (and this isn't compatible with GPL as well). Could you please clarify what exactly original authors mean by this clause? This could be a leftover from some ancient times btw.
Thanks again for the review! I was just about to hit send to upstream about this and then realised that the text you quoted is from the original readme of the VST plugin. I'm not sure it applies to the package in this case but the port author has included it as per the readme. I will still send upstream a query however...
Hi Peter, this is from upstream: Hi Brendan, As the readme says, "kn0ck0ut-LV2 is released under the terms of the GPL version 3. (this is done so with the permission of st3pan0va)." And then below that "Below Reads the Original Readme" I left the original readme at the bottom of the readme for historical purposes (and to preserve acknowledgments). The original author gave me explicit permission to release under the GPL. I've pushed changes to the repository which further clarify things under the tag 1.01 Jeremy
Ah, ok. And here is a commit with new licensing terms: https://github.com/jeremysalwen/kn0ck0ut-LV2/commit/60421a3 Ok, here is my formal REVIEW: Legend: + = PASSED, - = FAILED, 0 = Not Applicable + rpmlint is silent work ~/temp: rpmlint * lv2-kn0ck0ut.src: I: enchant-dictionary-not-found en_US lv2-kn0ck0ut.src: W: invalid-url Source0: lv2-kn0ck0ut-1.1-gitd03e8db0.tar.bz2 ^^^ that's expected from GitHub's repos. 3 packages and 0 specfiles checked; 0 errors, 1 warnings. work ~/temp: + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license (GPLv3 or later, as stated in the sources). + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package, match the upstream source, as provided in the spec URL. Unfortunately it's almost impossible to create bit-exact tarball from SCM (different usernames, different timestamps) so I used diff -ru to compare. + The package successfully compiles and builds into binary rpms on at least one primary architecture. See koji link above. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No shared library files in some of the dynamic linker's default paths. + The package does NOT bundle copies of system libraries. 0 The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. 0 The package DOESN'T have a %clean section, so it won't build cleanly on systems with old rpm (EL-4 and EL-5, not sure about EL-6). Beware. + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No header files. 0 No static libraries. 0 No pkgconfig(.pc) files. 0 The package doesn't contain library files without a suffix (e.g. libfoo.so). 0 No devel sub-package. + The package does NOT contain any .la libtool archives. 0 Not a GUI application. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages are valid UTF-8. APPROVED.
New Package SCM Request ======================= Package Name: lv2-kn0ck0ut Short Description: A spectral subtraction LV2 plugin Owners: bsjones Branches: f15 f16 InitialCC:
Thanks for the fast review!!
Git done (by process-git-requests).
Peter, the (pending) update will close these bugs.
lv2-kn0ck0ut-1.1-0.3.git60421a3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/lv2-kn0ck0ut-1.1-0.3.git60421a3.fc15
lv2-kn0ck0ut-1.1-0.3.git60421a3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/lv2-kn0ck0ut-1.1-0.3.git60421a3.fc16
Package lv2-kn0ck0ut-1.1-0.3.git60421a3.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing lv2-kn0ck0ut-1.1-0.3.git60421a3.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-0449/lv2-kn0ck0ut-1.1-0.3.git60421a3.fc16 then log in and leave karma (feedback).
lv2-kn0ck0ut-1.1-0.3.git60421a3.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report.
lv2-kn0ck0ut-1.1-0.3.git60421a3.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report.