Description: PyGTKHelpers is a library to assist the building of PyGTK applications. It is intentionally designed to be non-frameworky, and blend well with your particular style of PyGTK development. SRPM: http://fedorapeople.org/~limb/review/pygtkhelpers/pygtkhelpers-0.4.2-3.fc16.src.rpm SPEC: http://fedorapeople.org/~limb/review/pygtkhelpers/pygtkhelpers.spec
*** Bug 695022 has been marked as a duplicate of this bug. ***
Review: - rpmlint ok $ rpmlint /home/tom/rpmbuild/SRPMS/pygtkhelpers-0.4.2-3.fc16.src.rpm /home/tom/rpmbuild/RPMS/noarch/pygtkhelpers-0.4.2-3.fc16.noarch.rpm /home/tom/rpmbuild/RPMS/noarch/pygtkhelpers-examples-0.4.2-3.fc16.noarch.rpm pygtkhelpers.src: W: spelling-error %description -l en_US frameworky -> framework, frameworks, framework y pygtkhelpers.noarch: W: spelling-error %description -l en_US frameworky -> framework, frameworks, framework y 3 packages and 0 specfiles checked; 0 errors, 2 warnings. - macros everywhere - no libs - no .la NEEDSWORK - A %check won't work, because you can't import gtk in the buildsystem so anything will fail here. But running the tests locally, most things fails anyway. Could you test this with pida, so you are sure, this package works at all? (It looks they are only using a different nose abi than current f16, so changes are good. ;)) - license: from AUTHORS.txt: "pygtkhelpers.utils.gsignal/gproperty are taken from kiwi" Kiwi is LGPLv2+ (according to yum info python-kiwi), so LGPLv3 is allowed ./pygtkhelpers/debug/console.py is also LGPLed from medit, so LGPLv3 is ok too (Both seem to be adopted here, so I don't think they count as bundled lib... What's your opinion here?) - R not good. Python requires aren't automatic (yet?), so at least pygtk, pango and ***flatland***: ./pygtkhelpers/forms.py:from flatland import Dict, String, Integer, Boolean Couldn't find flatland in fedora yet...
Adding Flatland review. . .
PIDA does in fact work with this. Added flatland review and dep. I propose simply not shipping debug, do you think that would work? Other requires fixed.
(In reply to comment #4) > PIDA does in fact work with this. Great. > I propose simply not shipping debug, do you think that would work? debug is only used in one example, so expect a bug, when someone wants to use it too :) Otherwise, go for it.
Updated requires, leaving debug in since removing it breaks the build. And python-flatland has been built in rawhide. SRPM: http://fedorapeople.org/~limb/review/pygtkhelpers/pygtkhelpers-0.4.2-4.fc16.src.rpm SPEC: http://fedorapeople.org/~limb/review/pygtkhelpers/pygtkhelpers.spec
I'd say the two files, which are copyied from else where (see comment #2), are "modified beyond a certain extent", so they don't count as bundled. But do you now still need to get a decision about that from FPC? (I'm asking you directly, as you are a member of FPC ;)) Further information: http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Modified_beyond_a_certain_extent
Hmm. The gproperty function seems to be really, really close to what's in kiwi. I wonder if I can patch that out and use the system kiwi. medit isn't in Fedora, but it appears to be copied from an older release, 2008 or so. It's not a copylib, it's a chunk of code from something that has releases. That said, they're not libaries, really, just chunks of code from other whole projects. I'm not sure if they need an exception or not. Filed https://fedorahosted.org/fpc/ticket/135
Ok, the upshot of FPC discussion was that I should try to use system versions. So I'll try that, including packaging medit. All this to update PIDA. :)
And of course, medit bundles gtksourceview. <headdesk>
(In reply to comment #10) > And of course, medit bundles gtksourceview. <headdesk> ohoh... Now, I'm curious how badly you really want to update PIDA :P
Believe me, you're not the first to experience that feeling. :)
So I was tearing my hair out trying to rip gtksourceview out of medit, when it occurred to me that maybe I could just drop console.py, since it's just example/debugging code. And sure enough, nothing calls it. Success! No need to package medit! So then I tested my kiwi unbundling patch, and realized that pida tries to call the kiwi methods that pygtkhelpers bundles from pygtkhelpers, not kiwi, so I'll need to patch pida and require kiwi there, not in pygtkhelpers. So I went to do that, and I found bundled code in pida. From medit. <headdesk> To be continued. Up to a point. :)
Too many nested layers of bundling, retiring pida.