Bug 768007 - Review Request: python-flatland - HTML form management and validation
Summary: Review Request: python-flatland - HTML form management and validation
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Thomas Spura
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 767185
TreeView+ depends on / blocked
 
Reported: 2011-12-15 13:56 UTC by Gwyn Ciesla
Modified: 2012-02-03 15:32 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-02-03 15:32:27 UTC
Type: ---
Embargoed:
tomspur: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Gwyn Ciesla 2011-12-15 13:56:27 UTC
Description:
Flatland maps between rich, structured Python application data and the
string-oriented flat namespace of web forms, key/value stores, text
files and user input. Flatland provides a schema-driven mapping toolkit
with optional data validation.

SRPM: http://fedorapeople.org/~limb/review/python-flatland/python-flatland-0.0.2-1.fc16.src.rpm
SPEC: http://fedorapeople.org/~limb/review/python-flatland/python-flatland.spec

Comment 1 Thomas Spura 2012-01-18 21:14:53 UTC
Review:
- $ rpmlint /home/tom/rpmbuild/SRPMS/python-flatland-0.0.2-1.fc16.src.rpm /home/tom/rpmbuild/RPMS/noarch/python-flatland-0.0.2-1.fc16.noarch.rpm
python-flatland.src: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace
python-flatland.src: W: invalid-url Source0: jek-flatland-0938e70bb76d.tar.bz2
python-flatland.noarch: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace
2 packages and 0 specfiles checked; 0 errors, 3 warnings.
  all ignorable
- koji build:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=3712729
- source match upstream:
  2a0185ad21e9f45a5be67fda5fb43b81  jek-flatland-0938e70bb76d.tar.bz2
- license ok

NEEDSWORK:
- please be more specific in %files:
%{python_sitelib}/flatland-*py?.?.egg-info
%{python_sitelib}/flatland/
- Query upstream to include license headers
- Please add a check section:
 %check
 nosetests -v
Then you see, there is at least one missing dep blinker (both BR and R).

========================================================================

Please implement the NEEDSWORK issues, but as they are all "should":

========================================================================

APPROVED

Comment 2 Thomas Spura 2012-01-18 21:19:05 UTC
Sorry, proper koji build with BR python-nose:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3712734

Comment 3 Gwyn Ciesla 2012-01-19 13:13:06 UTC
New Package SCM Request
=======================
Package Name: python-flatland
Short Description: HTML form management and validation
Owners: limb
Branches: 
InitialCC: 


Will do, thanks very much!

Comment 4 Gwyn Ciesla 2012-01-19 13:22:21 UTC
Git done (by process-git-requests).

Comment 5 Gwyn Ciesla 2012-02-03 15:32:27 UTC
Built in rawhide.


Note You need to log in before you can comment on or make changes to this bug.