Spec URL: http://callkalpa.fedorapeople.org/sugar-flip/sugar-flip.spec SRPM URL: http://callkalpa.fedorapeople.org/sugar-flip/sugar-flip-1-1.fc16.src.rpm Description: Hi I just finished packaging sugar-flip. I highly appreciate a review. sugar-flip is a simple strategic game for sugar learning environment where you have to flip coins until they are all heads up. Each time you win, the challenge gets more difficult. You can play flips with your friends over the net.
Shall have this done by tomorrow max. I'm really sorry for the delay :/
[+] OK [-] NA [?] Issue [+] Package meets naming and packaging guidelines [+] Spec file matches base package name. [+] Spec has consistant macro usage. [+] Meets Packaging Guidelines. [+] License [?] License field in spec matches Looks like it should also include MIT/X11/BSD and not just GPLv3+? [ankur@ankur Flip-1]$ find . -name '*' -exec licensecheck '{}' \; | sed '/UNKNOWN/ d'| sort | uniq ./FlipActivity.py: GPL (v3 or later) ./game.py: GPL (v3 or later) ./sprites.py: MIT/X11 (BSD like) ./toolbar_utils.py: GPL (v3 or later) ./utils.py: GPL (v3 or later) [ankur@ankur Flip-1]$ [?] License file included in package MIT/X11/BSD license is not included. Not a blocker though. [+] Spec in American English [+] Spec is legible. [+] Sources match upstream md5sum: [ankur@ankur SOURCES]$ review-md5check.sh ../SPECS/sugar-flip.spec Getting http://download.sugarlabs.org/sources/honey/Flip/Flip-1.tar.bz2 to /tmp/review/Flip-1.tar.bz2 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 262 100 262 0 0 182 0 0:00:01 0:00:01 --:--:-- 853 100 23638 100 23638 0 0 5787 0 0:00:04 0:00:04 --:--:-- 13496 11b04aa7d6248b19f1447ff18ebb5f17 /tmp/review/Flip-1.tar.bz2 11b04aa7d6248b19f1447ff18ebb5f17 /home/ankur/rpmbuild/SOURCES/Flip-1.tar.bz2 [-] Package needs ExcludeArch [?] BuildRequires correct According to http://fedoraproject.org/wiki/Packaging:Python#BuildRequires the BR needs to be python{2,3}-devel. Please correct it [?] Spec handles locales/find_lang I see gettext included, but I don't see find_lang used in here. The generated rpm does not contain any translations as well: [ankur@ankur noarch]$ rpm -pql sugar-flip-1-1.fc18.noarch.rpm /usr/share/doc/sugar-flip-1 /usr/share/doc/sugar-flip-1/COPYING /usr/share/doc/sugar-flip-1/NEWS /usr/share/sugar/activities/Flip.activity /usr/share/sugar/activities/Flip.activity/COPYING /usr/share/sugar/activities/Flip.activity/FlipActivity.py /usr/share/sugar/activities/Flip.activity/FlipActivity.pyc /usr/share/sugar/activities/Flip.activity/FlipActivity.pyo /usr/share/sugar/activities/Flip.activity/NEWS /usr/share/sugar/activities/Flip.activity/activity /usr/share/sugar/activities/Flip.activity/activity/activity-flip.svg /usr/share/sugar/activities/Flip.activity/activity/activity.info /usr/share/sugar/activities/Flip.activity/game.py /usr/share/sugar/activities/Flip.activity/game.pyc /usr/share/sugar/activities/Flip.activity/game.pyo /usr/share/sugar/activities/Flip.activity/icons /usr/share/sugar/activities/Flip.activity/icons/new-game.svg /usr/share/sugar/activities/Flip.activity/setup.py /usr/share/sugar/activities/Flip.activity/setup.pyc /usr/share/sugar/activities/Flip.activity/setup.pyo /usr/share/sugar/activities/Flip.activity/sprites.py /usr/share/sugar/activities/Flip.activity/sprites.pyc /usr/share/sugar/activities/Flip.activity/sprites.pyo /usr/share/sugar/activities/Flip.activity/toolbar_utils.py /usr/share/sugar/activities/Flip.activity/toolbar_utils.pyc /usr/share/sugar/activities/Flip.activity/toolbar_utils.pyo /usr/share/sugar/activities/Flip.activity/utils.py /usr/share/sugar/activities/Flip.activity/utils.pyc /usr/share/sugar/activities/Flip.activity/utils.pyo [ankur@ankur noarch]$ [-] Package is relocatable and has a reason to be. [+] Package has %defattr and permissions on files is good. defattr not required anymore [+] Package is code or permissible content. [-] Doc subpackage needed/used. [+] Packages %doc files don't affect runtime. [?] Package is a GUI app and has a .desktop file This does feel like a GUI app. Please include a desktop file if this is so. [+] Package compiles and builds on at least one arch. Scratch build for rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=3930563 [?] Package has no duplicate files in %files. While there aren't duplicate files, are the setup.py? required? This is only required for building the package. It shouldn't be included in the rpm IMO. [+] Package doesn't own any directories other packages own. [+] Package owns all the directories it creates. [?] No rpmlint output. [ankur@ankur noarch]$ rpmlint sugar-flip-1-1.fc18.noarch.rpm ../../SPECS/sugar-flip.spec ../../SRPMS/sugar-flip-1-1.fc16.src.rpm sugar-flip.noarch: W: non-standard-group Sugar/Activities ../../SPECS/sugar-flip.spec:6: W: non-standard-group Sugar/Activities sugar-flip.src: W: non-standard-group Sugar/Activities 2 packages and 1 specfiles checked; 0 errors, 3 warnings. [ankur@ankur noarch]$ Not anything serious. Please recheck if the group you've used is a standard one. [+] final provides and requires are sane: Looks okay == sugar-flip-1-1.fc18.noarch.rpm == Provides: sugar-flip = 1-1.fc18 Requires: /usr/bin/env sugar [ankur@ankur temp]$ SHOULD Items: [+] Should build in mock. [+] Should build on all supported archs [?] Should function as described. Please verify this [+] Should have dist tag Issues: [?] License field in spec matches [?] License file included in package [?] BuildRequires correct [?] Spec handles locales/find_lang [?] Package is a GUI app and has a .desktop file [?] Package has no duplicate files in %files. [?] No rpmlint output.
Created attachment 572507 [details] Review notes in a text file
Hi Ankur thanks for the review. Here are the new files, hope now it is good to go. This runs in sugar-emulator so there's no need of a desktop file. Group, although not standard it is the one for sugar activities. Sugar packaging guide doesn't say about excluding setup.py. Perhaps if it is there children who use the activity can see it's source and learn. That may be the reason. Spec URL: http://callkalpa.fedorapeople.org/sugar-flip/sugar-flip.spec SRPM URL: http://callkalpa.fedorapeople.org/sugar-flip/sugar-flip-1-2.fc16.src.rpm rpmlint sugar-flip.spec ../SRPMS/sugar-flip-1-2.fc16.src.rpm ../RPMS/noarch/sugar-flip-1-2.fc16.noarch.rpm sugar-flip.spec:6: W: non-standard-group Sugar/Activities sugar-flip.src: W: non-standard-group Sugar/Activities sugar-flip.noarch: W: non-standard-group Sugar/Activities 2 packages and 1 specfiles checked; 0 errors, 3 warnings.
hello Kalpa, I just confirmed. The setup.py file isn't supposed to install itself. Please remove it from the rpm. It's an extraneous file and should not be included. If one wants to see how the package works, they're supposed to download the source, either from the source rpm or the source itself. The rest looks good to me. Please just remove the setup.py* files, and I will approve the package :) Thanks, Ankur
Hi Ankur, setup.py removed. Spec URL: http://callkalpa.fedorapeople.org/sugar-flip/sugar-flip.spec SRPM URL: http://callkalpa.fedorapeople.org/sugar-flip/sugar-flip-1-3.fc16.src.rpm rpmlint sugar-flip.spec ../SRPMS/sugar-flip-1-3.fc16.src.rpm ../RPMS/noarch/sugar-flip-1-3.fc16.noarch.rpm sugar-flip.spec:6: W: non-standard-group Sugar/Activities sugar-flip.src: W: non-standard-group Sugar/Activities sugar-flip.noarch: W: non-standard-group Sugar/Activities 2 packages and 1 specfiles checked; 0 errors, 3 warnings.
http://koji.fedoraproject.org/koji/taskinfo?taskID=3949499 XXX APPROVED XXX
New Package SCM Request ======================= Package Name: sugar-flip Short Description: Simple strategic game for sugar Owners: callkalpa Branches: f15 f16 f17 InitialCC: pbrobinson
Git done (by process-git-requests).
sugar-flip-3-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/sugar-flip-3-2.fc16
sugar-flip-3-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/sugar-flip-3-2.fc15
sugar-flip-3-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/sugar-flip-3-2.fc17
sugar-flip-3-2.fc17 has been pushed to the Fedora 17 testing repository.
sugar-flip-3-2.fc16 has been pushed to the Fedora 16 stable repository.
sugar-flip-3-2.fc15 has been pushed to the Fedora 15 stable repository.
sugar-flip-3-2.fc17 has been pushed to the Fedora 17 stable repository.